Skip to contentSkip to conversation

gstreamer-imx: new package

PATCH Superseded Peter Seiderer 5 participants 5 messages Feb 24, 2014 – Feb 25, 2014 Arm i.MX and Layerscape

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gstreamer-imx: new package

---
 package/gstreamer1/Config.in                       |  1 +
 package/gstreamer1/gstreamer-imx/Config.in         | 21 ++++++++++++
 ...headers-include-path-to-src-v4l2src-compi.patch | 31 ++++++++++++++++++
 package/gstreamer1/gstreamer-imx/gstreamer-imx.mk  | 37 ++++++++++++++++++++++
 4 files changed, 90 insertions(+)
 create mode 100644 package/gstreamer1/gstreamer-imx/Config.in
 create mode 100644 package/gstreamer1/gstreamer-imx/gstreamer-imx-0001-Add-kernel-headers-include-path-to-src-v4l2src-compi.patch
 create mode 100644 package/gstreamer1/gstreamer-imx/gstreamer-imx.mk
package/gstreamer1/Config.in +1 -0
index fe0ad48..0068a8f 100644
@@ -8,4 +8,5 @@ source "package/gstreamer1/gst1-plugins-bad/Config.in"
 source "package/gstreamer1/gst1-plugins-ugly/Config.in"
 source "package/gstreamer1/gst1-libav/Config.in"
 source "package/gstreamer1/gst-omx/Config.in"
+source "package/gstreamer1/gstreamer-imx/Config.in"
 endif
package/gstreamer1/gstreamer-imx/Config.in new file +21 -0
new file mode 100644
index 0000000..bcd77ca
@@ -0,0 +1,21 @@
+comment "gst-fsl-plugins needs an imx-specific Linux kernel to be built"
+	depends on BR2_arm && !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_GSTREAMER_IMX
+	bool "gstreamer-imx"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_arm # Only relevant for i.MX
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_IMX_LIB
+	select BR2_PACKAGE_LIBFSLPARSER
+	select BR2_PACKAGE_LIBFSLCODEC
+	help
+	  GStreamer-1.x plugins for hardware-accelerated audio and video
+	  parsers and codecs on i.MX6 platform. It requires a kernel that
+	  includes the i.MX6 specific headers to be built.
+
+	  To use the VPU, its firmware blob must be installed as well. This
+	  can be found in the firmware-imx package in the "Hardware handling"
+	  menu.
+
+	  https://github.com/Freescale/gstreamer-imx
package/gstreamer1/gstreamer-imx/gstreamer-imx-0001-Add-kernel-headers-include-path-to-src-v4l2src-compi.patch new file +31 -0
new file mode 100644
index 0000000..48e2c16
@@ -0,0 +1,31 @@
+From 107767b506de69692436205c04a002e5de0f7bee Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Sat, 22 Feb 2014 23:22:26 +0100
+Subject: [PATCH] Add kernel headers include path to src/v4l2src compile.
+
+Fixes buildroot compile with newer sysroot kernel headers
+(> 3.10 because of VIDIOC_DBG_G_CHIP_IDENT ioctl removale).
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ src/v4l2src/wscript | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/v4l2src/wscript b/src/v4l2src/wscript
+index 0b8fbb1..3013ba7 100644
+--- a/src/v4l2src/wscript
++++ b/src/v4l2src/wscript
+@@ -2,7 +2,9 @@
+ 
+ 
+ def configure(conf):
+-	pass
++	import os
++	if conf.options.kernel_headers:
++		conf.env.append_value('INCLUDES', [os.path.abspath(os.path.expanduser(conf.options.kernel_headers))])
+ 
+ 
+ def build(bld):
+-- 
+1.8.1.4
+
package/gstreamer1/gstreamer-imx/gstreamer-imx.mk new file +37 -0
new file mode 100644
index 0000000..3192056
@@ -0,0 +1,37 @@
+################################################################################
+#
+# gstreamer-imx
+#
+################################################################################
+
+GSTREAMER_IMX_VERSION = 0.9.3
+GSTREAMER_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GSTREAMER_IMX_VERSION))
+
+GSTREAMER_IMX_LICENSE = LGPLv2+
+GSTREAMER_IMX_LICENSE_FILES = LICENSE
+
+GSTREAMER_IMX_DEPENDENCIES = gstreamer1 gst1-plugins-base libfslvpuwrap \
+	imx-lib libfslparser libfslcodec
+
+# needs access to imx-specific kernel headers
+GST_FSL_PLUGINS_DEPENDENCIES += linux
+
+define GSTREAMER_IMX_CONFIGURE_CMDS
+	$(GSTREAMER_IMX_WITHOUT_X11)
+	(cd $(@D); \
+		$(TARGET_CONFIGURE_OPTS) \
+		./waf configure \
+		--prefix=/usr \
+		--kernel-headers=$(LINUX_DIR)/include \
+	)
+endef
+
+define GSTREAMER_IMX_BUILD_CMDS
+       (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+endef
+
+define GSTREAMER_IMX_INSTALL_TARGET_CMDS
+       (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 1/1 gstreamer-imx: new package

Peter, All,

On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:

Quoted 1 line

How is gstreamer-imx different from gst-fsl-plugins?

From package/gstreamer/gst-fsl-plugins/Config.in:

GStreamer plugins for hardware-accelerated audio and video parsers and codecs on i.MX platforms. [...]

So, it seems we already have a package that handles accelerated audio/video decoding on i.MX.

[--SNIP--]

Quoted 15 lines
package/gstreamer1/gstreamer-imx/Config.in new file +9 -0
new file mode 100644
index 0000000..bcd77ca
@@ -0,0 +1,21 @@
+comment "gst-fsl-plugins needs an imx-specific Linux kernel to be built"
+	depends on BR2_arm && !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_GSTREAMER_IMX
+	bool "gstreamer-imx"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_arm # Only relevant for i.MX
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_IMX_LIB

package/gstreamer1/gstreamer-imx/Config.in line 19

Quoted 10 lines
package/gstreamer1/gstreamer-imx/Config.in new file +10 -0
+	select BR2_PACKAGE_LIBFSLPARSER
+	select BR2_PACKAGE_LIBFSLCODEC
+	help
+	  GStreamer-1.x plugins for hardware-accelerated audio and video
+	  parsers and codecs on i.MX6 platform. It requires a kernel that
+	  includes the i.MX6 specific headers to be built.
+
+	  To use the VPU, its firmware blob must be installed as well. This
+	  can be found in the firmware-imx package in the "Hardware handling"
+	  menu.

You even use a very similar wording in the help text.

Care to elaborate in the commit log why we need this gstreamer-imx package:
- is it specific to i.MX6?
- can it replace the existing gst-fsl-plugins?

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 gstreamer-imx: new package

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Peter, All,
On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:

Quoted 1 line

How is gstreamer-imx different from gst-fsl-plugins?

Quoted 7 lines
Quoted 1 line

From package/gstreamer/gst-fsl-plugins/Config.in:

GStreamer plugins for hardware-accelerated audio and video parsers and codecs on i.MX platforms. [...]

So, it seems we already have a package that handles accelerated audio/video decoding on i.MX.

Yes, but gst-fsl-plugins is for the deprecated gstreamer 0.10.x series, this is for gstreamer 1.x.

Quoted 1 line

package/gstreamer1/gstreamer-imx/Config.in

Quoted 1 line
package/gstreamer1/gstreamer-imx/Config.in +0 -0

Which is also why it is under package/gstreamer1. Perhaps the package should be called gstreamer1-imx to make it completely clear.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 gstreamer-imx: new package

Quoted 16 lines · Peter Korsgaard
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Peter, All,
On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:

Quoted 1 line

How is gstreamer-imx different from gst-fsl-plugins?

Quoted 7 lines
Quoted 1 line

From package/gstreamer/gst-fsl-plugins/Config.in:

GStreamer plugins for hardware-accelerated audio and video parsers and codecs on i.MX platforms. [...]

So, it seems we already have a package that handles accelerated audio/video decoding on i.MX.

Quoted 7 lines

Yes, but gst-fsl-plugins is for the deprecated gstreamer 0.10.x series, this is for gstreamer 1.x.

Quoted 1 line

package/gstreamer1/gstreamer-imx/Config.in

Quoted 1 line
package/gstreamer1/gstreamer-imx/Config.in +0 -0

Which is also why it is under package/gstreamer1. Perhaps the package should be called gstreamer1-imx to make it completely clear.

I agree with the suggested rename

Regards,

Signature · 1 line
Samuel
#4 lore raw

PATCH 1/1 gstreamer-imx: new package

Quoted 20 lines · Samuel Martin
Quoted 19 lines · Peter Korsgaard
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Peter, All,
On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:

Quoted 1 line

How is gstreamer-imx different from gst-fsl-plugins?

Quoted 7 lines
Quoted 1 line

From package/gstreamer/gst-fsl-plugins/Config.in:

GStreamer plugins for hardware-accelerated audio and video parsers and codecs on i.MX platforms. [...]

So, it seems we already have a package that handles accelerated audio/video decoding on i.MX.

Yes, but gst-fsl-plugins is for the deprecated gstreamer 0.10.x series, this is for gstreamer 1.x.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

package/gstreamer1/gstreamer-imx/Config.in

Quoted 1 line
package/gstreamer1/gstreamer-imx/Config.in +0 -0

Which is also why it is under package/gstreamer1. Perhaps the package should be called gstreamer1-imx to make it completely clear.

I agree with the suggested rename

We didn't do that for gst-omx, however. Does anyone remember why not?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F