Skip to contentSkip to conversation

watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

PATCH RESEND Applied Fabio Estevam 2 participants 2 messages Feb 25, 2014 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 watchdog: orion_wdt: Use %pa to print 'phys_addr_t'

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/orion_wdt.c +1 -1
index 15321aa..6f9b4c6 100644
@@ -269,7 +269,7 @@ static void __iomem *orion_wdt_ioremap_rstout(struct platform_device *pdev,
 
 	rstout = internal_regs + ORION_RSTOUT_MASK_OFFSET;
 
-	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg 0x%x\n", rstout);
+	WARN(1, FW_BUG "falling back to harcoded RSTOUT reg %pa\n", &rstout);
 	return devm_ioremap(&pdev->dev, rstout, 0x4);
 }
 
Signature · 1 line
1.8.1.2
Applied
#1 lore raw

Fabio,

Thanks for the resend.

Quoted 7 lines · Fabio Estevam

When building an ARM multi_v7_defconfig with LPAE option selected we get the following build warning:

drivers/watchdog/orion_wdt.c:272:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]

Fix it by using %pa to print 'phys_addr_t'.

Quoted 8 lines
---
 drivers/watchdog/orion_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to mvebu/watchdog.

thx,

Jason.