Skip to contentSkip to conversation

linux-next: build failure after merge of the final tree (akpm-current tree related)

PATCH Applied Stephen Rothwell 4 participants 14 messages Feb 26, 2014 – Feb 28, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") from the apm-current tree.

I have reverted that commit for today.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#1 lore raw
Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") from the apm-current tree.

Pre-existing, just now triggerable with just "make allnoconfig" rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.)

The following (untested) patch *should* fix this:
----- 8< -----

Quoted 1 line

From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001

From: Josh Triplett <[email protected]>
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK

arch/powerpc/kernel/mce.c, compiled in for PPC_BOOK3S_64, calls functions only built when IRQ_WORK, so select it. Fixes the following build error:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

---
 arch/powerpc/platforms/Kconfig.cputype | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/Kconfig.cputype +1 -0
index 434fda3..d9e2b19 100644
@@ -73,6 +73,7 @@ config PPC_BOOK3S_64
 	select SYS_SUPPORTS_HUGETLBFS
 	select HAVE_ARCH_TRANSPARENT_HUGEPAGE if PPC_64K_PAGES
 	select ARCH_SUPPORTS_NUMA_BALANCING
+	select IRQ_WORK
 
 config PPC_BOOK3E_64
 	bool "Embedded processors"
Signature · 1 line
1.9.0
#2 lore raw

Hi Josh,

Quoted 18 lines · On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett <[email protected]> wrote:
Quoted 10 lines · Stephen Rothwell

After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") from the apm-current tree.

Pre-existing, just now triggerable with just "make allnoconfig" rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.)

Quoted 6 lines

The following (untested) patch *should* fix this:
----- 8< -----
From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
From: Josh Triplett <[email protected]>
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK

OK, I added this as a merge fix patch for Andrew's tree today. Please check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#3 lore raw
Quoted 28 lines · On Thu, 27 Feb 2014 10:00:26 +1100 Stephen Rothwell <[email protected]>…

Hi Josh,

Quoted 18 lines · On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett <[email protected]> wrote:
Quoted 10 lines · Stephen Rothwell

After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") from the apm-current tree.

Pre-existing, just now triggerable with just "make allnoconfig" rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.)

Quoted 6 lines

The following (untested) patch *should* fix this:
----- 8< -----
From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
From: Josh Triplett <[email protected]>
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK

Quoted 4 lines

OK, I added this as a merge fix patch for Andrew's tree today. Please check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors.

yes, let's keep kconfig-make-allnoconfig-disable-options-behind-embedded-and-expert, please. We'll just need to slog our way through the breakage which it exposes.

#4 lore raw
In reply to Stephen Rothwell
Quoted 28 lines · Stephen Rothwell

Hi Josh,

Quoted 18 lines · On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett <[email protected]> wrote:
Quoted 10 lines · Stephen Rothwell

After merging the final tree, today's linux-next build (powerpc64 allnoconfig) failed like this:

arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'

Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") from the apm-current tree.

Pre-existing, just now triggerable with just "make allnoconfig" rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.)

Quoted 6 lines

The following (untested) patch *should* fix this:
----- 8< -----
From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
From: Josh Triplett <[email protected]>
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK

Quoted 4 lines

OK, I added this as a merge fix patch for Andrew's tree today. Please check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors.

Please also fold in my patch "ia64: select CONFIG_TTY for use of tty_write_message in unaligned". (Just bounced you a copy.)

There's an s390 issue as well which needs the same fix (make the top-level architecture symbol select TTY).

I'll look at the other issues tonight.

- Josh Triplett

#5 lore raw

Hi Josh,

Quoted 3 lines · On Wed, 26 Feb 2014 15:19:16 -0800 Josh Triplett <[email protected]> wrote:

Please also fold in my patch "ia64: select CONFIG_TTY for use of tty_write_message in unaligned". (Just bounced you a copy.)

Done.

Quoted 4 lines

There's an s390 issue as well which needs the same fix (make the top-level architecture symbol select TTY).

I'll look at the other issues tonight.

OK, thanks.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#6 lore raw

PATCH 1/1 s390: select CONFIG_TTY for use of tty in unconditional keyboard driver

The unconditionally built keyboard driver, drivers/s390/char/keyboard.c, requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build error.

---
 arch/s390/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/s390/Kconfig +1 -0
index 65a0775..398efa1 100644
@@ -140,6 +140,7 @@ config S390
 	select OLD_SIGACTION
 	select OLD_SIGSUSPEND3
 	select SYSCTL_EXCEPTION_TRACE
+	select TTY
 	select VIRT_CPU_ACCOUNTING
 	select VIRT_TO_BUS
 
Signature · 1 line
1.9.0
#7 lore raw

Re: [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver

Hi Josh,

Quoted 6 lines · On Wed, 26 Feb 2014 18:13:06 -0800 Josh Triplett <[email protected]> wrote:

The unconditionally built keyboard driver, drivers/s390/char/keyboard.c, requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build error.

Will be added to linux-next today.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#8 lore raw

Re: [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver

In reply to Josh Triplett
Quoted 8 lines · Josh Triplett

The unconditionally built keyboard driver, drivers/s390/char/keyboard.c, requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build error.

---
 arch/s390/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks!

#9 lore raw

PATCH 1/1 cris: Make ETRAX_ARCH_V10 select TTY for use in debugport

In reply to Stephen Rothwell

arch/cris/arch-v10/kernel/debugport.c, compiled in unconditionally with ETRAX_ARCH_V10, requires TTY, so select TTY to avoid a build failure.

---
 arch/cris/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/cris/Kconfig +1 -0
index ed0fcdf..7cb90a5 100644
@@ -138,6 +138,7 @@ config ETRAX_ARCH_V10
        bool
        default y if ETRAX100LX || ETRAX100LX_V2
        default n if !(ETRAX100LX || ETRAX100LX_V2)
+       select TTY
 
 config ETRAX_ARCH_V32
        bool
Signature · 1 line
1.9.0
#10 lore raw

Re: [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport

Quoted 5 lines · On Thu, 27 Feb 2014 17:27:34 -0800 Josh Triplett <[email protected]> wrote:

arch/cris/arch-v10/kernel/debugport.c, compiled in unconditionally with ETRAX_ARCH_V10, requires TTY, so select TTY to avoid a build failure.

Added to linux-next today.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#11 lore raw
In reply to Stephen Rothwell
Quoted 3 lines · Stephen Rothwell

Please check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors.

Checking that site, I don't see any other instances of failures caused by allnoconfig. If I'm missing some, could you please point me to the page on that site I'm missing?

- Josh Triplett

#12 lore raw

Hi Josh,

Quoted 9 lines · On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett <[email protected]> wrote:
Quoted 3 lines · Stephen Rothwell

Please check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors.

Checking that site, I don't see any other instances of failures caused by allnoconfig. If I'm missing some, could you please point me to the page on that site I'm missing?

That is because your patch was reverted in yesterday's (next-20140226) linux-next. You will need to look tomorrow (next-20140227) sometime.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#13 lore raw
Quoted 9 lines · Stephen Rothwell

Hi Josh,

Quoted 6 lines · On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett <[email protected]> wrote:
Quoted 3 lines · Stephen Rothwell

Please check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for the allnoconfig build errors.

Quoted 6 lines
Quoted 3 lines

Checking that site, I don't see any other instances of failures caused by allnoconfig. If I'm missing some, could you please point me to the page on that site I'm missing?

That is because your patch was reverted in yesterday's (next-20140226) linux-next. You will need to look tomorrow (next-20140227) sometime.

It looks like the next-20140227 builds have shown up, and I only see one additional allnoconfig build failure exposed by my patch (TTY dependency on cris arch-v10). I sent a patch for that one.

I *think* that should have it covered; let me know if you see any other failures.

- Josh Triplett