Skip to contentSkip to conversation

undefined reference to `tty_write_message'

PATCH New kbuild test robot 2 participants 3 messages Feb 26, 2014 Memory management

lore
Share & tools
lore

kbuild test robot

author build bot
#0 lore raw
tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   a6a1126d3535f0bd8d7c56810061541a4f5595af
commit: 5837644fad4fdcc7a812eb1f3a215d8196628627 [326/350] kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT
config: make ARCH=ia64 allnoconfig

All error/warnings:

arch/ia64/kernel/built-in.o: In function `ia64_handle_unaligned':

>> (.text+0x1b882): undefined reference to `tty_write_message'

---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#1 lore raw
Quoted 9 lines · kbuild test robot
tree:   git://git.cmpxchg.org/linux-mmotm.git master
head:   a6a1126d3535f0bd8d7c56810061541a4f5595af
commit: 5837644fad4fdcc7a812eb1f3a215d8196628627 [326/350] kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT
config: make ARCH=ia64 allnoconfig

All error/warnings:

arch/ia64/kernel/built-in.o: In function `ia64_handle_unaligned':

Quoted 1 line
Quoted 1 line

(.text+0x1b882): undefined reference to `tty_write_message'

Looks like ia64 is broken with CONFIG_TTY=n. Why in the world does arch/ia64/kernel/unaligned.c call tty_write_message on the tty of the current process? That's just *wrong*.

Would anything go horribly wrong if the tty_write_message just went away, leaving only the printk? (Bonus: no need to sprintf first.)

- Josh Triplett

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

#2 lore raw

PATCH 1/1 ia64: select CONFIG_TTY for use of tty_write_message in unaligned

arch/ia64/kernel/unaligned.c uses tty_write_message to print an unaligned access exception to the TTY of the current user process. Enable TTY to prevent a build error.

---
Not tested, but this *should* fix the build error with CONFIG_TTY=n.

Minimal fix, on the basis that few people on ia64 will care deeply about kernel size enough to turn off TTY. Ideally, I'd instead suggest dropping the tty_write_message entirely, and just leaving the printk.
Bonus: no need to sprintf first.

 arch/ia64/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/ia64/Kconfig +1 -0
index 0c8e553..6b83c66 100644
@@ -44,6 +44,7 @@ config IA64
 	select HAVE_MOD_ARCH_SPECIFIC
 	select MODULES_USE_ELF_RELA
 	select ARCH_USE_CMPXCHG_LOCKREF
+	select TTY
 	default y
 	help
 	  The Itanium Processor Family is Intel's 64-bit successor to
Signature · 1 line
1.9.0