Skip to contentSkip to conversation

package/ti-gfx: do not forcefully remove source dir on extract

PATCH New Yann E. MORIN 3 participants 6 messages Feb 26, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/ti-gfx: do not forcefully remove source dir on extract

From: "Yann E. MORIN" <[email protected]>

ti-gfx uses custom extract commands, which first and foremost removes the source dir unconditionally.

Thee side-effect of this is that make will re-extract, re-patch and probably re-build ti-gfx at each run.

Cc Spenser Gilliland <[email protected]>
---
 package/ti-gfx/ti-gfx.mk | 1 -
 1 file changed, 1 deletion(-)
package/ti-gfx/ti-gfx.mk +0 -1
index 5ea6b92..e48715d 100644
@@ -90,7 +90,6 @@ TI_GFX_HDR_DIRS = OGLES2/EGL OGLES2/EWS OGLES2/GLES2 OGLES2/KHR \
 	OGLES/GLES bufferclass_ti/ pvr2d/ wsegl/
 
 define TI_GFX_EXTRACT_CMDS
-	$(RM) -rf $(TI_GFX_DIR)
 	chmod +x $(DL_DIR)/$(TI_GFX_SOURCE)
 	printf "Y\nY\n qY\n\n" | $(DL_DIR)/$(TI_GFX_SOURCE) \
 		--prefix $(@D) \
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 package/ti-gfx: do not forcefully remove source dir on extract

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

From: "Yann E. MORIN" <[email protected]>
ti-gfx uses custom extract commands, which first and foremost removes the source dir unconditionally.

Thee side-effect of this is that make will re-extract, re-patch and probably re-build ti-gfx at each run.

Cc Spenser Gilliland <[email protected]>

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/ti-gfx: do not forcefully remove source dir on extract

In reply to Yann E. MORIN
Quoted 7 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

ti-gfx uses custom extract commands, which first and foremost removes the source dir unconditionally.

Thee side-effect of this is that make will re-extract, re-patch and probably re-build ti-gfx at each run.

There actually was a reason for this - I think the extract fails if you
re-run it. Have you tried

make ti-gfx-extract; make ti-gfx-extract

?

Regards,
Arnout

Quoted 20 lines
Cc Spenser Gilliland <[email protected]>
---
 package/ti-gfx/ti-gfx.mk | 1 -
 1 file changed, 1 deletion(-)
package/ti-gfx/ti-gfx.mk +0 -1
index 5ea6b92..e48715d 100644
@@ -90,7 +90,6 @@ TI_GFX_HDR_DIRS = OGLES2/EGL OGLES2/EWS OGLES2/GLES2 OGLES2/KHR \
 	OGLES/GLES bufferclass_ti/ pvr2d/ wsegl/
 
 define TI_GFX_EXTRACT_CMDS
-	$(RM) -rf $(TI_GFX_DIR)
 	chmod +x $(DL_DIR)/$(TI_GFX_SOURCE)
 	printf "Y\nY\n qY\n\n" | $(DL_DIR)/$(TI_GFX_SOURCE) \
 		--prefix $(@D) \
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 package/ti-gfx: do not forcefully remove source dir on extract

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 5 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

ti-gfx uses custom extract commands, which first and foremost removes the source dir unconditionally.

Quoted 7 lines
Quoted 2 lines

Thee side-effect of this is that make will re-extract, re-patch and probably re-build ti-gfx at each run.

There actually was a reason for this - I think the extract fails if you
re-run it. Have you tried

make ti-gfx-extract; make ti-gfx-extract

That afaik simply says nothing to do, like it should.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 package/ti-gfx: do not forcefully remove source dir on extract

Quoted 11 lines · Peter Korsgaard
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 7 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

ti-gfx uses custom extract commands, which first and foremost removes the source dir unconditionally.

Thee side-effect of this is that make will re-extract, re-patch and probably re-build ti-gfx at each run.

Quoted 6 lines
Quoted 4 lines

There actually was a reason for this - I think the extract fails if you
re-run it. Have you tried

make ti-gfx-extract; make ti-gfx-extract

That afaik simply says nothing to do, like it should.

I mean if the stamp file is removed.

But I realize now that this is something that doesn't necessarily work
anyway, so please ignore my comment.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#5 lore raw

PATCH 1/1 package/ti-gfx: do not forcefully remove source dir on extract

In reply to Arnout Vandecappelle

Arnout, All,

On 2014-02-26 22:33 +0100, Arnout Vandecappelle spake thusly:

Quoted 6 lines · Yann E. MORIN
Quoted 5 lines

From: "Yann E. MORIN" <[email protected]>

ti-gfx uses custom extract commands, which first and foremost removes the source dir unconditionally.

Quoted 7 lines
Quoted 2 lines

Thee side-effect of this is that make will re-extract, re-patch and probably re-build ti-gfx at each run.

There actually was a reason for this - I think the extract fails if you
re-run it. Have you tried

make ti-gfx-extract; make ti-gfx-extract

I shall try that right away... Nope, works!

I eventually understood what was going on. Basically, when you run:

make ti-gfx-extract

under the hood, it's as you did:

make ti-gfx-source
make ti-gfx-extract

But -source creates a stamp file. Then -extract would remove the directory, thus removing the stamp file.

10 When you run make again, the stamp file for the download is missing, so make tries to download it again (invisible, since we already have the archive), creates the stamp file, and extract again, which removes the stamp file.
20 GOTO 10.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'