Skip to contentSkip to conversation

Kbuild: A collection of trivial refactoring

PATCH New Masahiro Yamada 5 participants 26 messages Feb 26, 2014 – Mar 5, 2014

Subsystems (5)
Arm (32-bit) x86 Kbuild SuperH +1 more subsystems
lore
Share & tools
lore
#0 lore raw

cover Kbuild: A collection of trivial refactoring

Masahiro Yamada (8):
config.mk: Delete unused variable BCURDIR
Makefile: delete unused variable LDSCRIPT_MAKEFILE_DIR
nand_spl: simpc8313: move config.mk used only for nand_spl
x86: Delete redundant compiler flags
sh: Do not define -ffreestanding twice
sh: merge compiler flag -ffixed-r13
m68k: merge compile flags -ffixed-d7 -sep-data
arm64: Do not double -mstrict-align option

 Makefile                                              | 4 ----
 arch/arm/cpu/armv8/config.mk                          | 1 -
 arch/m68k/config.mk                                   | 3 ++-
 arch/m68k/cpu/mcf5227x/config.mk                      | 1 -
 arch/m68k/cpu/mcf523x/config.mk                       | 1 -
 arch/m68k/cpu/mcf52x2/config.mk                       | 2 --
 arch/m68k/cpu/mcf532x/config.mk                       | 2 --
 arch/m68k/cpu/mcf5445x/config.mk                      | 2 --
 arch/m68k/cpu/mcf547x_8x/config.mk                    | 1 -
 arch/sh/config.mk                                     | 1 +
 arch/sh/cpu/sh2/config.mk                             | 3 +--
 arch/sh/cpu/sh3/config.mk                             | 1 -
 arch/sh/cpu/sh4/config.mk                             | 1 -
 arch/x86/config.mk                                    | 5 +----
 config.mk                                             | 2 --
 nand_spl/board/sheldon/simpc8313/Makefile             | 2 ++
 {board => nand_spl/board}/sheldon/simpc8313/config.mk | 0
 17 files changed, 7 insertions(+), 25 deletions(-)
 rename {board => nand_spl/board}/sheldon/simpc8313/config.mk (100%)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/8 config.mk: Delete unused variable BCURDIR

This variable was abolished by Kbuild series.
I forgot to delete it.

---

 config.mk | 2 --
 1 file changed, 2 deletions(-)
config.mk +0 -2
index 9897f20..e59697f 100644
@@ -46,7 +46,5 @@ OBJCOPYFLAGS += --gap-fill=0xff
 CPPFLAGS = $(RELFLAGS)
 CPPFLAGS += -pipe $(PLATFORM_CPPFLAGS)
 
-BCURDIR = $(subst $(SRCTREE)/,,$(CURDIR:$(obj)%=%))
-
 LDFLAGS += $(PLATFORM_LDFLAGS)
 LDFLAGS_FINAL += -Bstatic
Signature · 1 line
1.8.3.2
#2 lore raw

PATCH 1/8 config.mk: Delete unused variable BCURDIR

Quoted 4 lines · Masahiro Yamada

This variable was abolished by Kbuild series.
I forgot to delete it.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140304/4a684769/attachment.pgp>
#3 lore raw

PATCH 2/8 Makefile: delete unused variable LDSCRIPT_MAKEFILE_DIR

In reply to Masahiro Yamada

LDSCRIPT_MAKEFILE_DIR is not referenced from anywhere. Remove.

---

 Makefile | 4 ----
 1 file changed, 4 deletions(-)
Makefile +0 -4
index d3b0afb..fe9e144 100644
@@ -489,8 +489,6 @@ endif
 # that (or fail if absent).  Otherwise, search for a linker script in a
 # standard location.
 
-LDSCRIPT_MAKEFILE_DIR = $(dir $(LDSCRIPT))
-
 ifndef LDSCRIPT
 	#LDSCRIPT := $(TOPDIR)/board/$(BOARDDIR)/u-boot.lds.debug
 	ifdef CONFIG_SYS_LDSCRIPT
@@ -515,8 +513,6 @@ ifndef LDSCRIPT
 	endif
 	ifeq ($(wildcard $(LDSCRIPT)),)
 		LDSCRIPT := $(TOPDIR)/arch/$(ARCH)/cpu/u-boot.lds
-		# We don't expect a Makefile here
-		LDSCRIPT_MAKEFILE_DIR =
 	endif
 endif
 
Signature · 1 line
1.8.3.2
#4 lore raw

PATCH 2/8 Makefile: delete unused variable LDSCRIPT_MAKEFILE_DIR

Quoted 3 lines · Masahiro Yamada

LDSCRIPT_MAKEFILE_DIR is not referenced from anywhere. Remove.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140304/f7621864/attachment.pgp>
#5 lore raw

PATCH 3/8 nand_spl: simpc8313: move config.mk used only for nand_spl

In reply to Masahiro Yamada

board/sheldon/simpc8313/config.mk is used only for nand_spl. So it should go into nand_spl/board/sheldon/simpc8313/.

---

 nand_spl/board/sheldon/simpc8313/Makefile             | 2 ++
 {board => nand_spl/board}/sheldon/simpc8313/config.mk | 0
 2 files changed, 2 insertions(+)
 rename {board => nand_spl/board}/sheldon/simpc8313/config.mk (100%)
nand_spl/board/sheldon/simpc8313/Makefile +2 -0
index 32afc27..8b29e97 100644
@@ -7,6 +7,8 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
+include $(srctree)/$(src)/config.mk
+
 nandobj	:= $(OBJTREE)/nand_spl/
 
 LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds
nand_spl/board/sheldon/simpc8313/config.mk renamed from board/sheldon/simpc8313/config.mk +0 -0
similarity index 100%
rename from board/sheldon/simpc8313/config.mk
rename to nand_spl/board/sheldon/simpc8313/config.mk
Signature · 1 line
1.8.3.2
#6 lore raw

PATCH 3/8 nand_spl: simpc8313: move config.mk used only for nand_spl

Quoted 4 lines · Masahiro Yamada

board/sheldon/simpc8313/config.mk is used only for nand_spl. So it should go into nand_spl/board/sheldon/simpc8313/.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140304/44e9ddfa/attachment.pgp>
#7 lore raw

PATCH 4/8 x86: Delete redundant compiler flags

In reply to Masahiro Yamada

-Wstrict-prototypes, -ffreestanding, -fno-stack-protector are defined at the top Makefile for all architectures.

Do not define them twice for x86.

---

 arch/x86/config.mk | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
arch/x86/config.mk +1 -4
index 4a4ad80..58dff14 100644
@@ -8,13 +8,10 @@
 CONFIG_STANDALONE_LOAD_ADDR ?= 0x40000
 
 PLATFORM_CPPFLAGS += -fno-strict-aliasing
-PLATFORM_CPPFLAGS += -Wstrict-prototypes
 PLATFORM_CPPFLAGS += -mregparm=3
 PLATFORM_CPPFLAGS += -fomit-frame-pointer
-PF_CPPFLAGS_X86   := $(call cc-option, -ffreestanding) \
-		     $(call cc-option, -fno-toplevel-reorder, \
+PF_CPPFLAGS_X86   := $(call cc-option, -fno-toplevel-reorder, \
 		       $(call cc-option, -fno-unit-at-a-time)) \
-		     $(call cc-option, -fno-stack-protector) \
 		     $(call cc-option, -mpreferred-stack-boundary=2)
 PLATFORM_CPPFLAGS += $(PF_CPPFLAGS_X86)
 PLATFORM_CPPFLAGS += -fno-dwarf2-cfi-asm
Signature · 1 line
1.8.3.2
#9 lore raw

PATCH 4/8 x86: Delete redundant compiler flags

In reply to Masahiro Yamada
Quoted 8 lines · Masahiro Yamada

-Wstrict-prototypes, -ffreestanding, -fno-stack-protector are defined at the top Makefile for all architectures.

Do not define them twice for x86.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140304/cc37e9c2/attachment.pgp>
#10 lore raw

PATCH 5/8 sh: Do not define -ffreestanding twice

In reply to Masahiro Yamada

-ffreestanding is defined at the top Makefile for all architectures. Do not define it twice for SH2A.

Cc Nobuhiro Iwamatsu <[email protected]>

---

 arch/sh/cpu/sh2/config.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/cpu/sh2/config.mk +1 -1
index 69273b4..25abcdd 100644
@@ -8,7 +8,7 @@
 ENDIANNESS += -EB
 
 ifdef CONFIG_SH2A
-PLATFORM_CPPFLAGS += -m2a -m2a-nofpu -mb -ffreestanding
+PLATFORM_CPPFLAGS += -m2a -m2a-nofpu -mb
 else # SH2
 PLATFORM_CPPFLAGS += -m3e -mb
 endif
Signature · 1 line
1.8.3.2
#11 lore raw

PATCH 5/8 sh: Do not define -ffreestanding twice

Applied, thanks.

Best regards,
Nobuhiro

2014-02-26 14:51 GMT+09:00 Masahiro Yamada <[email protected]>:

Quoted 30 lines

-ffreestanding is defined at the top Makefile for all architectures. Do not define it twice for SH2A.

Cc Nobuhiro Iwamatsu <[email protected]>

---

 arch/sh/cpu/sh2/config.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sh/cpu/sh2/config.mk +1 -2
index 69273b4..25abcdd 100644
@@ -8,7 +8,7 @@
 ENDIANNESS += -EB
 
 ifdef CONFIG_SH2A
-PLATFORM_CPPFLAGS += -m2a -m2a-nofpu -mb -ffreestanding
+PLATFORM_CPPFLAGS += -m2a -m2a-nofpu -mb
 else # SH2
 PLATFORM_CPPFLAGS += -m3e -mb
 endif
--

1.8.3.2

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 1 line
Nobuhiro Iwamatsu
#12 lore raw

PATCH 5/8 sh: Do not define -ffreestanding twice

Hello Nobihiro,

Thanks.

I want this and 6/8 on u-boot/master.

Can you please send pull-request now?

Best Regards
Masahiro Yamada

#13 lore raw

PATCH 5/8 sh: Do not define -ffreestanding twice

Quoted 7 lines · Masahiro Yamada

Hello Nobihiro,

Thanks.

I want this and 6/8 on u-boot/master.

Can you please send pull-request now?

Yes, soon please :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140304/31b03b04/attachment.pgp>
#14 lore raw

PATCH 5/8 sh: Do not define -ffreestanding twice

Hi,

These were already applied to u-boot/master.
Thanks, Tom,.

Nobuhiro

2014-03-05 5:37 GMT+09:00 Tom Rini <[email protected]>:

Quoted 20 lines · Masahiro Yamada
Quoted 8 lines

Hello Nobihiro,

Thanks.

I want this and 6/8 on u-boot/master.

Can you please send pull-request now?

Yes, soon please :)

--
Tom

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 1 line
Nobuhiro Iwamatsu
#15 lore raw

PATCH 5/8 sh: Do not define -ffreestanding twice

Quoted 4 lines · Nobuhiro Iwamatsu

Hi,

These were already applied to u-boot/master.
Thanks, Tom,.

Bah, I was intending to not apply them, but I guess dropped them too late. So long as u-boot-sh ends up being sane, oh well :)

Quoted 33 lines

Nobuhiro

2014-03-05 5:37 GMT+09:00 Tom Rini <[email protected]>:

Quoted 20 lines · Masahiro Yamada
Quoted 8 lines

Hello Nobihiro,

Thanks.

I want this and 6/8 on u-boot/master.

Can you please send pull-request now?

Yes, soon please :)

--
Tom

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 5 lines
Nobuhiro Iwamatsu
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140304/dd622f02/attachment.pgp>
#16 lore raw

PATCH 6/8 sh: merge compiler flag -ffixed-r13

In reply to Masahiro Yamada

-ffixed-r13 is defined commonly for sh2, sh3, sh4. Move it to arch/sh/config.mk

Cc Nobuhiro Iwamatsu <[email protected]>

---

 arch/sh/config.mk         | 1 +
 arch/sh/cpu/sh2/config.mk | 1 -
 arch/sh/cpu/sh3/config.mk | 1 -
 arch/sh/cpu/sh4/config.mk | 1 -
 4 files changed, 1 insertion(+), 3 deletions(-)
arch/sh/config.mk +1 -0
index 758c070..eefcbcd 100644
@@ -15,3 +15,4 @@ endif
 PLATFORM_CPPFLAGS += -DCONFIG_SH -D__SH__
 PLATFORM_LDFLAGS += -e $(CONFIG_SYS_TEXT_BASE) --defsym reloc_dst=$(CONFIG_SYS_TEXT_BASE)
 LDFLAGS_FINAL = --gc-sections
+PLATFORM_RELFLAGS += -ffixed-r13
arch/sh/cpu/sh2/config.mk +0 -1
index 25abcdd..4904d76 100644
@@ -14,5 +14,4 @@ PLATFORM_CPPFLAGS += -m3e -mb
 endif
 PLATFORM_CPPFLAGS += -DCONFIG_SH2 $(call cc-option,-mno-fdpic)
 
-PLATFORM_RELFLAGS += -ffixed-r13
 PLATFORM_LDFLAGS += $(ENDIANNESS)
arch/sh/cpu/sh3/config.mk +0 -1
index abd4b8d..24b5c47 100644
@@ -12,4 +12,3 @@
 #
 #
 PLATFORM_CPPFLAGS += -DCONFIG_SH3 -m3
-PLATFORM_RELFLAGS += -ffixed-r13
arch/sh/cpu/sh4/config.mk +0 -1
index 753580b..5773d4f 100644
@@ -9,4 +9,3 @@
 #
 #
 PLATFORM_CPPFLAGS += -DCONFIG_SH4 -m4-nofpu
-PLATFORM_RELFLAGS += -ffixed-r13
Signature · 1 line
1.8.3.2
#17 lore raw

PATCH 6/8 sh: merge compiler flag -ffixed-r13

Applied, thanks.

Best regards,
Nobuhiro

2014-02-26 14:51 GMT+09:00 Masahiro Yamada <[email protected]>:

Quoted 57 lines

-ffixed-r13 is defined commonly for sh2, sh3, sh4. Move it to arch/sh/config.mk

Cc Nobuhiro Iwamatsu <[email protected]>

---

 arch/sh/config.mk         | 1 +
 arch/sh/cpu/sh2/config.mk | 1 -
 arch/sh/cpu/sh3/config.mk | 1 -
 arch/sh/cpu/sh4/config.mk | 1 -
 4 files changed, 1 insertion(+), 3 deletions(-)
arch/sh/config.mk +1 -0
index 758c070..eefcbcd 100644
@@ -15,3 +15,4 @@ endif
 PLATFORM_CPPFLAGS += -DCONFIG_SH -D__SH__
 PLATFORM_LDFLAGS += -e $(CONFIG_SYS_TEXT_BASE) --defsym reloc_dst=$(CONFIG_SYS_TEXT_BASE)
 LDFLAGS_FINAL = --gc-sections
+PLATFORM_RELFLAGS += -ffixed-r13
arch/sh/cpu/sh2/config.mk +0 -1
index 25abcdd..4904d76 100644
@@ -14,5 +14,4 @@ PLATFORM_CPPFLAGS += -m3e -mb
 endif
 PLATFORM_CPPFLAGS += -DCONFIG_SH2 $(call cc-option,-mno-fdpic)
 
-PLATFORM_RELFLAGS += -ffixed-r13
 PLATFORM_LDFLAGS += $(ENDIANNESS)
arch/sh/cpu/sh3/config.mk +0 -1
index abd4b8d..24b5c47 100644
@@ -12,4 +12,3 @@
 #
 #
 PLATFORM_CPPFLAGS += -DCONFIG_SH3 -m3
-PLATFORM_RELFLAGS += -ffixed-r13
arch/sh/cpu/sh4/config.mk +0 -2
index 753580b..5773d4f 100644
@@ -9,4 +9,3 @@
 #
 #
 PLATFORM_CPPFLAGS += -DCONFIG_SH4 -m4-nofpu
-PLATFORM_RELFLAGS += -ffixed-r13
--

1.8.3.2

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Signature · 1 line
Nobuhiro Iwamatsu
#18 lore raw

PATCH 7/8 m68k: merge compile flags -ffixed-d7 -sep-data

In reply to Masahiro Yamada

All arch/m68k/cpu/*/config.mk define the same flags
PLAGFORM_REFLFLAGS += -ffixed-d7 -msep-data
Move it to arch/m68k/config.mk

---

 arch/m68k/config.mk                | 3 ++-
 arch/m68k/cpu/mcf5227x/config.mk   | 1 -
 arch/m68k/cpu/mcf523x/config.mk    | 1 -
 arch/m68k/cpu/mcf52x2/config.mk    | 2 --
 arch/m68k/cpu/mcf532x/config.mk    | 2 --
 arch/m68k/cpu/mcf5445x/config.mk   | 2 --
 arch/m68k/cpu/mcf547x_8x/config.mk | 1 -
 7 files changed, 2 insertions(+), 10 deletions(-)
arch/m68k/config.mk +2 -1
index 9c3e24f..79ae298 100644
@@ -11,5 +11,6 @@ CONFIG_STANDALONE_LOAD_ADDR ?= 0x20000
 
 PLATFORM_CPPFLAGS += -DCONFIG_M68K -D__M68K__
 PLATFORM_LDFLAGS  += -n
-PLATFORM_RELFLAGS              += -ffunction-sections -fdata-sections
+PLATFORM_RELFLAGS += -ffunction-sections -fdata-sections
+PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
 LDFLAGS_FINAL                  += --gc-sections
arch/m68k/cpu/mcf5227x/config.mk +0 -1
index 2681171..b5c26e4 100644
@@ -7,5 +7,4 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
 PLATFORM_CPPFLAGS += -mcpu=52277 -fPIC
arch/m68k/cpu/mcf523x/config.mk +0 -1
index 620769f..c9435ab 100644
@@ -7,5 +7,4 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
 PLATFORM_CPPFLAGS += -mcpu=5235 -fPIC
arch/m68k/cpu/mcf52x2/config.mk +0 -2
index d0be46f..25f98de 100644
@@ -7,8 +7,6 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
-
 cfg=$(shell grep configs $(OBJTREE)/include/config.h | sed 's/.*<\(configs.*\)>/\1/')
 is5208:=$(shell grep CONFIG_M5208 $(TOPDIR)/include/$(cfg))
 is5249:=$(shell grep CONFIG_M5249 $(TOPDIR)/include/$(cfg))
arch/m68k/cpu/mcf532x/config.mk +0 -2
index be12203..0604ab0 100644
@@ -7,8 +7,6 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
-
 cfg=$(shell grep configs $(OBJTREE)/include/config.h | sed 's/.*<\(configs.*\)>/\1/')
 is5301x:=$(shell grep CONFIG_MCF5301x $(TOPDIR)/include/$(cfg))
 is532x:=$(shell grep CONFIG_MCF532x $(TOPDIR)/include/$(cfg))
arch/m68k/cpu/mcf5445x/config.mk +0 -2
index d546b22..6da08d5 100644
@@ -9,8 +9,6 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
-
 cfg=$(shell grep configs $(OBJTREE)/include/config.h | sed 's/.*<\(configs.*\)>/\1/')
 is5441x:=$(shell grep CONFIG_MCF5441x $(TOPDIR)/include/$(cfg))
 
arch/m68k/cpu/mcf547x_8x/config.mk +0 -1
index 345f584..825f6cc 100644
@@ -7,7 +7,6 @@
 # SPDX-License-Identifier:	GPL-2.0+
 #
 
-PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
 PLATFORM_CPPFLAGS += -mcpu=5485 -fPIC
 
 ifneq (,$(findstring -linux-,$(shell $(CC) --version)))
Signature · 1 line
1.8.3.2
#19 lore raw

PATCH 7/8 m68k: merge compile flags -ffixed-d7 -sep-data

Quoted 6 lines · Masahiro Yamada

All arch/m68k/cpu/*/config.mk define the same flags
PLAGFORM_REFLFLAGS += -ffixed-d7 -msep-data
Move it to arch/m68k/config.mk

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140304/dfc8008d/attachment.pgp>
#20 lore raw

PATCH 8/8 arm64: Do not double -mstrict-align option

In reply to Masahiro Yamada

Seeing arch/arm/cpu/armv8/config.mk, -mstrict-align option was added to both PLATFORM_NO_UNALIGNED and PLATFORM_CPPFLAGS.

$(PLATFORM_CPPFLAGS) is given to all compiled objects. Adding the same option to also PLATFORM_NO_UNALIGNED is redundant.

For example, common/hush.o was compiled with double -mstrict-align. You can comfirm it by checking common/.hush.o.cmd file.

Cc David Feng <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Tom Rini <[email protected]>

---

 arch/arm/cpu/armv8/config.mk | 1 -
 1 file changed, 1 deletion(-)
arch/arm/cpu/armv8/config.mk +0 -1
index 027a68c..7e59b4d 100644
@@ -8,7 +8,6 @@ PLATFORM_RELFLAGS += -fno-common -ffixed-x18
 
 # SEE README.arm-unaligned-accesses
 PF_NO_UNALIGNED := $(call cc-option, -mstrict-align)
-PLATFORM_NO_UNALIGNED := $(PF_NO_UNALIGNED)
 
 PF_CPPFLAGS_ARMV8 := $(call cc-option, -march=armv8-a)
 PLATFORM_CPPFLAGS += $(PF_CPPFLAGS_ARMV8)
Signature · 1 line
1.8.3.2
#21 lore raw

PATCH 8/8 arm64: Do not double -mstrict-align option

Quoted 7 lines · Masahiro Yamada

Seeing arch/arm/cpu/armv8/config.mk, -mstrict-align option was added to both PLATFORM_NO_UNALIGNED and PLATFORM_CPPFLAGS.

$(PLATFORM_CPPFLAGS) is given to all compiled objects. Adding the same option to also PLATFORM_NO_UNALIGNED is redundant.

Quoted 7 lines

For example, common/hush.o was compiled with double -mstrict-align. You can comfirm it by checking common/.hush.o.cmd file.

Cc David Feng <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Tom Rini <[email protected]>

With the v3 series about unaligned bits this patch should no longer be needed.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140226/a60f1522/attachment.pgp>
#22 lore raw

PATCH 8/8 arm64: Do not double -mstrict-align option

Hi Tom,

Quoted 12 lines · Tom Rini
Quoted 10 lines · Masahiro Yamada

Seeing arch/arm/cpu/armv8/config.mk, -mstrict-align option was added to both PLATFORM_NO_UNALIGNED and PLATFORM_CPPFLAGS.

$(PLATFORM_CPPFLAGS) is given to all compiled objects. Adding the same option to also PLATFORM_NO_UNALIGNED is redundant.

For example, common/hush.o was compiled with double -mstrict-align. You can comfirm it by checking common/.hush.o.cmd file.

Quoted 7 lines
Quoted 4 lines
Cc David Feng <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Tom Rini <[email protected]>

With the v3 series about unaligned bits this patch should no longer be needed.

Hmm... This patch is about not repeating -mstrict-align twice, which is a bug unrelated with switching to -mno-unaligned-access.

Besides, -mstrict-align means "Don't assume that unaligned accesses are handled", which I think is for aarch64 what -mno-unaligned-access is for arm(32), so it *should* be specified.

Amicalement,

Signature · 1 line
Albert.
#23 lore raw

PATCH 8/8 arm64: Do not double -mstrict-align option

Quoted 24 lines · Albert ARIBAUD

Hi Tom,

Quoted 12 lines · Tom Rini
Quoted 10 lines · Masahiro Yamada

Seeing arch/arm/cpu/armv8/config.mk, -mstrict-align option was added to both PLATFORM_NO_UNALIGNED and PLATFORM_CPPFLAGS.

$(PLATFORM_CPPFLAGS) is given to all compiled objects. Adding the same option to also PLATFORM_NO_UNALIGNED is redundant.

For example, common/hush.o was compiled with double -mstrict-align. You can comfirm it by checking common/.hush.o.cmd file.

Quoted 7 lines
Quoted 4 lines
Cc David Feng <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Tom Rini <[email protected]>

With the v3 series about unaligned bits this patch should no longer be needed.

Quoted 6 lines

Hmm... This patch is about not repeating -mstrict-align twice, which is a bug unrelated with switching to -mno-unaligned-access.

Besides, -mstrict-align means "Don't assume that unaligned accesses are handled", which I think is for aarch64 what -mno-unaligned-access is for arm(32), so it *should* be specified.

Yes, but my patch cleaned up the places that set PLATFORM_NO_UNALIGNED so this duplication was dropped.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140226/325178ea/attachment.pgp>
#24 lore raw

PATCH 8/8 arm64: Do not double -mstrict-align option

Hi Tom,

Quoted 28 lines · Tom Rini
Quoted 27 lines · Albert ARIBAUD

Hi Tom,

Quoted 12 lines · Tom Rini
Quoted 10 lines · Masahiro Yamada

Seeing arch/arm/cpu/armv8/config.mk, -mstrict-align option was added to both PLATFORM_NO_UNALIGNED and PLATFORM_CPPFLAGS.

$(PLATFORM_CPPFLAGS) is given to all compiled objects. Adding the same option to also PLATFORM_NO_UNALIGNED is redundant.

For example, common/hush.o was compiled with double -mstrict-align. You can comfirm it by checking common/.hush.o.cmd file.

Quoted 7 lines
Quoted 4 lines
Cc David Feng <[email protected]>
Cc Albert ARIBAUD <[email protected]>
Cc Tom Rini <[email protected]>

With the v3 series about unaligned bits this patch should no longer be needed.

Hmm... This patch is about not repeating -mstrict-align twice, which is a bug unrelated with switching to -mno-unaligned-access.

Quoted 6 lines
Quoted 3 lines

Besides, -mstrict-align means "Don't assume that unaligned accesses are handled", which I think is for aarch64 what -mno-unaligned-access is for arm(32), so it *should* be specified.

Yes, but my patch cleaned up the places that set PLATFORM_NO_UNALIGNED so this duplication was dropped.

Oh, ok. My bad, then.

Amicalement,

Signature · 1 line
Albert.
#25 lore raw

cover Kbuild: A collection of trivial refactoring

In reply to Masahiro Yamada
Quoted 21 lines · Masahiro Yamada

Masahiro Yamada (8):
config.mk: Delete unused variable BCURDIR
Makefile: delete unused variable LDSCRIPT_MAKEFILE_DIR
nand_spl: simpc8313: move config.mk used only for nand_spl
x86: Delete redundant compiler flags
sh: Do not define -ffreestanding twice
sh: merge compiler flag -ffixed-r13
m68k: merge compile flags -ffixed-d7 -sep-data
arm64: Do not double -mstrict-align option

 Makefile                                              | 4 ----
 arch/arm/cpu/armv8/config.mk                          | 1 -
 arch/m68k/config.mk                                   | 3 ++-
 arch/m68k/cpu/mcf5227x/config.mk                      | 1 -
 arch/m68k/cpu/mcf523x/config.mk                       | 1 -
 arch/m68k/cpu/mcf52x2/config.mk                       | 2 --
 arch/m68k/cpu/mcf532x/config.mk                       | 2 --
 arch/m68k/cpu/mcf5445x/config.mk                      | 2 --
 arch/m68k/cpu/mcf547x_8x/config.mk                    | 1 -
 arch/sh/config.mk                                     | 1 +
 arch/sh/cpu/sh2/config.mk                             | 3 +--
Quoted 8 lines
 arch/sh/cpu/sh3/config.mk                             | 1 -
 arch/sh/cpu/sh4/config.mk                             | 1 -
 arch/x86/config.mk                                    | 5 +----
 config.mk                                             | 2 --
 nand_spl/board/sheldon/simpc8313/Makefile             | 2 ++
 {board => nand_spl/board}/sheldon/simpc8313/config.mk | 0
 17 files changed, 7 insertions(+), 25 deletions(-)
 rename {board => nand_spl/board}/sheldon/simpc8313/config.mk (100%)

Patches 1 through 7 look good and I'll pick them up soon, commented on 8.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140226/dc9480c9/attachment.pgp>