libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess
PATCH v2 1/1 libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess
Since the version 2.4.32, libdrm no longer requires dependencies on the libpciaccess unless for the intel-dri.
For more information :
http://cgit.freedesktop.org/mesa/drm/commit/?id=be30d350b64c1a83473a9ffbedf8e2c680a65fcd
---
Changes v1 -> v2:
- bump to version 2.4.52
--- package/libdrm/Config.in | 3 --- package/libdrm/libdrm.mk | 5 +---- 2 files changed, 1 insertion(+), 7 deletions(-)
package/libdrm/Config.in +0 -3
@@ -23,21 +23,18 @@ config BR2_PACKAGE_LIBDRM_INTEL config BR2_PACKAGE_LIBDRM_RADEON bool "radeon" select BR2_PACKAGE_LIBATOMIC_OPS - select BR2_PACKAGE_XLIB_LIBPCIACCESS depends on BR2_i386 || BR2_x86_64 help install AMD/ATI graphics driver config BR2_PACKAGE_LIBDRM_NOUVEAU bool "nouveau" - select BR2_PACKAGE_XLIB_LIBPCIACCESS depends on BR2_i386 || BR2_x86_64 help install Nvidia graphics driver config BR2_PACKAGE_LIBDRM_VMWGFX bool "vmwgfx" - select BR2_PACKAGE_XLIB_LIBPCIACCESS depends on BR2_i386 || BR2_x86_64 help installs Vmware graphics driver
package/libdrm/libdrm.mk +1 -4
@@ -4,7 +4,7 @@ # ################################################################################ -LIBDRM_VERSION = 2.4.46 +LIBDRM_VERSION = 2.4.52 LIBDRM_SOURCE = libdrm-$(LIBDRM_VERSION).tar.bz2 LIBDRM_SITE = http://dri.freedesktop.org/libdrm/ LIBDRM_LICENSE = MIT
@@ -28,21 +28,18 @@ endif ifeq ($(BR2_PACKAGE_LIBDRM_RADEON),y) LIBDRM_CONF_OPT += --enable-radeon -LIBDRM_DEPENDENCIES += xlib_libpciaccess else LIBDRM_CONF_OPT += --disable-radeon endif ifeq ($(BR2_PACKAGE_LIBDRM_NOUVEAU),y) LIBDRM_CONF_OPT += --enable-nouveau -LIBDRM_DEPENDENCIES += xlib_libpciaccess else LIBDRM_CONF_OPT += --disable-nouveau endif ifeq ($(BR2_PACKAGE_LIBDRM_VMWGFX),y) LIBDRM_CONF_OPT += --enable-vmwgfx -LIBDRM_DEPENDENCIES += xlib_libpciaccess else LIBDRM_CONF_OPT += --disable-vmwgfx endif
Signature · 1 line
1.9.0
PATCH v2 1/1 libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess
Dear Sebastien Bourdelin,
Quoted 11 lines · Sebastien Bourdelin
Since the version 2.4.32, libdrm no longer requires dependencies on the libpciaccess unless for the intel-dri.
For more information :
http://cgit.freedesktop.org/mesa/drm/commit/?id=be30d350b64c1a83473a9ffbedf8e2c680a65fcdSigned-off-by Sebastien Bourdelin <[email protected]>---
Changes v1 -> v2:
- bump to version 2.4.52
Thanks a lot for your contribution!
However, the patch has two problems:
*) You added a significant change (bumping the version number), but you kept the Reviewed-by tag of another person. This is typically considered as a bad practice: Arnout had endorsed your previous version, and maybe not this one.
*) When your commit log title contains something like "do this *AND* do that", it's a strong indication that your patch is not correct, and should instead be split in two patches: one "doing this" and the other "doing that". In this case, the patch "doing that" could carry Arnout's Reviewed-by, since it wouldn't have changed since Arnout's review.
Would you mind resending an updated version that takes into account those comments?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess
Hi Thomas, Bernd
Quoted 16 lines · Thomas Petazzoni
Thanks a lot for your contribution!
However, the patch has two problems:
*) You added a significant change (bumping the version number), but you kept the Reviewed-by tag of another person. This is typically considered as a bad practice: Arnout had endorsed your previous version, and maybe not this one.
*) When your commit log title contains something like "do this *AND* do that", it's a strong indication that your patch is not correct, and should instead be split in two patches: one "doing this" and the other "doing that". In this case, the patch "doing that" could carry Arnout's Reviewed-by, since it wouldn't have changed since Arnout's review.
Quoted 4 lines
Would you mind resending an updated version that takes into account those comments?
Thomas
Thanks for your advice Thomas, i'll keep it in mind.
Quoted 9 lines · Bernd Kuhls
Hi,
please have a look at this patch series addressing the same topic:
http://patchwork.ozlabs.org/patch/317523/
http://patchwork.ozlabs.org/patch/317522/
http://patchwork.ozlabs.org/patch/317524/Regards, Bernd
Bernd i saw some of your patches but not this one sorry. My patch is redundant with Bernd's patches, so you can burn mine :)
Regards.
PATCH v2 1/1 libdrm: bump to 2.4.52 and remove useless dependencies on libpciaccess
In reply to Sebastien BourdelinSebastien Bourdelin
<[email protected]>
wrote in news:1393539908-14365-1-git-send-email-sebastien.bourdelin at savoirfairelinux .com:
Quoted 2 lines
Since the version 2.4.32, libdrm no longer requires dependencies on the libpciaccess unless for the intel-dri.
Hi,
please have a look at this patch series addressing the same topic:
http://patchwork.ozlabs.org/patch/317523/
http://patchwork.ozlabs.org/patch/317522/
http://patchwork.ozlabs.org/patch/317524/
Regards, Bernd