Skip to contentSkip to conversation

gpio: only enable kona driver on BCM_MOBILE or for compile testing

PATCH New Uwe Kleine-König 4 participants 8 messages Feb 21, 2014 – Sep 25, 2014 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: only enable kona driver on BCM_MOBILE or for compile testing

This change makes it easier to configure a kernel for a real machine by not showing the option to enable it at all if COMPILE_TEST is off.

---
Hello,

I'm not sure if and how "Kona" fits into the bcm281xx namespace, but reading through the commit logs of the changes touching drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd consider it a good idea to mention "bcm281xx" in the help text of GPIO_BCM_KONA.

Best regards
Uwe

 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +1 -1
index 903f24d28ba0..7cc68d26320c 100644
@@ -817,7 +817,7 @@ config GPIO_MSIC
 
 config GPIO_BCM_KONA
 	bool "Broadcom Kona GPIO"
-	depends on OF_GPIO
+	depends on OF_GPIO && (ARCH_BCM_MOBILE || COMPILE_TEST)
 	help
 	  Turn on GPIO support for Broadcom "Kona" chips.
 
Signature · 1 line
1.8.5.3
#1 lore raw

PATCH 1/1 gpio: only enable kona driver on BCM_MOBILE or for compile testing

Quoted 4 lines · Uwe Kleine-K?nig

This change makes it easier to configure a kernel for a real machine by not showing the option to enable it at all if COMPILE_TEST is off.

Markus: can you ACK this patch?

Yours,
Linus Walleij

#3 lore raw

PATCH 1/1 gpio: only enable kona driver on BCM_MOBILE or for compile testing

Quoted 4 lines · Markus Mayer
Quoted 3 lines · Linus Walleij

On Fri, Feb 21, 2014 at 2:42 PM, Uwe Kleine-K?nig
<[email protected]> wrote:

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

This change makes it easier to configure a kernel for a real machine by not showing the option to enable it at all if COMPILE_TEST is off.

Markus: can you ACK this patch?

ping!

Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#4 lore raw

PATCH 1/1 gpio: only enable kona driver on BCM_MOBILE or for compile testing

Quoted 8 lines · Uwe Kleine-K?nig
Quoted 7 lines · Markus Mayer
Quoted 6 lines · Linus Walleij
Quoted 3 lines · Uwe Kleine-K?nig

This change makes it easier to configure a kernel for a real machine by not showing the option to enable it at all if COMPILE_TEST is off.

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Markus: can you ACK this patch?

ping!

Patch applied with Markus' ACK!

Yours,
Linus Walleij

#5 lore raw

PATCH 1/1 gpio: only enable kona driver on BCM_MOBILE or for compile testing

In reply to Uwe Kleine-König
Quoted 7 lines · Uwe Kleine-K?nig

Hello,

I'm not sure if and how "Kona" fits into the bcm281xx namespace, but reading through the commit logs of the changes touching drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd consider it a good idea to mention "bcm281xx" in the help text of GPIO_BCM_KONA.

Naming these components has been quite a challenge for our upstreaming effort. Some things are not very obvious unless you know he chip or were involved in those discussions.

"Kona" can be thought of as an architecture or a family of chips. bcm281xx is one member of that family. There are others. I submitted bcm21664 to arm-linux just a few minutes ago. bcm21664 also uses gpio-bcm-kona.c.

Mentioning the SoCs in the help text is a good idea, but we'll likely have to come up with a central location where all supported members of the Kona family are listed, so they aren't scattered all over different sub-systems (Kona watchdog, Kona GPIO, Kona timer, etc.) If we don't have a central location, we'll be certain to forget updating one of the help texts eventually, and it would become inconsistent.

Regards,
-Markus

Signature · 2 lines
Markus Mayer
Broadcom Landing Team
#6 lore raw

PATCH 1/1 gpio: only enable kona driver on BCM_MOBILE or for compile testing

Hello Markus,

Quoted 17 lines · Markus Mayer
Quoted 5 lines · Uwe Kleine-K?nig

I'm not sure if and how "Kona" fits into the bcm281xx namespace, but reading through the commit logs of the changes touching drivers/gpio/gpio-bcm-kona.c so far suggests it does. In this case I'd consider it a good idea to mention "bcm281xx" in the help text of GPIO_BCM_KONA.

Naming these components has been quite a challenge for our upstreaming effort. Some things are not very obvious unless you know he chip or were involved in those discussions.

"Kona" can be thought of as an architecture or a family of chips. bcm281xx is one member of that family. There are others. I submitted bcm21664 to arm-linux just a few minutes ago. bcm21664 also uses gpio-bcm-kona.c.

Quoted 6 lines

Mentioning the SoCs in the help text is a good idea, but we'll likely have to come up with a central location where all supported members of the Kona family are listed, so they aren't scattered all over different sub-systems (Kona watchdog, Kona GPIO, Kona timer, etc.) If we don't have a central location, we'll be certain to forget updating one of the help texts eventually, and it would become inconsistent.

Fine for me, but note that this was only a side node and is orthogonal to the patch I sent. So if you want to ack it ...

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#7 lore raw

PATCH 1/1 gpio: only enable kona driver on BCM_MOBILE or for compile testing

Hello,

Quoted 2 lines · Uwe Kleine-K?nig

Fine for me, but note that this was only a side node and is orthogonal to the patch I sent. So if you want to ack it ...

Oh, you sent an ack already, I didn't say anything.

Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |