av7110_hw: fix a sanity check in av7110_fw_cmd()

PATCH New Dan Carpenter 1 participant 1 message Mar 1, 2014

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2014-03-01 13:51 UTC #0 lore raw

PATCH 1/1 av7110_hw: fix a sanity check in av7110_fw_cmd()

ARRAY_SIZE(buf) (8 elements) was intended instead of sizeof(buf) (16 bytes). But this is just a sanity check and the callers always pass valid values so this doesn't cause a problem.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/pci/ttpci/av7110_hw.c +1 -1

index 6299d5dadb82..300bd3c94738 100644
@@ -501,7 +501,7 @@ int av7110_fw_cmd(struct av7110 *av7110, int type, int com, int num, ...)
 
 //	dprintk(4, "%p\n", av7110);
 
-	if (2 + num > sizeof(buf)) {
+	if (2 + num > ARRAY_SIZE(buf)) {
 		printk(KERN_WARNING
 		       "%s: %s len=%d is too big!\n",
 		       KBUILD_MODNAME, __func__, num);