Bug in fs/kernfs/dir.c comment or code?
I stumbled across this in fs/kernfs/dir.c:39.
/* Reserve hash numbers 0, 1 and INT_MAX for magic directory entries */ if (hash < 1) hash += 2; if (hash >= INT_MAX) hash = INT_MAX - 1;
Shouldn't that be (hash < 2), or is 1 not reserved?
Thanks,
Richard
(cc'ing Greg and Eric)
Quoted 9 lines · Richard Cochran
I stumbled across this in
fs/kernfs/dir.c:39./* Reserve hash numbers 0, 1 and INT_MAX for magic directory entries */ if (hash < 1) hash += 2; if (hash >= INT_MAX) hash = INT_MAX - 1;Shouldn't that be (hash < 2), or is 1 not reserved?
Looks like the code is wrong and the condition should be hash < 2. Difficult to trigger but an actual bug. The fix should probably be propagated to sysfs through -stable. Can you write up a patch?
Thanks.
Signature · 1 line
tejun