Skip to contentSkip to conversation

Add new package: biosdevname

PATCH New Ryan Wilkins 2 participants 3 messages Feb 3, 2014 – Oct 12, 2014

lore
Share & tools
lore

Ryan Wilkins

author
#0 lore raw

PATCH v2 1/1 Add new package: biosdevname

Signed-off-by Ryan Wilkins <[email protected]>

---
v2: incorporated comments from Arnout

---
 package/Config.in                  |    1 +
 package/biosdevname/Config.in      |   13 +++++++++++++
 package/biosdevname/biosdevname.mk |   15 +++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/biosdevname/Config.in
 create mode 100644 package/biosdevname/biosdevname.mk
package/Config.in +1 -0
index 93d23cb..d2aeab8 100644
@@ -265,6 +265,7 @@ endmenu
 source "package/a10disp/Config.in"
 source "package/acpid/Config.in"
 source "package/avrdude/Config.in"
+source "package/biosdevname/Config.in"
 source "package/cdrkit/Config.in"
 source "package/cryptsetup/Config.in"
 source "package/cwiid/Config.in"
package/biosdevname/Config.in new file +13 -0
new file mode 100644
index 0000000..17a9aa4
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_BIOSDEVNAME
+	bool "biosdevname"
+	depends on (BR2_i386 || BR2_x86_64) && BR2_PACKAGE_UDEV
+	select BR2_PACKAGE_PCIUTILS
+	help
+	  Biosdevname is a udev helper that looks at various BIOS tables to
+	  figure out what the actual hardware names are for Ethernet ports
+	  and renames the ports accordingly.  This has the advantage of
+	  always referring to the same port regardless of system or
+	  hardware changes that might otherwise alter the typical ethX
+	  naming.
+
+	  http://linux.dell.com/biosdevname/
package/biosdevname/biosdevname.mk new file +15 -0
new file mode 100644
index 0000000..be1c6af
@@ -0,0 +1,15 @@
+################################################################################
+#
+# biosdevname
+#
+################################################################################
+
+BIOSDEVNAME_VERSION = 0.4.1
+BIOSDEVNAME_SITE = http://linux.dell.com/biosdevname/biosdevname-$(BIOSDEVNAME_VERSION)
+BIOSDEVNAME_LICENSE = GPL
+BIOSDEVNAME_LICENSE_FILES = COPYING
+BIOSDEVNAME_INSTALL_TARGET = YES
+BIOSDEVNAME_CONF_OPT = --exec-prefix=/
+BIOSDEVNAME_DEPENDENCIES = pciutils
+
+$(eval $(autotools-package))
Signature · 5 lines
1.7.9.5

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140203/62744f58/attachment.html>
#1 lore raw

PATCH v2 1/1 Add new package: biosdevname

Ryan, All,

Thank you for your submission. Here are a few other comments.

On 2014-02-03 16:37 -0500, Ryan Wilkins spake thusly:
[--SNIP--]

package/biosdevname/Config.in line 3

Quoted 9 lines
package/biosdevname/Config.in new file +3 -0
new file mode 100644
index 0000000..17a9aa4
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_BIOSDEVNAME
+	bool "biosdevname"
+	depends on (BR2_i386 || BR2_x86_64) && BR2_PACKAGE_UDEV

Two things:
- we usually separate the dependencies on architectures from the dependencies on packages
- udev is now provided by a virtual package

So, you should do:

    depends on BR2_i386 || BR2_x86_64
    dependson BR2_PACKAGE_HAS_UDEV
Quoted 16 lines
package/biosdevname/Config.in new file +10 -0
+	select BR2_PACKAGE_PCIUTILS
+	help
+	  Biosdevname is a udev helper that looks at various BIOS tables to
+	  figure out what the actual hardware names are for Ethernet ports
+	  and renames the ports accordingly.  This has the advantage of
+	  always referring to the same port regardless of system or
+	  hardware changes that might otherwise alter the typical ethX
+	  naming.
+
+	  http://linux.dell.com/biosdevname/
package/biosdevname/biosdevname.mk new file +0 -0
new file mode 100644
index 0000000..be1c6af

package/biosdevname/biosdevname.mk line 8

Quoted 8 lines
package/biosdevname/biosdevname.mk new file +8 -0
@@ -0,0 +1,15 @@
+################################################################################
+#
+# biosdevname
+#
+################################################################################
+
+BIOSDEVNAME_VERSION = 0.4.1
+BIOSDEVNAME_SITE = http://linux.dell.com/biosdevname/biosdevname-$(BIOSDEVNAME_VERSION)

The git repository has version v0.5.0, out 2013-01-18.
THere are also a few fixes in the repository, that were made a few hours ago, so it might be a better bet to use a git snapshot:

BIOSDEVNAME_VERSION = c140ce659a204d67e4cc61d2191443123f7dd970 BIOSDEVNAME_SITE = git://linux.dell.com/biosdevname.git

package/biosdevname/biosdevname.mk line 11

Quoted 3 lines
package/biosdevname/biosdevname.mk new file +3 -0
+BIOSDEVNAME_LICENSE = GPL
+BIOSDEVNAME_LICENSE_FILES = COPYING
+BIOSDEVNAME_INSTALL_TARGET = YES

Not needed, that's the default.

package/biosdevname/biosdevname.mk line 13

Quoted 2 lines
package/biosdevname/biosdevname.mk new file +2 -0
+BIOSDEVNAME_CONF_OPT = --exec-prefix=/
+BIOSDEVNAME_DEPENDENCIES = pciutils

Missing dependency on udev:

BIOSDEVNAME_DEPENDENCIES = pciutils udev

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 Add new package: biosdevname

In reply to Ryan Wilkins

Ryan, All,

On 2014-02-03 16:37 -0500, Ryan Wilkins spake thusly:

Quoted 3 lines
Signed-off-by Ryan Wilkins <[email protected]>

---
v2: incorporated comments from Arnout

I've sent an updated version of that patch:

    http://patchwork.ozlabs.org/patch/398911/

Regards,
Yann E. MORIN.

Quoted 68 lines
---
 package/Config.in                  |    1 +
 package/biosdevname/Config.in      |   13 +++++++++++++
 package/biosdevname/biosdevname.mk |   15 +++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/biosdevname/Config.in
 create mode 100644 package/biosdevname/biosdevname.mk
package/Config.in +1 -0
index 93d23cb..d2aeab8 100644
@@ -265,6 +265,7 @@ endmenu
 source "package/a10disp/Config.in"
 source "package/acpid/Config.in"
 source "package/avrdude/Config.in"
+source "package/biosdevname/Config.in"
 source "package/cdrkit/Config.in"
 source "package/cryptsetup/Config.in"
 source "package/cwiid/Config.in"
package/biosdevname/Config.in new file +13 -0
new file mode 100644
index 0000000..17a9aa4
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_BIOSDEVNAME
+	bool "biosdevname"
+	depends on (BR2_i386 || BR2_x86_64) && BR2_PACKAGE_UDEV
+	select BR2_PACKAGE_PCIUTILS
+	help
+	  Biosdevname is a udev helper that looks at various BIOS tables to
+	  figure out what the actual hardware names are for Ethernet ports
+	  and renames the ports accordingly.  This has the advantage of
+	  always referring to the same port regardless of system or
+	  hardware changes that might otherwise alter the typical ethX
+	  naming.
+
+	  http://linux.dell.com/biosdevname/
package/biosdevname/biosdevname.mk new file +15 -0
new file mode 100644
index 0000000..be1c6af
@@ -0,0 +1,15 @@
+################################################################################
+#
+# biosdevname
+#
+################################################################################
+
+BIOSDEVNAME_VERSION = 0.4.1
+BIOSDEVNAME_SITE = http://linux.dell.com/biosdevname/biosdevname-$(BIOSDEVNAME_VERSION)
+BIOSDEVNAME_LICENSE = GPL
+BIOSDEVNAME_LICENSE_FILES = COPYING
+BIOSDEVNAME_INSTALL_TARGET = YES
+BIOSDEVNAME_CONF_OPT = --exec-prefix=/
+BIOSDEVNAME_DEPENDENCIES = pciutils
+
+$(eval $(autotools-package))
Signature · 7 lines
1.7.9.5


_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'