libubox: new package

PATCH New yegorslists at googlemail.com 2 participants 5 messages Jan 30, 2014 – Mar 4, 2014

lore

Share & tools

lore

yegorslists at googlemail.com

author

2014-01-30 11:11 UTC #0 lore raw

PATCH 1/1 libubox: new package

From: Yegor Yefremov <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>

---
 package/Config.in          |    1 +
 package/libubox/Config.in  |    6 ++++++
 package/libubox/libubox.mk |   13 +++++++++++++
 3 files changed, 20 insertions(+), 0 deletions(-)
 create mode 100644 package/libubox/Config.in
 create mode 100644 package/libubox/libubox.mk

package/Config.in +1 -0

index 631d8b2..1d57e12 100644
@@ -747,6 +747,7 @@ source "package/libsigc/Config.in"
 source "package/libsigsegv/Config.in"
 source "package/libtasn1/Config.in"
 source "package/libtpl/Config.in"
+source "package/libubox/Config.in"
 source "package/libunwind/Config.in"
 source "package/liburcu/Config.in"
 source "package/linux-pam/Config.in"

package/libubox/Config.in new file +6 -0

new file mode 100644
index 0000000..c6efb33
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBUBOX
+	bool "libubox"
+	help
+	  Small utility library for OpenWrt.
+
+	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary

package/libubox/libubox.mk new file +13 -0

new file mode 100644
index 0000000..ec8fbdb
@@ -0,0 +1,13 @@
+################################################################################
+#
+# libubox
+#
+################################################################################
+
+LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
+LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
+LIBUBOX_LICENSE = LGPLv2.1
+LIBUBOX_INSTALL_STAGING = YES
+LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
+
+$(eval $(cmake-package))

Signature · 1 line

1.7.7

Yann E. MORIN

2014-03-03 23:24 UTC #1 lore raw

PATCH 1/1 libubox: new package

Yegor, All,

Thanks for your contribution! Some comments below...

On 2014-01-30 12:11 +0100, yegorslists at googlemail.com spake thusly:
[--SNIP--]

package/libubox/Config.in line 4

Quoted 10 lines

package/libubox/Config.in new file +4 -0

new file mode 100644
index 0000000..c6efb33
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBUBOX
+	bool "libubox"
+	help
+	  Small utility library for OpenWrt.

In what way would this be of interest to Buildroot?

Since this is "for OpenWRT", I fail to see the relevance to Buildroot.

Quoted 7 lines

package/libubox/Config.in new file +1 -0
+	  http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary
package/libubox/libubox.mk new file +0 -0
new file mode 100644
index 0000000..ec8fbdb

package/libubox/libubox.mk line 9

Quoted 9 lines

package/libubox/libubox.mk new file +9 -0

@@ -0,0 +1,13 @@
+################################################################################
+#
+# libubox
+#
+################################################################################
+
+LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b
+LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
+LIBUBOX_LICENSE = LGPLv2.1

This is not correct:
- most of the files have a license header that do not reference the LGPLv2.1, but which I did not recognise [0]
- some have a BSD-3c license: avl.c
- at least one file is GPLv2: md5.c

[0]
* Copyright (C) 2012 Felix Fietkau <[email protected]>
*
* Permission to use, copy, modify, and/or distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies. *
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

package/libubox/libubox.mk line 11

Quoted 2 lines

package/libubox/libubox.mk new file +2 -0
+LIBUBOX_INSTALL_STAGING = YES
+LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF

Maybe that could be made conditional on whether lua is enabled or not?

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yegor Yefremov

author

2014-03-04 06:59 UTC #2 lore raw

PATCH 1/1 libubox: new package

Quoted 19 lines · Yann E. MORIN

Yegor, All,
Thanks for your contribution! Some comments below...
On 2014-01-30 12:11 +0100, yegorslists at googlemail.com spake thusly:
[--SNIP--]
package/libubox/Config.in line 4
Quoted 10 lines
package/libubox/Config.in new file +4 -0
new file mode 100644
index 0000000..c6efb33
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBUBOX
+     bool "libubox"
+     help
+       Small utility library for OpenWrt.
In what way would this be of interest to Buildroot?

Quoted 1 line

Since this is "for OpenWRT", I fail to see the relevance to Buildroot.

My goal is to port libuci to Buildroot as I have some software, that I've written for OpenWRT and now would like to use in BR too. The software uses /etc/config/* infrastructure to access its configuration files via libuci.
libubox it a dependency of libuci.

I've also found libuci installation tutorials for Ubuntu :-)
http://www.wakoond.hu/2013/06/using-uci-on-ubuntu.html

Quoted 14 lines

package/libubox/Config.in new file +1 -0

+       http://nbd.name/gitweb.cgi?p=luci2/libubox.git;a=summary

package/libubox/libubox.mk new file +7 -0

new file mode 100644
index 0000000..ec8fbdb
@@ -0,0 +1,13 @@
+################################################################################
+#
+# libubox
+#
+################################################################################
+
+LIBUBOX_VERSION = bbd846ec2d72b2629758b69dc122ac0b0f2c3e4b

Quoted 8 lines

package/libubox/libubox.mk line 9
Quoted 2 lines
package/libubox/libubox.mk new file +2 -0
+LIBUBOX_SITE = git://nbd.name/luci2/libubox.git
+LIBUBOX_LICENSE = LGPLv2.1
This is not correct:
- most of the files have a license header that do not reference the LGPLv2.1, but which I did not recognise [0]
- some have a BSD-3c license: avl.c
- at least one file is GPLv2: md5.c

Hm. That's really odd. Should I omit license information for now?

Quoted 15 lines

[0]
* Copyright (C) 2012 Felix Fietkau <[email protected]>
*
* Permission to use, copy, modify, and/or distribute this software for any
* purpose with or without fee is hereby granted, provided that the above
* copyright notice and this permission notice appear in all copies. *
* THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
* WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
* ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
* WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
* ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

Quoted 4 lines

package/libubox/libubox.mk line 11
Quoted 2 lines
package/libubox/libubox.mk new file +2 -0
+LIBUBOX_INSTALL_STAGING = YES
+LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
Maybe that could be made conditional on whether lua is enabled or not?

I wanted to start with a simple configuration, as I don't need Lua right now, but I'll incorporate this feature in the v2.

Yegor

Yann E. MORIN

2014-03-04 18:32 UTC #3 lore raw

PATCH 1/1 libubox: new package

On 2014-03-04 07:59 +0100, Yegor Yefremov spake thusly:

Quoted 20 lines · Yann E. MORIN

Quoted 19 lines
Yegor, All,
Thanks for your contribution! Some comments below...
On 2014-01-30 12:11 +0100, yegorslists at googlemail.com spake thusly:
[--SNIP--]
package/libubox/Config.in line 4
Quoted 10 lines
package/libubox/Config.in new file +4 -0
new file mode 100644
index 0000000..c6efb33
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBUBOX
+     bool "libubox"
+     help
+       Small utility library for OpenWrt.
In what way would this be of interest to Buildroot?

Quoted 7 lines

Quoted 1 line
Since this is "for OpenWRT", I fail to see the relevance to Buildroot.
My goal is to port libuci to Buildroot as I have some software, that I've written for OpenWRT and now would like to use in BR too. The software uses /etc/config/* infrastructure to access its configuration files via libuci.
libubox it a dependency of libuci.

Ah, I see. Then, please say so in the help text (the one you provided is not really interesting, as it does not say what libubox does).

Quoted 3 lines

Quoted 3 lines
This is not correct:
- most of the files have a license header that do not reference the LGPLv2.1, but which I did not recognise [0]

It might be MIT:
http://spdx.org/licenses/MIT

Quoted 4 lines

Quoted 2 lines
- some have a BSD-3c license: avl.c
- at least one file is GPLv2: md5.c
Hm. That's really odd. Should I omit license information for now?

No, just state all of them:
_LICENSES = GPLv2, BSD-3c, MIT

Quoted 7 lines

Quoted 4 lines
package/libubox/Config.in line 6
Quoted 2 lines
package/libubox/Config.in new file +2 -0
+LIBUBOX_INSTALL_STAGING = YES
+LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
Maybe that could be made conditional on whether lua is enabled or not?
I wanted to start with a simple configuration, as I don't need Lua right now, but I'll incorporate this feature in the v2.

OK, that's fine. If you don't use it, and so don't test it, there's no reason to add it. If someone (or you, later) is interested in it, he'll send a patch.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yegor Yefremov

author

2014-03-04 19:24 UTC #4 lore raw

PATCH 1/1 libubox: new package

Quoted 23 lines · Yann E. MORIN

On 2014-03-04 07:59 +0100, Yegor Yefremov spake thusly:
Quoted 22 lines · Yann E. MORIN
Quoted 20 lines
Yegor, All,
Thanks for your contribution! Some comments below...
On 2014-01-30 12:11 +0100, yegorslists at googlemail.com spake thusly:
[--SNIP--]
package/libubox/Config.in line 4
Quoted 10 lines
package/libubox/Config.in new file +4 -0
new file mode 100644
index 0000000..c6efb33
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBUBOX
+     bool "libubox"
+     help
+       Small utility library for OpenWrt.
In what way would this be of interest to Buildroot?
Since this is "for OpenWRT", I fail to see the relevance to Buildroot.

Quoted 8 lines

Quoted 5 lines
My goal is to port libuci to Buildroot as I have some software, that I've written for OpenWRT and now would like to use in BR too. The software uses /etc/config/* infrastructure to access its configuration files via libuci.
libubox it a dependency of libuci.
Ah, I see. Then, please say so in the help text (the one you provided is not really interesting, as it does not say what libubox does).

You're right. I'll post both patches for libubox and libuci. And who knows, perhaps we would be able to run LuCI especially LuCI2 on BR.

Quoted 37 lines

Quoted 3 lines
Quoted 3 lines
This is not correct:
- most of the files have a license header that do not reference the LGPLv2.1, but which I did not recognise [0]
It might be MIT:
http://spdx.org/licenses/MIT
Quoted 4 lines
Quoted 2 lines
- some have a BSD-3c license: avl.c
- at least one file is GPLv2: md5.c
Hm. That's really odd. Should I omit license information for now?
No, just state all of them:
_LICENSES = GPLv2, BSD-3c, MIT
Quoted 7 lines
Quoted 4 lines
package/libubox/Config.in line 6
Quoted 2 lines
package/libubox/Config.in new file +2 -0
+LIBUBOX_INSTALL_STAGING = YES
+LIBUBOX_CONF_OPT = -DBUILD_LUA:BOOL=OFF
Maybe that could be made conditional on whether lua is enabled or not?
I wanted to start with a simple configuration, as I don't need Lua right now, but I'll incorporate this feature in the v2.
OK, that's fine. If you don't use it, and so don't test it, there's no reason to add it. If someone (or you, later) is interested in it, he'll send a patch.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'