Skip to contentSkip to conversation

dts: add support for MMC on socfpga boards

PATCH In review Pavel Machek 3 participants 3 messages Mar 5, 2014 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dts: add support for MMC on socfpga boards

Add DTS binding for MMC on socfpga boards. Tested on Sockit.

arch/arm/boot/dts/socfpga.dtsi +17 -0
index 537f1a5..cad7526 100644
@@ -521,6 +521,23 @@
 			reg-io-width = <4>;
 		};
 
+		mmc: dwmmc0 at ff704000 {
+			compatible = "snps,dw-mshc";
+			reg = <0xff704000 0x1000>;
+			interrupts = <0 139 4>;
+			clock-frequency = <12500000>; /*12.5 MHz*/
+			#address-cells = <1>;
+			#size-cells = <0>;
+			num-slots = <1>;
+			supports-highspeed;
+			broken-cd;
+			fifo-depth = <0x400>;
+			slot at 0 {
+				reg = <0>;
+				bus-width = <4>;
+			};
+		};
+
 		rstmgr at ffd05000 {
 			compatible = "altr,rst-mgr";
 			reg = <0xffd05000 0x1000>;
#1 lore raw
Quoted 23 lines · ZY - pavel

Add DTS binding for MMC on socfpga boards. Tested on Sockit.

arch/arm/boot/dts/socfpga.dtsi +10 -0
index 537f1a5..cad7526 100644
@@ -521,6 +521,23 @@
 			reg-io-width = <4>;
 		};
 
+		mmc: dwmmc0 at ff704000 {
+			compatible = "snps,dw-mshc";
+			reg = <0xff704000 0x1000>;
+			interrupts = <0 139 4>;
+			clock-frequency = <12500000>; /*12.5 MHz*/
+			#address-cells = <1>;
+			#size-cells = <0>;
+			num-slots = <1>;
+			supports-highspeed;
+			broken-cd;

arch/arm/boot/dts/socfpga.dtsi line 543

Quoted 10 lines
arch/arm/boot/dts/socfpga.dtsi +7 -0
+			fifo-depth = <0x400>;
+			slot at 0 {
+				reg = <0>;
+				bus-width = <4>;
+			};
+		};
+
 		rstmgr at ffd05000 {
 			compatible = "altr,rst-mgr";
 			reg = <0xffd05000 0x1000>;

This is already queued in Chris Ball's MMC tree.

Thanks,
Dinh

#2 lore raw
In reply to Pavel Machek

Hello.

arch/arm/boot/dts/socfpga.dtsi line 524

Quoted 13 lines · Pavel Machek

Add DTS binding for MMC on socfpga boards. Tested on Sockit.

arch/arm/boot/dts/socfpga.dtsi +1 -0
index 537f1a5..cad7526 100644
@@ -521,6 +521,23 @@
  			reg-io-width = <4>;
  		};
 
+		mmc: dwmmc0@ff704000 {

ePAPR standard [1] tells us in section 2.2.2:

The name of a node should be somewhat generic, reflecting the function of the device and not its 3 precise programming model.

So, please name the node just "mmc@ff704000". You can choose whatever
label you like.

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei