Skip to contentSkip to conversation

video: atmel_lcdfb: ensure the hardware is initialized with the correct mode

PATCH New Antoine Ténart 4 participants 4 messages Mar 7, 2014 – Mar 12, 2014

Subsystems (2)
Framebuffer layer Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Antoine Ténart

author
#0 lore raw

PATCH 1/1 video: atmel_lcdfb: ensure the hardware is initialized with the correct mode

If no driver takeover the atmel_lcdfb, the lcd won't be in a working state since atmel_lcdfb_set_par() will never be called. Enabling a driver which does, like fbcon, will call the function and put atmel_lcdfb in a working state.

Fixes b985172b328a (video: atmel_lcdfb: add device tree suport)
Signed-off-by Antoine T?nart <[email protected]>
Reported-by Alexandre Belloni <[email protected]>
---
 drivers/video/atmel_lcdfb.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/video/atmel_lcdfb.c +6 -0
index cd96162..b74e5f5d 100644
@@ -1298,6 +1298,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
 		goto unregister_irqs;
 	}
 
+	ret = atmel_lcdfb_set_par(info);
+	if (ret < 0) {
+		dev_err(dev, "set par failed: %d\n", ret);
+		goto unregister_irqs;
+	}
+
 	dev_set_drvdata(dev, info);
 
 	/*
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 video: atmel_lcdfb: ensure the hardware is initialized with the correct mode

Quoted 8 lines · Antoine T?nart

If no driver takeover the atmel_lcdfb, the lcd won't be in a working state since atmel_lcdfb_set_par() will never be called. Enabling a driver which does, like fbcon, will call the function and put atmel_lcdfb in a working state.

Fixes b985172b328a (video: atmel_lcdfb: add device tree suport)
Signed-off-by Antoine T?nart <[email protected]>
Reported-by Alexandre Belloni <[email protected]>
Acked-by Alexandre Belloni <[email protected]>
Quoted 24 lines
---
 drivers/video/atmel_lcdfb.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/video/atmel_lcdfb.c +6 -0
index cd96162..b74e5f5d 100644
@@ -1298,6 +1298,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
 		goto unregister_irqs;
 	}
 
+	ret = atmel_lcdfb_set_par(info);
+	if (ret < 0) {
+		dev_err(dev, "set par failed: %d\n", ret);
+		goto unregister_irqs;
+	}
+
 	dev_set_drvdata(dev, info);
 
 	/*
Signature · 1 line
1.8.3.2
Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 video: atmel_lcdfb: ensure the hardware is initialized with the correct mode

In reply to Antoine Ténart

On 07/03/2014 17:20, Antoine T?nart :

Quoted 8 lines

If no driver takeover the atmel_lcdfb, the lcd won't be in a working state since atmel_lcdfb_set_par() will never be called. Enabling a driver which does, like fbcon, will call the function and put atmel_lcdfb in a working state.

Fixes b985172b328a (video: atmel_lcdfb: add device tree suport)
Signed-off-by Antoine T?nart <[email protected]>
Reported-by Alexandre Belloni <[email protected]>
Acked-by Nicolas Ferre <[email protected]>

Thanks for having fixing this.

Bye,

Quoted 22 lines
---
 drivers/video/atmel_lcdfb.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/video/atmel_lcdfb.c +6 -0
index cd96162..b74e5f5d 100644
@@ -1298,6 +1298,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
 		goto unregister_irqs;
 	}
 
+	ret = atmel_lcdfb_set_par(info);
+	if (ret < 0) {
+		dev_err(dev, "set par failed: %d\n", ret);
+		goto unregister_irqs;
+	}
+
 	dev_set_drvdata(dev, info);
 
 	/*
Signature · 1 line
Nicolas Ferre
#3 lore raw

PATCH 1/1 video: atmel_lcdfb: ensure the hardware is initialized with the correct mode

In reply to Antoine Ténart
Quoted 20 lines · Antoine T?nart

If no driver takeover the atmel_lcdfb, the lcd won't be in a working state since atmel_lcdfb_set_par() will never be called. Enabling a driver which does, like fbcon, will call the function and put atmel_lcdfb in a working state.

Fixes b985172b328a (video: atmel_lcdfb: add device tree suport)
Signed-off-by Antoine T?nart <[email protected]>
Reported-by Alexandre Belloni <[email protected]>
---
 drivers/video/atmel_lcdfb.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/video/atmel_lcdfb.c +0 -0
index cd96162..b74e5f5d 100644
@@ -1298,6 +1298,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
 		goto unregister_irqs;
 	}

drivers/video/atmel_lcdfb.c static int __init atmel_lcdfb_probe(struct platform_device *pdev) · line 1309

Quoted 10 lines
drivers/video/atmel_lcdfb.c +6 -0
 
+	ret = atmel_lcdfb_set_par(info);
+	if (ret < 0) {
+		dev_err(dev, "set par failed: %d\n", ret);
+		goto unregister_irqs;
+	}
+
 	dev_set_drvdata(dev, info);
 
 	/*

Thanks, queued for 3.15.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140312/07cbba94/attachment-0001.sig>