Skip to contentSkip to conversation

package: Add PRE_BUILD_HOOKS

PATCH New Maxime Hadjinlian 2 participants 3 messages Feb 3, 2014 – Mar 7, 2014

lore
Share & tools
lore

Maxime Hadjinlian

author
#0 lore raw

PATCH 1/2 package: Add PRE_BUILD_HOOKS

This hooks, even though it is preceded by the POST_CONFIGURE_HOOKS, this hooks is semantically different and allow for a nice separation.

While adding libenca, this step was not present and I needed to build a tool which generates a header files for the build.
And I had to add it to the POST_CONFIGURE_HOOKS which make little sense since it has nothing to do with the configure step.

Signed-off-by Maxime Hadjinlian <[email protected]>
---
 docs/manual/adding-packages-hooks.txt | 1 +
 package/pkg-generic.mk                | 1 +
 2 files changed, 2 insertions(+)
docs/manual/adding-packages-hooks.txt +1 -0
index d96c991..ec709ab 100644
@@ -21,6 +21,7 @@ The following hook points are available:
 * +LIBFOO_POST_PATCH_HOOKS+
 * +LIBFOO_PRE_CONFIGURE_HOOKS+
 * +LIBFOO_POST_CONFIGURE_HOOKS+
+* +LIBFOO_PRE_BUILD_HOOKS+
 * +LIBFOO_POST_BUILD_HOOKS+
 * +LIBFOO_POST_INSTALL_HOOKS+ (for host packages only)
 * +LIBFOO_POST_INSTALL_STAGING_HOOKS+ (for target packages only)
package/pkg-generic.mk +1 -0
index 1b99c2a..b6ed122 100644
@@ -172,6 +172,7 @@ $(BUILD_DIR)/%/.stamp_configured:
 # Build
 $(BUILD_DIR)/%/.stamp_built::
 	@$(call step_start,build)
+	$(foreach hook,$($(PKG)_PRE_BUILD_HOOKS),$(call $(hook))$(sep))
 	@$(call MESSAGE,"Building")
 	$($(PKG)_BUILD_CMDS)
 	$(foreach hook,$($(PKG)_POST_BUILD_HOOKS),$(call $(hook))$(sep))
Signature · 1 line
1.8.5.3
author
#1 lore raw

PATCH 2/2 libenca: Move build host tool to PRE_BUILD_HOOKS

The make_hash host tool, should be built during a PRE_BUILD_HOOKS and not a POST_CONFIGURE_HOOKS.

Signed-off-by Maxime Hadjinlian <[email protected]>
---
 package/libenca/libenca.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libenca/libenca.mk +1 -1
index d998c66..66fcfaa 100644
@@ -21,6 +21,6 @@ define LIBENCA_MAKE_HOST_TOOL
 	$(MAKE) -C $(@D)/tools $(HOST_CONFIGURE_OPTS) make_hash
 endef
 
-LIBENCA_POST_CONFIGURE_HOOKS += LIBENCA_MAKE_HOST_TOOL
+LIBENCA_PRE_BUILD_HOOKS += LIBENCA_MAKE_HOST_TOOL
 
 $(eval $(autotools-package))
Signature · 1 line
1.8.5.3
Applied
#2 lore raw

PATCH 2/2 libenca: Move build host tool to PRE_BUILD_HOOKS

Dear Maxime Hadjinlian,

Quoted 7 lines · Maxime Hadjinlian

The make_hash host tool, should be built during a PRE_BUILD_HOOKS and not a POST_CONFIGURE_HOOKS.

Signed-off-by Maxime Hadjinlian <[email protected]>
---
 package/libenca/libenca.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com