Skip to contentSkip to conversation

Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

PATCH In review Conrad Meyer 2 participants 2 messages Mar 8, 2014 Staging

lore
Share & tools
lore

Conrad Meyer

author
#0 lore raw

PATCH 1/1 Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

Fix minor checkpatch.pl style issues (80-char line limits) in addi_apci_1500.c.

Signed-off-by Conrad Meyer <[email protected]>
---
 drivers/staging/comedi/drivers/addi_apci_1500.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/addi_apci_1500.c +4 -2
index 74f7ace..f23ca3d 100644
@@ -26,11 +26,13 @@ static const struct addi_board apci1500_boardtypes[] = {
                .di_read                = i_APCI1500_Initialisation,
                .di_write               = i_APCI1500_StartStopInputEvent,
                .di_bits                = apci1500_di_insn_bits,
-               .do_config              = i_APCI1500_ConfigDigitalOutputErrorInterrupt,
+               .do_config              =
+                       i_APCI1500_ConfigDigitalOutputErrorInterrupt,
                .do_write               = i_APCI1500_WriteDigitalOutput,
                .do_bits                = i_APCI1500_ConfigureInterrupt,
                .timer_config           = i_APCI1500_ConfigCounterTimerWatchdog,
-               .timer_write            = i_APCI1500_StartStopTriggerTimerCounterWatchdog,
+               .timer_write            =
+                       i_APCI1500_StartStopTriggerTimerCounterWatchdog,
                .timer_read             = i_APCI1500_ReadInterruptMask,
                .timer_bits             = i_APCI1500_ReadCounterTimerWatchdog,
        },

--
1.8.5.3

#1 lore raw
Quoted 13 lines · Conrad Meyer

Fix minor checkpatch.pl style issues (80-char line limits) in addi_apci_1500.c.

Signed-off-by Conrad Meyer <[email protected]>
---
 drivers/staging/comedi/drivers/addi_apci_1500.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/addi_apci_1500.c +0 -0
index 74f7ace..f23ca3d 100644

drivers/staging/comedi/drivers/addi_apci_1500.c static const struct addi_board apci1500_boardtypes[] = { · line 30

Quoted 6 lines
drivers/staging/comedi/drivers/addi_apci_1500.c +2 -1
@@ -26,11 +26,13 @@ static const struct addi_board apci1500_boardtypes[] = {
                .di_read                = i_APCI1500_Initialisation,
                .di_write               = i_APCI1500_StartStopInputEvent,
                .di_bits                = apci1500_di_insn_bits,
-               .do_config              = i_APCI1500_ConfigDigitalOutputErrorInterrupt,
+               .do_config              =
+                       i_APCI1500_ConfigDigitalOutputErrorInterrupt,

No, as horrible as too long of a line it might be, this is worse. How about renaming the function to be more "sane" which would cause it to be shorter here, fixing the line limit.

Something like config_output() would be better, right?

drivers/staging/comedi/drivers/addi_apci_1500.c static const struct addi_board apci1500_boardtypes[] = { · line 35

Quoted 6 lines
drivers/staging/comedi/drivers/addi_apci_1500.c +2 -1
                .do_write               = i_APCI1500_WriteDigitalOutput,
                .do_bits                = i_APCI1500_ConfigureInterrupt,
                .timer_config           = i_APCI1500_ConfigCounterTimerWatchdog,
-               .timer_write            = i_APCI1500_StartStopTriggerTimerCounterWatchdog,
+               .timer_write            =
+                       i_APCI1500_StartStopTriggerTimerCounterWatchdog,

Same here, "timer_watchdog()"?

thanks,

greg k-h