mesa3d: pull out from x11

PATCH Superseded Bernd Kuhls 5 participants 10 messages Mar 9, 2014 – Mar 12, 2014

lore

Share & tools

lore

Bernd Kuhls

author

2014-03-09 19:01 UTC #0 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

Signed-off-by Bernd Kuhls <[email protected]>

Signed-off-by Spenser Gilliland <[email protected]>

---
v4: rebased v3
v3: Config.in: move package to "Graphic libraries" (Arnout)
v2: rebased v1
v1: rebased Spenser Gilliland?s patch:

    http://patchwork.ozlabs.org/patch/278302/

 package/Config.in                                     |    1 +
 package/{x11r7 => }/mesa3d/Config.in                  |    0
 package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch |    0
 package/{x11r7 => }/mesa3d/mesa3d.mk                  |    0
 package/x11r7/Config.in                               |    1 -
 5 files changed, 1 insertion(+), 1 deletion(-)
 rename package/{x11r7 => }/mesa3d/Config.in (100%)
 rename package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch (100%)
 rename package/{x11r7 => }/mesa3d/mesa3d.mk (100%)

package/Config.in +1 -0

index 70e5a7f..b0da653 100644
@@ -188,6 +188,7 @@ source "package/fbv/Config.in"
 source "package/imagemagick/Config.in"
 source "package/linux-fusion/Config.in"
 source "package/lite/Config.in"
+source "package/mesa3d/Config.in"
 source "package/ocrad/Config.in"
 source "package/psplash/Config.in"
 source "package/sawman/Config.in"

package/mesa3d/Config.in renamed from package/x11r7/mesa3d/Config.in +0 -0

similarity index 100%
rename from package/x11r7/mesa3d/Config.in
rename to package/mesa3d/Config.in

package/mesa3d/mesa3d-uclibc-locale.patch renamed from package/x11r7/mesa3d/mesa3d-uclibc-locale.patch +0 -0

similarity index 100%
rename from package/x11r7/mesa3d/mesa3d-uclibc-locale.patch
rename to package/mesa3d/mesa3d-uclibc-locale.patch

package/mesa3d/mesa3d.mk renamed from package/x11r7/mesa3d/mesa3d.mk +0 -0

similarity index 100%
rename from package/x11r7/mesa3d/mesa3d.mk
rename to package/mesa3d/mesa3d.mk

package/x11r7/Config.in +0 -1

index 5ef118b..458d09f 100644
@@ -15,7 +15,6 @@ if BR2_PACKAGE_XORG7
 	endmenu
 	menu "X11R7 Libraries"
 		source package/x11r7/libxcb/Config.in
-		source package/x11r7/mesa3d/Config.in
 		source package/x11r7/xcb-util/Config.in
 		source package/x11r7/xcb-util-image/Config.in
 		source package/x11r7/xcb-util-keysyms/Config.in

Signature · 1 line

1.7.10.4

Sebastien Bourdelin

2014-03-10 16:21 UTC #1 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

Quoted 9 lines · Bernd Kuhls

Signed-off-by Bernd Kuhls <[email protected]>
Signed-off-by Spenser Gilliland <[email protected]>
---
v4: rebased v3
v3: Config.in: move package to "Graphic libraries" (Arnout)
v2: rebased v1
v1: rebased Spenser Gilliland?s patch:
    http://patchwork.ozlabs.org/patch/278302/

Quoted 9 lines

 package/Config.in                                     |    1 +
 package/{x11r7 => }/mesa3d/Config.in                  |    0
 package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch |    0
 package/{x11r7 => }/mesa3d/mesa3d.mk                  |    0
 package/x11r7/Config.in                               |    1 -
 5 files changed, 1 insertion(+), 1 deletion(-)
 rename package/{x11r7 => }/mesa3d/Config.in (100%)
 rename package/{x11r7 => }/mesa3d/mesa3d-uclibc-locale.patch (100%)
 rename package/{x11r7 => }/mesa3d/mesa3d.mk (100%)

Reviewed-by Sebastien Bourdelin <[email protected]>

Regards,
Sebastien.

Yann E. MORIN

2014-03-10 17:39 UTC #2 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

In reply to Bernd Kuhls

Bernd, All,

On 2014-03-09 20:01 +0100, Bernd Kuhls spake thusly:

Maybe it would be nice to give in the commit log a bit more details on why it makes sense to move it out of x11r7.

Quoted 2 lines

Signed-off-by Bernd Kuhls <[email protected]>
Signed-off-by Spenser Gilliland <[email protected]>

[--SNIP--]

package/Config.in source "package/fbv/Config.in" · line 191

Quoted 9 lines

package/Config.in +1 -0

index 70e5a7f..b0da653 100644
@@ -188,6 +188,7 @@ source "package/fbv/Config.in"
 source "package/imagemagick/Config.in"
 source "package/linux-fusion/Config.in"
 source "package/lite/Config.in"
+source "package/mesa3d/Config.in"

If I understand correctly, mesa3d is an implementation of OpenGL. So, *maybe* it would make sense to move it along the other OpenGL packages, into package/opengl/.

But I'd like others to confirm this first.

Otherwise, looks good.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Bernd Kuhls

author

2014-03-10 17:52 UTC #3 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

Hi,

"Yann E. MORIN" <[email protected]> wrote in news:20140310173941.GA3282 at free.fr:

Quoted 2 lines

Maybe it would be nice to give in the commit log a bit more details on why it makes sense to move it out of x11r7.

mesa3d does not depend on x11, it can be used by wayland as well.

Quoted 3 lines

If I understand correctly, mesa3d is an implementation of OpenGL. So, *maybe* it would make sense to move it along the other OpenGL packages, into package/opengl/.

In package/opengl/ are only virtual packages.

Regards, Bernd

Yann E. MORIN

2014-03-10 18:05 UTC #4 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

Bernd, All,

On 2014-03-10 18:52 +0100, Bernd Kuhls spake thusly:

Quoted 9 lines

Hi,
"Yann E. MORIN" <[email protected]> wrote in news:20140310173941.GA3282 at free.fr:
Quoted 2 lines
Maybe it would be nice to give in the commit log a bit more details on why it makes sense to move it out of x11r7.
mesa3d does not depend on x11, it can be used by wayland as well.

Just add this in the commit log. ;-)

Quoted 5 lines

Quoted 3 lines
If I understand correctly, mesa3d is an implementation of OpenGL. So, *maybe* it would make sense to move it along the other OpenGL packages, into package/opengl/.
In package/opengl/ are only virtual packages.

Right. Mesa3D is more on the provider-side, indeed. So no need to put it in package/opengl. OK. ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Eric Le Bihan

2014-03-10 18:20 UTC #5 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

In reply to Yann E. MORIN

Yann E., All

Quoted 5 lines · Yann E. MORIN

Quoted 5 lines

package/Config.in +0 -0

index 70e5a7f..b0da653 100644
@@ -188,6 +188,7 @@ source "package/fbv/Config.in"

Quoted 8 lines

package/Config.in source "package/fbv/Config.in" · line 191
Quoted 4 lines
package/Config.in +1 -0
 source "package/imagemagick/Config.in"
 source "package/linux-fusion/Config.in"
 source "package/lite/Config.in"
+source "package/mesa3d/Config.in"
If I understand correctly, mesa3d is an implementation of OpenGL. So, *maybe* it would make sense to move it along the other OpenGL packages, into package/opengl/.

Some quick thoughts:

1. As Mesa3D is an implementation of OpenGL, it will be a provider for the virtual packages libegl, libgles and libopenvg.

2. Mesa3D also provides libgl, but:

- no package in Buildroot requires full OpenGL.
- Buildroot is unlikely to include packages for AMD/NVidia/Intel drivers (providers for libgl).

So there is no need for a libgl virtual package.

3. IMHO package/opengl should only contain the definitions of the virtual packages, not the providers (otherwise sunxi-mali should be moved to package/opengl too!).

Best regards,
ELB

Yann E. MORIN

2014-03-10 18:41 UTC #6 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

Eric, All,

On 2014-03-10 19:20 +0100, Eric Le Bihan spake thusly:

Quoted 16 lines

Yann E., All
Quoted 5 lines · Yann E. MORIN
Quoted 5 lines
package/Config.in +0 -0
index 70e5a7f..b0da653 100644
@@ -188,6 +188,7 @@ source "package/fbv/Config.in"
Quoted 8 lines
package/Config.in source "package/fbv/Config.in" · line 191
Quoted 4 lines
package/Config.in +1 -0
 source "package/imagemagick/Config.in"
 source "package/linux-fusion/Config.in"
 source "package/lite/Config.in"
+source "package/mesa3d/Config.in"
If I understand correctly, mesa3d is an implementation of OpenGL. So, *maybe* it would make sense to move it along the other OpenGL packages, into package/opengl/.

Quoted 4 lines

Some quick thoughts:
1. As Mesa3D is an implementation of OpenGL, it will be a provider for the virtual packages libegl, libgles and libopenvg.

I've looked on my distro, and mesa3d does not provide any file named libegl*.so or ligles*.so or libopenvg*.so. So I don't think it should be, *as is*, a provider for libegl, libgles or libopenvg.

Quoted 1 line

2. Mesa3D also provides libgl, but:

libgl or libglx ?

On my distro (Ubuntu 13.10), there's no libgl.so, only libglx.so which is provided by a bumch of different packages, of which the nvidia blobs.

All I have that looks to be from mesa3d if libglapi.so.

Quoted 3 lines

- no package in Buildroot requires full OpenGL.
- Buildroot is unlikely to include packages for AMD/NVidia/Intel drivers (providers for libgl).

Unlikely, but what about a powerfull, game-console-class device using a NVidia (or Intel, AMD) GPU?

Quoted 1 line

So there is no need for a libgl virtual package.

Indeed, so no need to provide a virtul package for that as long as we do not have a real user. It will always be time to add it later. And it's not like it would be rocket-science to do it! :-)

Quoted 3 lines

3. IMHO package/opengl should only contain the definitions of the virtual packages, not the providers (otherwise sunxi-mali should be moved to package/opengl too!).

Yes, I already replied to Bernd in this direction: mesa3d treads on the provider side. So like other GL providers, it does not really belong to package/opengl.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Arnout Vandecappelle

2014-03-12 06:24 UTC #7 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

Quoted 5 lines · Yann E. MORIN

Quoted 2 lines
Quoted 2 lines
1. As Mesa3D is an implementation of OpenGL, it will be a provider for the virtual packages libegl, libgles and libopenvg.
I've looked on my distro, and mesa3d does not provide any file named libegl*.so or ligles*.so or libopenvg*.so. So I don't think it should be, *as is*, a provider for libegl, libgles or libopenvg.

Have you looked at libegl1-mesa, libgles2-mesa, libopenvg1-mesa?

Quoted 6 lines

Quoted 2 lines
Quoted 2 lines
2. Mesa3D also provides libgl, but:
libgl or libglx ?
On my distro (Ubuntu 13.10), there's no libgl.so, only libglx.so which is provided by a bumch of different packages, of which the nvidia blobs.

That one is in libgl1-mesa-glx.

All that stuff is only installed if you need it - which you usually
don't because glx is enough for desktop use.

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Yann E. MORIN

2014-03-12 17:31 UTC #8 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

On 2014-03-12 07:24 +0100, Arnout Vandecappelle spake thusly:

Quoted 8 lines · Yann E. MORIN

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
1. As Mesa3D is an implementation of OpenGL, it will be a provider for the virtual packages libegl, libgles and libopenvg.
I've looked on my distro, and mesa3d does not provide any file named libegl*.so or ligles*.so or libopenvg*.so. So I don't think it should be, *as is*, a provider for libegl, libgles or libopenvg.
Have you looked at libegl1-mesa, libgles2-mesa, libopenvg1-mesa?

Indeed, I was looking for libegl, not libEGL. And apt-file is not smart enough to do a case-insensitive search by default, so now:

    $ apt-file search -i libegl |grep -E '\.so'
    [...]
    libegl1-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libEGL.so.1.0.0
    [...]

    $ apt-file search -i libgles |grep -E '\.so'
    [...]
    libgles1-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libGLESv1_CM.so.1.1.0
    [...]
    libgles2-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libGLESv2.so.2.0.0
    [...]

    $ apt-file search -i libopenvg |grep -E '\.so'
    [...]
    libopenvg1-mesa: /usr/lib/x86_64-linux-gnu/mesa-egl/libOpenVG.so.1.0.0
    [...]

OK, good. So mesa3d can be added as a provider for libegl, libgles and libopenvg, indeed. It can be done in a separate patch, later.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Bernd Kuhls

author

2014-03-10 18:58 UTC #9 lore raw

PATCH v4 1/5 mesa3d: pull out from x11

In reply to Eric Le Bihan

Eric Le Bihan <[email protected]> wrote in news:20140310182030.GB18832 at pc-eric:

Quoted 3 lines

2. Mesa3D also provides libgl, but:
- no package in Buildroot requires full OpenGL.

Hi,

xbmc depends on libGL.so ;)

Regards, Bernd