Skip to contentSkip to conversation

xfs_db: hide debug bbmap output

PATCH In review Eric Sandeen 2 participants 2 messages Mar 11, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs_db: hide debug bbmap output

Most of xfsprogs building with DEBUG enables extra checks, asserts, etc, but this bunch of printfs was extra output that's not generally helpful for most people's runtime experience - and it breaks xfs/290 with all the noise.

I assume it's for actual debugging use, and not generally useful, so bury it a bit deeper under it's own #ifdef.

---

db/io.c +1 -1
index 9a787c8..89e6030 100644
@@ -500,7 +500,7 @@ set_cur(
 	push_cur();
 
 	if (bbmap) {
-#ifdef DEBUG
+#ifdef DEBUG_BBMAP
 		int i;
 		printf(_("xfs_db got a bbmap for %lld\n"), (long long)d);
 		printf(_("\tblock map"));

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 11 lines · Eric Sandeen

Most of xfsprogs building with DEBUG enables extra checks, asserts, etc, but this bunch of printfs was extra output that's not generally helpful for most people's runtime experience - and it breaks xfs/290 with all the noise.

I assume it's for actual debugging use, and not generally useful, so bury it a bit deeper under it's own #ifdef.

Just remove it, I think. It doesn't serve any real purpose anymore, and changing it to an obscure ifdef guarantees it'll never get used again...

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs