Skip to contentSkip to conversation

irqchip: sun4i: Fix acomment about mask register initialization

PATCH New Hans de Goede 2 participants 2 messages Mar 11, 2014 – Mar 12, 2014

Subsystems (2)
Arm/Allwinner sunXi SoC support irqchip drivers
lore
Share & tools
lore

Hans de Goede

author
#0 lore raw

PATCH 1/1 irqchip: sun4i: Fix acomment about mask register initialization

The comment was claiming that we were masking all irqs, while the code actually *un*masks all of them.

Signed-off-by Hans de Goede <[email protected]>
---
 drivers/irqchip/irq-sun4i.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-sun4i.c +1 -1
index 3761bf1..749a355 100644
@@ -109,7 +109,7 @@ static int __init sun4i_of_init(struct device_node *node,
 	writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(1));
 	writel(0, sun4i_irq_base + SUN4I_IRQ_ENABLE_REG(2));
 
-	/* Mask all the interrupts */
+	/* Unmask all the interrupts, ENABLE_REG(x) is used for masking */
 	writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(0));
 	writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(1));
 	writel(0, sun4i_irq_base + SUN4I_IRQ_MASK_REG(2));
Signature · 1 line
1.9.0
#1 lore raw

PATCH 1/1 irqchip: sun4i: Fix acomment about mask register initialization

Quoted 4 lines · Hans de Goede

The comment was claiming that we were masking all irqs, while the code actually *un*masks all of them.

Signed-off-by Hans de Goede <[email protected]>
Acked-by Maxime Ripard <[email protected]>
Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140312/d2a72d11/attachment-0001.sig>