Skip to contentSkip to conversation

boost: Pass CFLAGS, CXXFLAGS and LDFLAGS correctly into boost.build

PATCH RESEND New Mike Crowe 1 participant 1 message Mar 13, 2014

lore
Share & tools
lore

Mike Crowe

author
#0 lore raw

PATCH RESEND 1/1 boost: Pass CFLAGS, CXXFLAGS and LDFLAGS correctly into boost.build

The compileflags and linkflags do_boostconfig puts into user-config.jam are having no effect. According to
http://www.boost.org/boost-build2/doc/html/bbv2/reference/tools.html the correct syntax would be <compileflags>"the flags" <linkflags>"the flags".

Since the flags specified were having no effect they can't be necessary and can be safely removed. We should be passing ${CFLAGS}, ${CXXFLAGS} and ${LDFLAGS} instead so that users of the recipe can pass arbitrary flags as they choose.

---
 meta/recipes-support/boost/boost.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/boost/boost.inc +1 -1
index c7642be..356ca22 100644
@@ -134,7 +134,7 @@ do_boostconfig() {
 	# D2194:Fixing the failure of "error: duplicate initialization of gcc with the following parameters" during compilation.
 	if ! grep -qe "^using gcc : 4.3.1" ${S}/tools/build/v2/user-config.jam 
 	then
-		echo 'using gcc : 4.3.1 : ${CXX} : compileflags -DBOOST_SP_USE_PTHREADS -I${includedir} linkflags -L${libdir} ;' >> ${S}/tools/build/v2/user-config.jam
+		echo 'using gcc : 4.3.1 : ${CXX} : <cflags>"${CFLAGS}" <cxxflags>"${CXXFLAGS}" <linkflags>"${LDFLAGS}" ;' >> ${S}/tools/build/v2/user-config.jam
 	fi	
 
 	echo "using python : ${PYTHON_BASEVERSION} : : ${STAGING_INCDIR}/python${PYTHON_BASEVERSION} ;" >> ${S}/tools/build/v2/user-config.jam
Signature · 1 line
1.7.10.4