Skip to contentSkip to conversation

watchdog: Fix SC1200 dependencies

PATCH In review Jean Delvare 2 participants 3 messages Mar 14, 2014 Watchdog device drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 watchdog: Fix SC1200 dependencies

The SC1200 is a SoC based on the Geode GX1 32-bit x86 processor, so its drivers are only needed on this architecture.

Cc Zwane Mwaikambo <[email protected]>
Cc Wim Van Sebroeck <[email protected]>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -1
@@ -736,7 +736,7 @@ config HPWDT_NMI_DECODING
 
 config SC1200_WDT
 	tristate "National Semiconductor PC87307/PC97307 (ala SC1200) Watchdog"
-	depends on X86
+	depends on X86_32
 	help
 	  This is a driver for National Semiconductor PC87307/PC97307 hardware
 	  watchdog cards as found on the SC1200. This watchdog is mainly used
Signature · 2 lines
Jean Delvare
SUSE L3 Support
maintainer
#1 lore raw
Quoted 3 lines · Jean Delvare

The SC1200 is a SoC based on the Geode GX1 32-bit x86 processor, so its drivers are only needed on this architecture.

The driver is named SC1200, but isn't really SC1200 specific but supports the PC87307/PC97307. Not really sure if it is good idea to remove support for it from 64 bit images. Can we say for sure that there are no 64 bit systems using this chip ?

Thanks,
Guenter

#2 lore raw

Hi Guenter,

Thanks a lot for this review and all the other ones.

Quoted 8 lines · Guenter Roeck
Quoted 2 lines · Jean Delvare

The SC1200 is a SoC based on the Geode GX1 32-bit x86 processor, so its drivers are only needed on this architecture.

The driver is named SC1200, but isn't really SC1200 specific but supports the PC87307/PC97307. Not really sure if it is good idea to remove support for it from 64 bit images. Can we say for sure that there are no 64 bit systems using this chip ?

Grmpf. The driver name is definitely confusing but I'm afraid you're right. Even more confusing is the existence of an SCx200_WDT driver, which is supposed to drive the same watchdog but as a PCI device? And that one does depend on SCx200 which in turn depends on X86_32. I don't quite get the point of having two drivers for the same device, but I'm probably missing something.

Anyway, let's just forget about this patch then. Sorry for the noise.

Signature · 2 lines
Jean Delvare
SUSE L3 Support