Skip to contentSkip to conversation

Xen: include asm/page.h in xen-ops.h

PATCH In review Arnd Bergmann 2 participants 3 messages Mar 15, 2014 – Mar 17, 2014 Xen hypervisor interface

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Xen: include asm/page.h in xen-ops.h

The declaration of xen_remap_domain_mfn_range relies on the pgprot_t typedef to be visible. In some configurations, that may not already have been seen, and I have encountered a bug during randconfig testing on ARM.

Adding an explicit #include for asm/page.h fixes the problem.

include/xen/xen-ops.h +1 -0
index 6d8c042..b8ad234 100644
@@ -3,6 +3,7 @@
 
 #include <linux/percpu.h>
 #include <asm/xen/interface.h>
+#include <asm/page.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
 
#1 lore raw
Quoted 8 lines · Arnd Bergmann

The declaration of xen_remap_domain_mfn_range relies on the pgprot_t typedef to be visible. In some configurations, that may not already have been seen, and I have encountered a bug during randconfig testing on ARM.

Adding an explicit #include for asm/page.h fixes the problem.

I'll add to xentip

Quoted 18 lines
include/xen/xen-ops.h +1 -1
index 6d8c042..b8ad234 100644
@@ -3,6 +3,7 @@
 
 #include <linux/percpu.h>
 #include <asm/xen/interface.h>
+#include <asm/page.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

The declaration of xen_remap_domain_mfn_range relies on the pgprot_t typedef to be visible. In some configurations, that may not already have been seen, and I have encountered a bug during randconfig testing on ARM.

Adding an explicit #include for asm/page.h fixes the problem.

I'll add to xentip

Quoted 18 lines
include/xen/xen-ops.h +1 -1
index 6d8c042..b8ad234 100644
@@ -3,6 +3,7 @@
 
 #include <linux/percpu.h>
 #include <asm/xen/interface.h>
+#include <asm/page.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/