ia64: keep format strings from leaking into printk
PATCH 1/1 ia64: keep format strings from leaking into printk
The buffer being sent to printk has already had format strings resolved. The string should not be reinterpreted again to avoid any unintended format strings from leaking into printk.
Signed-off-by Kees Cook <[email protected]>
--- arch/ia64/kernel/mca.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/ia64/kernel/mca.c +2 -2
@@ -217,7 +217,7 @@ void ia64_mca_printk(const char *fmt, ...)/* Copy the output into mlogbuf */ if (oops_in_progress) {/* mlogbuf was abandoned, use printk directly instead. */ -printk (temp_buf); +printk ("%s" , temp_buf); }else {spin_lock (&mlogbuf_wlock);for (p = temp_buf; *p; p++) {
@@ -268,7 +268,7 @@ void ia64_mlogbuf_dump(void) } *p ='\0' ;if (temp_buf[0 ]) -printk (temp_buf); +printk ("%s" , temp_buf); mlogbuf_start = index; mlogbuf_timestamp =0 ;
Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security