Skip to contentSkip to conversation

Staging: gdm724x: gdm_lte.h: fixed coding style

PATCH In review Daniel Ngu 2 participants 2 messages Mar 16, 2014 Staging

lore
Share & tools
lore

Daniel Ngu

author
#0 lore raw

PATCH 1/1 Staging: gdm724x: gdm_lte.h: fixed coding style

Missing space after return type

---
 drivers/staging/gdm724x/gdm_lte.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gdm724x/gdm_lte.h +1 -1
index 9287d31..88414e5 100644
@@ -56,7 +56,7 @@ struct phy_dev {
 			int (*cb)(void *cb_data, void *data, int len,
 				  int context),
 			void *cb_data, int context);
-	struct gdm_endian *(*get_endian)(void *priv_dev);
+	struct gdm_endian * (*get_endian)(void *priv_dev);
 };
 
 struct nic {
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 1 line · Daniel Ngu

Missing space after return type

Not really.

drivers/staging/gdm724x/gdm_lte.h

Quoted 1 line
drivers/staging/gdm724x/gdm_lte.h +0 -0

[]

drivers/staging/gdm724x/gdm_lte.h struct phy_dev { · line 59

Quoted 6 lines
drivers/staging/gdm724x/gdm_lte.h +1 -1
@@ -56,7 +56,7 @@ struct phy_dev {
 			int (*cb)(void *cb_data, void *data, int len,
 				  int context),
 			void *cb_data, int context);
-	struct gdm_endian *(*get_endian)(void *priv_dev);
+	struct gdm_endian * (*get_endian)(void *priv_dev);

That one was a defect in checkpatch that was
corrected in -next by:

commit 93ca9441419b0bfbf96243e01f39b5a80565215e

Author: Joe Perches <[email protected]>
Date:   Thu Mar 6 11:02:08 2014 +1100

checkpatch: don't warn on some function pointer return styles

Checks for some function pointer return styles are too strict. Fix them.

Multiple spaces after function pointer return types are allowed.
int (*foo)(int bar)

Spaces after function pointer returns of pointer types are not required.
int *(*foo)(int bar)