Skip to contentSkip to conversation

xen: declare notifier_block on xen-ops.h

PATCH In review Stanislaw Gruszka 2 participants 6 messages Mar 17, 2014 – Mar 18, 2014 1 message not in the archive Xen hypervisor interface

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 5323aab1.r24xwrkmR/N+a3KK%[email protected]

Stanislaw Gruszka

author
#1 lore raw

PATCH 1/1 xen: declare notifier_block on xen-ops.h

Patch fixes below warnings:

In file included from arch/x86/xen/xen-ops.h:7:0,

                    from arch/x86/xen/vga.c:9:
Quoted 1 line
Quoted 1 line

include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
Quoted 2 lines
Quoted 2 lines

include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_unregister(struct notifier_block *nb);
Signed-off-by Stanislaw Gruszka <[email protected]>
---
 drivers/xen/manage.c  | 1 -
 include/xen/xen-ops.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/xen/manage.c +0 -1
index 96e4173..fc6c94c 100644
@@ -13,7 +13,6 @@
 #include <linux/freezer.h>
 #include <linux/syscore_ops.h>
 #include <linux/export.h>
-#include <linux/notifier.h>
 
 #include <xen/xen.h>
 #include <xen/xenbus.h>
include/xen/xen-ops.h +1 -0
index cc8b4cb..acc7b7a 100644
@@ -2,6 +2,7 @@
 #define INCLUDE_XEN_OPS_H
 
 #include <linux/percpu.h>
+#include <linux/notifier.h>
 #include <asm/xen/interface.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
Signature · 1 line
1.7.11.7
#2 lore raw
Quoted 10 lines · Stanislaw Gruszka

Patch fixes below warnings:

In file included from arch/x86/xen/xen-ops.h:7:0,

                    from arch/x86/xen/vga.c:9:
Quoted 1 line
Quoted 1 line

include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
Quoted 2 lines
Quoted 2 lines

include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_unregister(struct notifier_block *nb);

Is this a fix up to your previous "xen/acpi-processor: fix enabling interrupts on syscore_resume" patch? If so, do you mind if we squash the two commits together? So bisectability is improved.

David

author
#3 lore raw
Quoted 6 lines · David Vrabel
Quoted 5 lines · Stanislaw Gruszka

Patch fixes below warnings:

In file included from arch/x86/xen/xen-ops.h:7:0,

                    from arch/x86/xen/vga.c:9:
Quoted 1 line
Quoted 1 line

include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

Quoted 8 lines
Quoted 5 lines
    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
Quoted 2 lines
Quoted 2 lines

include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_unregister(struct notifier_block *nb);

Is this a fix up to your previous "xen/acpi-processor: fix enabling interrupts on syscore_resume" patch?

Yes.

Quoted 2 lines

If so, do you mind if we squash
the two commits together? So bisectability is improved.

No problem with that (though I don't think actual build is broken since we don't use xen_resume_notifier_register on .c files that do not include linux/notifier.h directly or indirectly).

Thanks
Stanislaw

author
#4 lore raw
In reply to David Vrabel
Quoted 6 lines · David Vrabel
Quoted 5 lines · Stanislaw Gruszka

Patch fixes below warnings:

In file included from arch/x86/xen/xen-ops.h:7:0,

                    from arch/x86/xen/vga.c:9:
Quoted 1 line
Quoted 1 line

include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

Quoted 8 lines
Quoted 5 lines
    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
Quoted 2 lines
Quoted 2 lines

include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_unregister(struct notifier_block *nb);

Is this a fix up to your previous "xen/acpi-processor: fix enabling interrupts on syscore_resume" patch?

Yes.

Quoted 2 lines

If so, do you mind if we squash
the two commits together? So bisectability is improved.

No problem with that (though I don't think actual build is broken since we don't use xen_resume_notifier_register on .c files that do not include linux/notifier.h directly or indirectly).

Thanks
Stanislaw

#5 lore raw
In reply to Stanislaw Gruszka
Quoted 10 lines · Stanislaw Gruszka

Patch fixes below warnings:

In file included from arch/x86/xen/xen-ops.h:7:0,

                    from arch/x86/xen/vga.c:9:
Quoted 1 line
Quoted 1 line

include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
Quoted 2 lines
Quoted 2 lines

include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_unregister(struct notifier_block *nb);

Is this a fix up to your previous "xen/acpi-processor: fix enabling interrupts on syscore_resume" patch? If so, do you mind if we squash the two commits together? So bisectability is improved.

David

author
#6 lore raw

PATCH 1/1 xen: declare notifier_block on xen-ops.h

In reply to a message not in the archive

Patch fixes below warnings:

In file included from arch/x86/xen/xen-ops.h:7:0,

                    from arch/x86/xen/vga.c:9:
Quoted 1 line
Quoted 1 line

include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
Quoted 2 lines
Quoted 2 lines

include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]

    void xen_resume_notifier_unregister(struct notifier_block *nb);
Signed-off-by Stanislaw Gruszka <[email protected]>
---
 drivers/xen/manage.c  | 1 -
 include/xen/xen-ops.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
drivers/xen/manage.c +0 -1
index 96e4173..fc6c94c 100644
@@ -13,7 +13,6 @@
 #include <linux/freezer.h>
 #include <linux/syscore_ops.h>
 #include <linux/export.h>
-#include <linux/notifier.h>
 
 #include <xen/xen.h>
 #include <xen/xenbus.h>
include/xen/xen-ops.h +1 -0
index cc8b4cb..acc7b7a 100644
@@ -2,6 +2,7 @@
 #define INCLUDE_XEN_OPS_H
 
 #include <linux/percpu.h>
+#include <linux/notifier.h>
 #include <asm/xen/interface.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
Signature · 1 line
1.7.11.7