Skip to contentSkip to conversation

ACPI: fix ACPI_VIDEO dependencies

PATCH In review Jean Delvare 2 participants 5 messages Mar 17, 2014 – Mar 19, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 ACPI: fix ACPI_VIDEO dependencies

From: Jean Delvare <[email protected]>
Subject: ACPI: fix ACPI_VIDEO dependencies

ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago (see commit 677bd810, "ACPI video: remove output switching control".) So it's about time to remove the Kconfig dependency between these two options.

Cc Zhang Rui <[email protected]>
Cc Len Brown <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>

---
It would be great if this patch could go upstream quickly, as system-wide cleanups depend on it.

 drivers/acpi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig +1 -1
@@ -115,7 +115,7 @@ config ACPI_BUTTON
 
 config ACPI_VIDEO
 	tristate "Video"
-	depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
+	depends on X86 && BACKLIGHT_CLASS_DEVICE
 	depends on INPUT
 	select THERMAL
 	help
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw

Hi,

Quoted 8 lines · Jean Delvare

From: Jean Delvare <[email protected]>
Subject: ACPI: fix ACPI_VIDEO dependencies

ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago (see commit 677bd810, "ACPI video: remove output switching control".) So it's about time to remove the Kconfig dependency between these two options.

Quoted 4 lines
Cc Zhang Rui <[email protected]>
Cc Len Brown <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>

Do you want me to take this series?

Quoted 21 lines

---
It would be great if this patch could go upstream quickly, as system-wide cleanups depend on it.

 drivers/acpi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/Kconfig +1 -1
@@ -115,7 +115,7 @@ config ACPI_BUTTON
 
 config ACPI_VIDEO
 	tristate "Video"
-	depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
+	depends on X86 && BACKLIGHT_CLASS_DEVICE
 	depends on INPUT
 	select THERMAL
 	help
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
#2 lore raw

Hi Rafael,

Quoted 9 lines · Rafael J. Wysocki
Quoted 8 lines · Jean Delvare

From: Jean Delvare <[email protected]>
Subject: ACPI: fix ACPI_VIDEO dependencies

ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago (see commit 677bd810, "ACPI video: remove output switching control".) So it's about time to remove the Kconfig dependency between these two options.

Quoted 6 lines
Quoted 4 lines
Cc Zhang Rui <[email protected]>
Cc Len Brown <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>

Do you want me to take this series?

If other maintainers are OK with it, yes, I think that would be the easiest way. Thanks for proposing. All these patches depend on each other and must be applied in the right order, so pushing them through different trees would be slow at best, and risky.

Also, thinking about it, I wonder if the first 3 patches of the series could go to longterm kernel series? While they do not fix any build breakage nor run-time bug, without them everyone (on x86 at least) is forced to build dead code. This is kind of frustrating. They are simple and obvious enough that hopefully there won't be any objection.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support
#3 lore raw
Quoted 17 lines · Jean Delvare

Hi Rafael,

Quoted 14 lines · Rafael J. Wysocki
Quoted 12 lines · Jean Delvare

From: Jean Delvare <[email protected]>
Subject: ACPI: fix ACPI_VIDEO dependencies

ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago (see commit 677bd810, "ACPI video: remove output switching control".) So it's about time to remove the Kconfig dependency between these two options.

Cc Zhang Rui <[email protected]>
Cc Len Brown <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Quoted 6 lines
Quoted 1 line

Do you want me to take this series?

If other maintainers are OK with it, yes, I think that would be the easiest way. Thanks for proposing. All these patches depend on each other and must be applied in the right order, so pushing them through different trees would be slow at best, and risky.

OK, I'll queue them up for 3.15 then, as I haven't seen any objections.

Quoted 5 lines

Also, thinking about it, I wonder if the first 3 patches of the series could go to longterm kernel series? While they do not fix any build breakage nor run-time bug, without them everyone (on x86 at least) is forced to build dead code. This is kind of frustrating. They are simple and obvious enough that hopefully there won't be any objection.

I think it'll be best if you request the -stable people to pick up those commits once they have reached the Linus' tree.

Thanks,
Rafael

#4 lore raw
Quoted 18 lines · Rafael J. Wysocki
Quoted 17 lines · Jean Delvare

Hi Rafael,

Quoted 14 lines · Rafael J. Wysocki
Quoted 12 lines · Jean Delvare

From: Jean Delvare <[email protected]>
Subject: ACPI: fix ACPI_VIDEO dependencies

ACPI_VIDEO stopped depending on VIDEO_OUTPUT_CONTROL over 3 years ago (see commit 677bd810, "ACPI video: remove output switching control".) So it's about time to remove the Kconfig dependency between these two options.

Cc Zhang Rui <[email protected]>
Cc Len Brown <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Do you want me to take this series?

If other maintainers are OK with it, yes, I think that would be the easiest way. Thanks for proposing. All these patches depend on each other and must be applied in the right order, so pushing them through different trees would be slow at best, and risky.

OK, I'll queue them up for 3.15 then, as I haven't seen any objections.

Thank you :-)

Quoted 8 lines
Quoted 5 lines

Also, thinking about it, I wonder if the first 3 patches of the series could go to longterm kernel series? While they do not fix any build breakage nor run-time bug, without them everyone (on x86 at least) is forced to build dead code. This is kind of frustrating. They are simple and obvious enough that hopefully there won't be any objection.

I think it'll be best if you request the -stable people to pick up those commits once they have reached the Linus' tree.

Sure, I can do that.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support