Skip to contentSkip to conversation

ARM: dts: imx: Add alias for ethernet controller

PATCH New Marek Vasut 2 participants 9 messages Feb 28, 2014 – Jul 22, 2014

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>
---
 arch/arm/boot/dts/imx25.dtsi   | 1 +
 arch/arm/boot/dts/imx27.dtsi   | 1 +
 arch/arm/boot/dts/imx35.dtsi   | 1 +
 arch/arm/boot/dts/imx50.dtsi   | 1 +
 arch/arm/boot/dts/imx51.dtsi   | 1 +
 arch/arm/boot/dts/imx53.dtsi   | 1 +
 arch/arm/boot/dts/imx6qdl.dtsi | 1 +
 arch/arm/boot/dts/imx6sl.dtsi  | 1 +
 8 files changed, 8 insertions(+)
arch/arm/boot/dts/imx25.dtsi +1 -0
index 32f760e..77bb743 100644
@@ -14,6 +14,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		gpio0 = &gpio1;
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
arch/arm/boot/dts/imx27.dtsi +1 -0
index 6279e0b..83a8247 100644
@@ -16,6 +16,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		gpio0 = &gpio1;
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
arch/arm/boot/dts/imx35.dtsi +1 -0
index 88b218f..e59ccb4 100644
@@ -13,6 +13,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		gpio0 = &gpio1;
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
arch/arm/boot/dts/imx50.dtsi +1 -0
index 0c75fe3..c249064 100644
@@ -17,6 +17,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		gpio0 = &gpio1;
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
arch/arm/boot/dts/imx51.dtsi +1 -0
index e4b07d1..e508e6f 100644
@@ -19,6 +19,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		gpio0 = &gpio1;
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
arch/arm/boot/dts/imx53.dtsi +1 -0
index 80615df..5f382ea 100644
@@ -18,6 +18,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		gpio0 = &gpio1;
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
arch/arm/boot/dts/imx6qdl.dtsi +1 -0
index a2d5c49..d63df59 100644
@@ -14,6 +14,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		can0 = &can1;
 		can1 = &can2;
 		gpio0 = &gpio1;
arch/arm/boot/dts/imx6sl.dtsi +1 -0
index 3cb4941..6477447 100644
@@ -14,6 +14,7 @@
 
 / {
 	aliases {
+		ethernet0 = &fec;
 		gpio0 = &gpio1;
 		gpio1 = &gpio2;
 		gpio2 = &gpio3;
Signature · 1 line
1.8.5.2
author
#1 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>

Bump ?

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 8 lines · Marek Vasut
Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>

Bump ?

Sorry. I had actually applied the patch but forgot replying.

Shawn

author
#3 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 11 lines · Shawn Guo
Quoted 8 lines · Marek Vasut
Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>

Bump ?

Sorry. I had actually applied the patch but forgot replying.

Uh, no, apology is on my end for not checking first. Sorry!

Thank you!

Best regards,
Marek Vasut

author
#4 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

In reply to Shawn Guo
Quoted 11 lines · Shawn Guo
Quoted 8 lines · Marek Vasut
Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>

Bump ?

Sorry. I had actually applied the patch but forgot replying.

Hello Shawn,

I'd like to apply this patch for 3.14-stable , are you OK with this please ? Shall I submit it ?

Best regards,
Marek Vasut

#5 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 9 lines · Marek Vasut
Quoted 8 lines · Shawn Guo
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>
Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Bump ?

Sorry. I had actually applied the patch but forgot replying.

Hello Shawn,

I'd like to apply this patch for 3.14-stable , are you OK with this please ? Shall I submit it ?

I do not see why this is a stable material. But you do not need my approval to send patch for stable kernel. The person you need to convince is Greg.

Shawn

author
#6 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 14 lines · Shawn Guo
Quoted 13 lines · Marek Vasut
Quoted 11 lines · Shawn Guo
Quoted 8 lines · Marek Vasut
Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>

Bump ?

Sorry. I had actually applied the patch but forgot replying.

Quoted 8 lines
Quoted 4 lines

Hello Shawn,

I'd like to apply this patch for 3.14-stable , are you OK with this please ? Shall I submit it ?

I do not see why this is a stable material. But you do not need my approval to send patch for stable kernel. The person you need to convince is Greg.

Without this patch, you will not get a mac address patched into the DT by the bootloader. Therefore, your device will use a random mac address on the network which is different on every boot. This is not a good thing, don't you agree?

Best regards,
Marek Vasut

#7 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 20 lines · Marek Vasut
Quoted 19 lines · Shawn Guo
Quoted 17 lines · Marek Vasut
Quoted 11 lines · Shawn Guo
Quoted 8 lines · Marek Vasut
Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>

Bump ?

Sorry. I had actually applied the patch but forgot replying.

Hello Shawn,

I'd like to apply this patch for 3.14-stable , are you OK with this please ? Shall I submit it ?

Quoted 7 lines
Quoted 3 lines

I do not see why this is a stable material. But you do not need my approval to send patch for stable kernel. The person you need to convince is Greg.

Without this patch, you will not get a mac address patched into the DT by the bootloader. Therefore, your device will use a random mac address on the network which is different on every boot. This is not a good thing, don't you agree?

I agree this is not a good thing. But it's neither a regression nor a critical issue as defined by stable_kernel_rules.txt.

Shawn

author
#8 lore raw

PATCH 1/1 ARM: dts: imx: Add alias for ethernet controller

Quoted 25 lines · Shawn Guo
Quoted 24 lines · Marek Vasut
Quoted 22 lines · Shawn Guo
Quoted 9 lines · Marek Vasut
Quoted 8 lines · Shawn Guo
Quoted 7 lines · Marek Vasut
Quoted 5 lines · Marek Vasut

Add alias for FEC ethernet on i.MX to allow bootloaders (like U-Boot) patch-in the MAC address for FEC using this alias.

Signed-off-by Marek Vasut <[email protected]>
Cc Shawn Guo <[email protected]>
Quoted 8 lines
Quoted 3 lines
Quoted 1 line

Bump ?

Sorry. I had actually applied the patch but forgot replying.

Hello Shawn,

I'd like to apply this patch for 3.14-stable , are you OK with this please ? Shall I submit it ?

I do not see why this is a stable material. But you do not need my approval to send patch for stable kernel. The person you need to convince is Greg.

Quoted 7 lines
Quoted 4 lines

Without this patch, you will not get a mac address patched into the DT by the bootloader. Therefore, your device will use a random mac address on the network which is different on every boot. This is not a good thing, don't you agree?

I agree this is not a good thing. But it's neither a regression nor a critical issue as defined by stable_kernel_rules.txt.

If I cannot even properly boot from an NFS root with v3.14.y , it seems to me to be problem enough. Also, MAC address should be a unique identifier, if the FEC picks a random MAC, it will wreak havoc on the network (in the better case).

Best regards,
Marek Vasut