Allow --dump-dmesg for Xen vmcores
Subsystems (2)
PATCH 1/1 Allow --dump-dmesg for Xen vmcores
If a Xen dump is detected, makedumpfile checks that the target format is ELF. The real reason is that compressed formats are not possible with Xen.
But there's a third way initial_xen() can be called: with --dump-dmesg. This variant works in fact, so it's enough to extend the check so that it covers this case.
--- makedumpfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
makedumpfile.c +1 -1
@@ -7660,7 +7660,7 @@ initial_xen(void)MSG ("Xen is not supported on powerpc.\n" );return FALSE;#else -if (!info->flag_elf_dumpfile) { +if (!info->flag_elf_dumpfile && !info->flag_dmesg) {MSG ("Specify '-E' option for Xen.\n" );MSG ("Commandline parameter is invalid.\n" );MSG ("Try `makedumpfile --help' for more information.\n" );
Signature · 6 lines
1.8.4.5 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Hello Petr,
Quoted 8 lines
If a Xen dump is detected, makedumpfile checks that the target format is ELF. The real reason is that compressed formats are not possible with Xen.
But there's a third way
initial_xen()can be called: with --dump-dmesg. This variant works in fact, so it's enough to extend the check so that it covers this case.Signed-off-by Petr Tesarik <[email protected]>
Good fix, I'll merge this patch into v1.5.6.
Thanks
Atsushi Kumagai
Quoted 20 lines
---
makedumpfile.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)makedumpfile.c +1
-2@@ -7660,7 +7660,7 @@ initial_xen(void)MSG ("Xen is not supported on powerpc.\n" );return FALSE;#else -if (!info->flag_elf_dumpfile) { +if (!info->flag_elf_dumpfile && !info->flag_dmesg) {MSG ("Specify '-E' option for Xen.\n" );MSG ("Commandline parameter is invalid.\n" );MSG ("Try `makedumpfile --help' for more information.\n" ); --1.8.4.5
Quoted 4 lines
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec