Documentation: clk: Add locking documentation
PATCH v2 1/1 Documentation: clk: Add locking documentation
Briefly documentation the common clock framework locking scheme from a clock driver point of view.
--- Documentation/clk.txt | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
Documentation/clk.txt +34 -0
@@ -255,3 +255,37 @@ are sorted out. To bypass this disabling, include "clk_ignore_unused" in the bootargs to the kernel. + + Part 7 - Locking + +The common clock framework uses two global locks, the prepare lock and the +enable lock. + +The enable lock is a spinlock and is held across calls to the .enable, +.disable and .is_enabled operations. Those operations are thus not allowed to +sleep, and calls to the clk_enable(), clk_disable() and clk_is_enabled() API +functions are allowed in atomic context. + +The prepare lock is a mutex and is held across calls to all other operations. +All those operations are allowed to sleep, and calls to the corresponding API +functions are not allowed in atomic context. + +This effectively divides operations in two groups from a locking perspective. + +Drivers don't need to manually protect resources shared between the operations +of one group, regardless of whether those resources are shared by multiple +clocks or not. However, access to resources that are shared between operations +of the two groups needs to be protected by the drivers. An example of such a +resource would be a register that controls both the clock rate and the clock +enable/disable state. + +The clock framework is reentrant, in that a driver is allowed to call clock +framework functions from within its implementation of clock operations. This +can for instance cause a .set_rate operation of one clock being called from +within the .set_rate operation of another clock. This case must be considered +in the driver implementations, but the code flow is usually controlled by the +driver in that case. + +Note that locking must also be considered when code outside of the common +clock framework needs to access resources used by the clock operations. This +is considered out of scope of this document.
Signature · 3 lines
Regards, Laurent Pinchart
PATCH v2 1/1 Documentation: clk: Add locking documentation
Hello,
Quoted 4 lines · On Friday 28 February 2014 13:40:56 Laurent Pinchart wrote:
Briefly documentation the common clock framework locking scheme from a clock driver point of view.
Signed-off-by Laurent Pinchart <[email protected]>
Ping ? Is this version better (and acceptable) ?
Quoted 46 lines
--- Documentation/clk.txt | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)Documentation/clk.txt +0
-0@@ -255,3 +255,37 @@ are sorted out. To bypass this disabling, include "clk_ignore_unused" in the bootargs tothe kernel.
Documentation/clk.txt +8
-0+ + Part 7 - Locking + +The common clock framework uses two global locks, the prepare lock and the +enable lock. + +The enable lock is a spinlock and is held across calls to the .enable, +.disable and .is_enabled operations. Those operations are thus not allowedto +sleep, and calls to the
clk_enable(),clk_disable()andclk_is_enabled()API +functions are allowed in atomic context.Documentation/clk.txt +2
-0+ +The prepare lock is a mutex and is held across calls to all otheroperations. +All those operations are allowed to sleep, and calls to the corresponding API +functions are not allowed in atomic context.
Documentation/clk.txt +2
-0+ +This effectively divides operations in two groups from a lockingperspective. +
+Drivers don't need to manually protect resources shared between the operations +of one group, regardless of whether those resources are shared by multiple +clocks or not. However, access to resources that are shared between operations +of the two groups needs to be protected by the drivers. An example of such a +resource would be a register that controls both the clock rate and the clock +enable/disable state.Documentation/clk.txt +3
-0+ +The clock framework is reentrant, in that a driver is allowed to call clock +framework functions from within its implementation of clock operations.This +can for instance cause a .set_rate operation of one clock being called from +within the .set_rate operation of another clock. This case must be considered +in the driver implementations, but the code flow is usually controlled by the +driver in that case.
Documentation/clk.txt +3
-0+ +Note that locking must also be considered when code outside of the common +clock framework needs to access resources used by the clock operations.This +is considered out of scope of this document.
Signature · 3 lines
Regards, Laurent Pinchart
PATCH v2 1/1 Documentation: clk: Add locking documentation
Quoting Laurent Pinchart (2014-03-12 05:11:01)
Quoted 9 lines
Hello,
Quoted 4 lines · On Friday 28 February 2014 13:40:56 Laurent Pinchart wrote:
Briefly documentation the common clock framework locking scheme from a clock driver point of view.
Signed-off-by Laurent Pinchart <[email protected]>Ping ? Is this version better (and acceptable) ?
Yes, thanks much for the resend. I fixed a small typo in the changelog:
s/documentation/document/
Taken into clk-next.
Regards,
Mike