clk: hisilicon: fix warning from smatch
PATCH 1/1 clk: hisilicon: fix warning from smatch
drivers/clk/hisilicon/clk-hi3620.c:338mmc_clk_delay() warn: always true condition '(para >= 0) => (0-u32max >= 0)'
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Zhangfei Gao <[email protected]>
--- drivers/clk/hisilicon/clk-hi3620.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
drivers/clk/hisilicon/clk-hi3620.c +7 -8
@@ -335,15 +335,14 @@ static u32 mmc_clk_delay(u32 val, u32 para, u32 off, u32 len) {u32 i; -if (para >=0 ) { -for (i =0 ; i < len; i++) { -if (para %2 ) - val |=1 << (off + i); -else - val &= ~(1 << (off + i)); - para = para >>1 ; - } +for (i =0 ; i < len; i++) { +if (para %2 ) + val |=1 << (off + i); +else + val &= ~(1 << (off + i)); + para = para >>1 ; } +return val; }
Signature · 1 line
1.7.9.5
PATCH 1/1 clk: hisilicon: fix warning from smatch
Quoting Zhangfei Gao (2014-03-09 20:33:20)
Quoted 5 lines
drivers/clk/hisilicon/clk-hi3620.c:338mmc_clk_delay()warn: always true condition '(para >= 0) => (0-u32max >= 0)'Reported-by Dan Carpenter <[email protected]>Signed-off-by Zhangfei Gao <[email protected]>
Taken into clk-next.
Regards,
Mike
Quoted 34 lines
--- drivers/clk/hisilicon/clk-hi3620.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)drivers/clk/hisilicon/clk-hi3620.c +7
-8@@ -335,15 +335,14 @@ static u32 mmc_clk_delay(u32 val, u32 para, u32 off, u32 len) {u32 i; -if (para >=0 ) { -for (i =0 ; i < len; i++) { -if (para %2 ) - val |=1 << (off + i); -else - val &= ~(1 << (off + i)); - para = para >>1 ; - } +for (i =0 ; i < len; i++) { +if (para %2 ) + val |=1 << (off + i); +else + val &= ~(1 << (off + i)); + para = para >>1 ; } +return val; }Signature · 1 line
1.7.9.5