Skip to contentSkip to conversation

drm/i2c: tda998x: Change the compatible strings

PATCH In review Jean-Francois Moine 3 participants 6 messages Mar 21, 2014 – Mar 23, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i2c: tda998x: Change the compatible strings

The tda998x driver accepts only 3 chips from the TDA998x family. This patch changes the driver compatible strings to these chips.

---
v2: change the subject to drm/i2c
This patch applies after
drm/i2c: tda998x: Fix lack of required reg in DT documentation

---
 Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 4 ++--
 drivers/gpu/drm/i2c/tda998x_drv.c                     | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +2 -2
index fc7effa..e3f3d65 100644
@@ -1,7 +1,7 @@
 Device-Tree bindings for the NXP TDA998x HDMI transmitter
 
 Required properties;
-  - compatible: must be "nxp,tda998x"
+  - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989"
 
   - reg: I2C address
 
@@ -20,7 +20,7 @@ Optional properties:
 Example:
 
 	tda998x: hdmi-encoder {
-		compatible = "nxp,tda998x";
+		compatible = "nxp,tda19988";
 		reg = <0x70>;
 		interrupt-parent = <&gpio0>;
 		interrupts = <27 2>;		/* falling edge */
drivers/gpu/drm/i2c/tda998x_drv.c +3 -1
index 48af5ca..fd6751c 100644
@@ -1367,7 +1367,9 @@ fail:
 
 #ifdef CONFIG_OF
 static const struct of_device_id tda998x_dt_ids[] = {
-	{ .compatible = "nxp,tda998x", },
+	{ .compatible = "nxp,tda9989", },
+	{ .compatible = "nxp,tda19988", },
+	{ .compatible = "nxp,tda19989", },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, tda998x_dt_ids);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Jean-Francois Moine

The tda998x driver accepts only 3 chips from the TDA998x family. This patch changes the driver compatible strings to these chips.

Jean-Francois,

be careful with building a DT binding from a Linux driver. Although we constantly struggle to define a binding independent of Linux, it should not reflect what Linux is capable of but describe the HW in general.

Quoted 14 lines

---
v2: change the subject to drm/i2c
This patch applies after
drm/i2c: tda998x: Fix lack of required reg in DT documentation

---
  Documentation/devicetree/bindings/drm/i2c/tda998x.txt | 4 ++--
  drivers/gpu/drm/i2c/tda998x_drv.c                     | 4 +++-
  2 files changed, 5 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +0 -0
index fc7effa..e3f3d65 100644

Documentation/devicetree/bindings/drm/i2c/tda998x.txt line 4

Quoted 5 lines
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +1 -1
@@ -1,7 +1,7 @@
  Device-Tree bindings for the NXP TDA998x HDMI transmitter
 
  Required properties;
-  - compatible: must be "nxp,tda998x"
+  - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989"

There is a "DT is ABI" policy and although there is no mainline Linux user of current compatible, the correct way would be to deprecate "nxp,tda998x" and introduce new compatibles.

Also, as long as we don't know about any major differences between 9989, 1998[89] it is fine to just have one of them defined. As soon as we discover any difference that cannot be solved in another way, we can add a new compatible.

What we _know_ is that 998[134] are different from 9989,1998[89] with respect to additional CEC feature. But we also _know_ that the exact version/revision of 9989,1998[89] can be probed from i2c registers.

DT maintainers will know better, but as long as we have no prove that 998[134] can also be properly distinguished by i2c registers, just add "nxp,tda9989" (which was probably the first revision released) and assume 1998[89] are "compatible enough". Or add all three and make "nxp,tda9989" the mandatory compatible.

You can leave out 998[134] for now.

Documentation/devicetree/bindings/drm/i2c/tda998x.txt line 7

Quoted 2 lines
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +0 -0
    - reg: I2C address
 

The line above and below reg property look like there is a tab. If so, can you please get rid of the blank line above and fix the line below?

Documentation/devicetree/bindings/drm/i2c/tda998x.txt Optional properties: · line 23

Quoted 6 lines
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +1 -1
@@ -20,7 +20,7 @@ Optional properties:
  Example:
 
  	tda998x: hdmi-encoder {
-		compatible = "nxp,tda998x";
+		compatible = "nxp,tda19988";

Depending on above decision this becomes either

compatible = "nxp,tda9989";

or

compatible = "nxp,tda19988", "nxp,tda9989";

Quoted 8 lines
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +0 -0
  		reg = <0x70>;
  		interrupt-parent = <&gpio0>;
  		interrupts = <27 2>;		/* falling edge */
drivers/gpu/drm/i2c/tda998x_drv.c +0 -0
index 48af5ca..fd6751c 100644

drivers/gpu/drm/i2c/tda998x_drv.c fail: · line 1372

Quoted 7 lines
drivers/gpu/drm/i2c/tda998x_drv.c +3 -1
@@ -1367,7 +1367,9 @@ fail:
 
  #ifdef CONFIG_OF
  static const struct of_device_id tda998x_dt_ids[] = {
-	{ .compatible = "nxp,tda998x", },
+	{ .compatible = "nxp,tda9989", },
+	{ .compatible = "nxp,tda19988", },
+	{ .compatible = "nxp,tda19989", },

Independent of the decision above, just "nxp,tda9989" is sufficient.

Sebastian

Quoted 4 lines
drivers/gpu/drm/i2c/tda998x_drv.c +0 -0
  	{ }
  };
  MODULE_DEVICE_TABLE(of, tda998x_dt_ids);
#2 lore raw
Quoted 7 lines · On Fri, 21 Mar 2014 14:37:52 +0100 Sebastian Hesselbarth…

Documentation/devicetree/bindings/drm/i2c/tda998x.txt line 4

Quoted 3 lines

Required properties;

Documentation/devicetree/bindings/drm/i2c/tda998x.txt +1 -1
-  - compatible: must be "nxp,tda998x"
+  - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989"  

There is a "DT is ABI" policy and although there is no mainline Linux user of current compatible, the correct way would be to deprecate "nxp,tda998x" and introduce new compatibles.

Pratically, what is this way?

Signature · 6 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#3 lore raw
Quoted 11 lines · Jean-Francois Moine
Quoted 7 lines · On Fri, 21 Mar 2014 14:37:52 +0100 Sebastian Hesselbarth…

Documentation/devicetree/bindings/drm/i2c/tda998x.txt line 4

Quoted 3 lines
   Required properties;
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +1 -1
-  - compatible: must be "nxp,tda998x"
+  - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989"

There is a "DT is ABI" policy and although there is no mainline Linux user of current compatible, the correct way would be to deprecate "nxp,tda998x" and introduce new compatibles.

Pratically, what is this way?

Currently, there is no effective way to deprecate a binding or compatible. You just add the one(s) that are more sensible and you mark the old one as DEPRECATED by simply writing it in the binding doc.

The driver should support the old binding at least for a while.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 11 lines · Sebastian Hesselbarth
Quoted 10 lines · Jean-Francois Moine
Quoted 7 lines · On Fri, 21 Mar 2014 14:37:52 +0100 Sebastian Hesselbarth…

Documentation/devicetree/bindings/drm/i2c/tda998x.txt line 4

Quoted 3 lines
   Required properties;
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +1 -1
-  - compatible: must be "nxp,tda998x"
+  - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989"

There is a "DT is ABI" policy and although there is no mainline Linux user of current compatible, the correct way would be to deprecate "nxp,tda998x" and introduce new compatibles.

Quoted 8 lines
Quoted 1 line

Pratically, what is this way?

Currently, there is no effective way to deprecate a binding or compatible. You just add the one(s) that are more sensible and you mark the old one as DEPRECATED by simply writing it in the binding doc.

The driver should support the old binding at least for a while.

It doesn't need to - it's only been in development trees so far, and never been in a mainline full release. Until it does, the binding does not become stable.

Signature · 2 lines
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
#5 lore raw
Quoted 19 lines · Russell King - ARM Linux
Quoted 18 lines · Sebastian Hesselbarth
Quoted 11 lines · Jean-Francois Moine
Quoted 7 lines · On Fri, 21 Mar 2014 14:37:52 +0100 Sebastian Hesselbarth…

Documentation/devicetree/bindings/drm/i2c/tda998x.txt line 4

Quoted 3 lines
    Required properties;
Documentation/devicetree/bindings/drm/i2c/tda998x.txt +1 -1
-  - compatible: must be "nxp,tda998x"
+  - compatible: may be "nxp,tda9989", "nxp,tda19988" or "nxp,tda19989"

There is a "DT is ABI" policy and although there is no mainline Linux user of current compatible, the correct way would be to deprecate "nxp,tda998x" and introduce new compatibles.

Pratically, what is this way?

Currently, there is no effective way to deprecate a binding or compatible. You just add the one(s) that are more sensible and you mark the old one as DEPRECATED by simply writing it in the binding doc.

Quoted 5 lines
Quoted 1 line

The driver should support the old binding at least for a while.

It doesn't need to - it's only been in development trees so far, and never been in a mainline full release. Until it does, the binding does not become stable.

Ok, I see. Thanks for the clarification. A note about it would have been nice though. Anyway, sorry for the noise.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html