Skip to contentSkip to conversation

mtools: fix build when libiconv is enabled

PATCH New Bernd Kuhls 3 participants 3 messages Mar 22, 2014 – Mar 23, 2014

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH v2 1/1 mtools: fix build when libiconv is enabled

Fixes
http://autobuild.buildroot.net/results/298/298858b6cc89438dcd044c74dff4231186a065e1/
http://autobuild.buildroot.net/results/7e7/7e7e7027226bb0251e32a90df2f00d9e84aedaaf/
http://autobuild.buildroot.net/results/c18/c18e7da16121417e597a153ce7dc2a3b64ece3b0/
http://autobuild.buildroot.net/results/b29/b29e80441ed87be651d720ae2dccf24d0f7fe8b6/

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: fixed typo, shouldn?t commit patches early in the morning ;) (Yann)

 package/mtools/mtools.mk |    6 ++++++
 1 file changed, 6 insertions(+)
package/mtools/mtools.mk +6 -0
index 4880245..8649325 100644
@@ -12,5 +12,11 @@ MTOOLS_LICENSE_FILES = COPYING
 MTOOLS_CONF_ENV = ac_cv_func_setpgrp_void=yes
 MTOOLS_CONF_OPT = --without-x
 
+# link with iconv if enabled
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+MTOOLS_DEPENDENCIES += libiconv
+MTOOLS_CONF_ENV += LIBS=-liconv
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v2 1/1 mtools: fix build when libiconv is enabled

Bernd, All,

On 2014-03-22 14:47 +0100, Bernd Kuhls spake thusly:

Quoted 7 lines

Fixes
http://autobuild.buildroot.net/results/298/298858b6cc89438dcd044c74dff4231186a065e1/
http://autobuild.buildroot.net/results/7e7/7e7e7027226bb0251e32a90df2f00d9e84aedaaf/
http://autobuild.buildroot.net/results/c18/c18e7da16121417e597a153ce7dc2a3b64ece3b0/
http://autobuild.buildroot.net/results/b29/b29e80441ed87be651d720ae2dccf24d0f7fe8b6/

Signed-off-by Bernd Kuhls <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 29 lines

---
v2: fixed typo, shouldn?t commit patches early in the morning ;) (Yann)

 package/mtools/mtools.mk |    6 ++++++
 1 file changed, 6 insertions(+)
package/mtools/mtools.mk +6 -0
index 4880245..8649325 100644
@@ -12,5 +12,11 @@ MTOOLS_LICENSE_FILES = COPYING
 MTOOLS_CONF_ENV = ac_cv_func_setpgrp_void=yes
 MTOOLS_CONF_OPT = --without-x
 
+# link with iconv if enabled
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+MTOOLS_DEPENDENCIES += libiconv
+MTOOLS_CONF_ENV += LIBS=-liconv
+endif
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 6 lines
1.7.10.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 mtools: fix build when libiconv is enabled

In reply to Bernd Kuhls
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

Fixes
http://autobuild.buildroot.net/results/298/298858b6cc89438dcd044c74dff4231186a065e1/
http://autobuild.buildroot.net/results/7e7/7e7e7027226bb0251e32a90df2f00d9e84aedaaf/
http://autobuild.buildroot.net/results/c18/c18e7da16121417e597a153ce7dc2a3b64ece3b0/
http://autobuild.buildroot.net/results/b29/b29e80441ed87be651d720ae2dccf24d0f7fe8b6/

Signed-off-by Bernd Kuhls <[email protected]>

---
v2: fixed typo, shouldn?t commit patches early in the morning ;) (Yann)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard