Skip to contentSkip to conversation

Fix a test in the configure script

PATCH In review Bart Van Assche 2 participants 2 messages Mar 22, 2014 – Mar 23, 2014

lore
Share & tools
lore

Bart Van Assche

author
#0 lore raw

PATCH 1/1 Fix a test in the configure script

Avoid that the configure script prints the following error message:
./configure: line 14049: xyes: command not found

Signed-off-by Bart Van Assche <[email protected]>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
index 54a52ea..7ef151e 100644
@@ -112,7 +112,7 @@ AC_ARG_ENABLE([manpages],
         AS_HELP_STRING([--disable-manpages], [disable manpages @<:@default=enabled@:>@]),
 	[], enable_manpages=yes)
 AM_CONDITIONAL([BUILD_MANPAGES], [test "x$enable_manpages" = "xyes"])
-AS_IF(["x$enable_manpages" != "xno"], ["have_manpages=yes"])
+AS_IF([test "x$enable_manpages" != "xno"], ["have_manpages=yes"])
 
 AC_ARG_ENABLE([logging],
 	AS_HELP_STRING([--disable-logging], [disable system logging @<:@default=enabled@:>@]),
Signature · 1 line
1.8.4.5
#1 lore raw

Hi Bart,

Quoted 14 lines · Bart Van Assche

Avoid that the configure script prints the following error message:
./configure: line 14049: xyes: command not found

Signed-off-by Bart Van Assche <[email protected]>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +0 -0
index 54a52ea..7ef151e 100644

configure.ac AC_ARG_ENABLE([manpages], · line 118

Quoted 8 lines
configure.ac +1 -1
@@ -112,7 +112,7 @@ AC_ARG_ENABLE([manpages],
         AS_HELP_STRING([--disable-manpages], [disable manpages @<:@default=enabled@:>@]),
 	[], enable_manpages=yes)
 AM_CONDITIONAL([BUILD_MANPAGES], [test "x$enable_manpages" = "xyes"])
-AS_IF(["x$enable_manpages" != "xno"], ["have_manpages=yes"])
+AS_IF([test "x$enable_manpages" != "xno"], ["have_manpages=yes"])
 
 AC_ARG_ENABLE([logging],
 	AS_HELP_STRING([--disable-logging], [disable system logging @<:@default=enabled@:>@]),

I had another patch applied but not yet pushed:

Quoted 1 line

From 092d9448e0d46df135db0f6a6c48719e030e6477 Mon Sep 17 00:00:00 2001

From: Lucas De Marchi <[email protected]>
Date: Thu, 20 Mar 2014 09:50:12 -0300
Subject: [PATCH] build-sys: Remove bogus line causing warning

./configure: line 14316: xyes: command not found

We are not using have_manpages, so remove it.

---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)
configure.ac +0 -1
index 54a52ea..e95942a 100644
@@ -112,7 +112,6 @@ AC_ARG_ENABLE([manpages],
         AS_HELP_STRING([--disable-manpages], [disable manpages @<:@default=enabled@:>@]),
 	[], enable_manpages=yes)
 AM_CONDITIONAL([BUILD_MANPAGES], [test "x$enable_manpages" = "xyes"])
-AS_IF(["x$enable_manpages" != "xno"], ["have_manpages=yes"])
 
 AC_ARG_ENABLE([logging],
 	AS_HELP_STRING([--disable-logging], [disable system logging @<:@default=enabled@:>@]),
Signature · 11 lines
1.9.0


The difference is that we can completely remove this line since we are
not using it anymore. It was wrongly introduced in 
bccb4b2 ("build-sys: Do not require xsltproc for installation of man pages")



-- 
Lucas De Marchi