Skip to contentSkip to conversation

atkbd: Samsung NP530U3C laptop forced key release

PATCH In review Arkadiusz Bokowy (Arkq) 2 participants 2 messages Mar 11, 2014 – Mar 28, 2014

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Arkadiusz Bokowy (Arkq)

author
#0 lore raw

PATCH 1/1 atkbd: Samsung NP530U3C laptop forced key release

atkbd: Samsung NP530U3C laptop forced key release

For Samsung NP530U3C laptop (observed on firmware P09ABH) not all Fn keys generates release event, which leaves key in a pressed state. This patch adds those keys into the "forced release" workaround. Fixed keys: WLAN, Settings, Fn Lock.

Patch generated for kernel version 3.13.6

Signed-off-by Arkadiusz Bokowy <[email protected]>

---

drivers/input/keyboard/atkbd.c renamed from drivers/input/keyboard/atkbd.c.orig +16 -0
@@ -943,6 +943,13 @@ static unsigned int atkbd_samsung_forced
 };
 
 /*
+ * Samsung NP530U3C key release for WLAN, Settings and Fn Lock
+ */
+static unsigned int atkbd_samsung_np530_forced_release_keys[] = {
+	0xa8, 0xa9, 0xce, 0xd5, -1U
+};
+
+/*
  * Amilo Pi 3525 key release for Fn+Volume keys not working
  */
 static unsigned int atkbd_amilo_pi3525_forced_release_keys[] = {

@@ -1732,6 +1739,15 @@ static const struct dmi_system_id atkbd_
 		.driver_data = atkbd_samsung_forced_release_keys,
 	},
 	{
+		/* Samsung NP530U3C */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "530U3C"),
+		},
+		.callback = atkbd_setup_forced_release,
+		.driver_data = atkbd_samsung_np530_forced_release_keys,
+	},
+	{
 		/* Fujitsu Amilo PA 1510 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU SIEMENS"),
maintainer
#1 lore raw

Hi Arkadiusz,

Quoted 8 lines · Arkadiusz Bokowy

atkbd: Samsung NP530U3C laptop forced key release

For Samsung NP530U3C laptop (observed on firmware P09ABH) not all Fn keys generates release event, which leaves key in a pressed state. This patch adds those keys into the "forced release" workaround. Fixed keys: WLAN, Settings, Fn Lock.

Patch generated for kernel version 3.13.6

This should be done by udev nowadays, please submit patch for it instead of modifying the kernel.

Thanks!

Signature · 1 line
Dmitry