Skip to contentSkip to conversation

av7110: fix confusing indenting

PATCH New Dan Carpenter 1 participant 1 message Mar 28, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 av7110: fix confusing indenting

The else statement here is not aligned with the correct if statement. I think the code works as intended and it's just the indenting which is wrong. Also kernel style says we should use curly braces here so I have added those.

---
This patch doesn't change how the code works, but I would still appreciate extra review because maybe the original code is wrong?

drivers/media/pci/ttpci/av7110_av.c +4 -2
index 301029c..9544cfc 100644
@@ -958,8 +958,10 @@ static unsigned int dvb_video_poll(struct file *file, poll_table *wait)
 		if (av7110->playing) {
 			if (FREE_COND)
 				mask |= (POLLOUT | POLLWRNORM);
-			} else /* if not playing: may play if asked for */
-				mask |= (POLLOUT | POLLWRNORM);
+		} else {
+			/* if not playing: may play if asked for */
+			mask |= (POLLOUT | POLLWRNORM);
+		}
 	}
 
 	return mask;