i40e: remove an unneeded check

We know "ret" is zero here. No need to check again.

index 28da412..2640004 100644
@@ -1534,12 +1534,12 @@ static int i40e_add_del_fdir_ethtool(struct i40e_vsi *vsi,
 		return ret;
 	}
 
-	if (!ret && add)
+	if (add)
 		i40e_update_ethtool_fdir_entry(vsi, input, fsp->location, NULL);
 	else
 		kfree(input);
 
-	return ret;
+	return 0;
 }
 
 /**

Thanks Dan, I have added your patch to my queue.

Dan with the latest bunch of patches I just pushed and that Dave accepted, the code changes which directly affect your patch to leaves your patch only changing the return statement from:

return ret;

to

return 0;

but with the recent change in the code, the ret value can be something other than 0 so your patch does not appear to be needed any longer.

Can you double check my findings by taking a look at David Miller's latest net-next tree to verify please?

Cheers,
Jeff

Sure, yep. It's not needed anymore.

regards,
dan carpenter