systemd: disable build for unsupported architectures.
PATCH 1/1 systemd: disable build for unsupported architectures.
Systemd only supports the architectures defined in src/shared/architecture.h. This list does not contain ARC, Blackfin, Xtensa, Microblaze and Nios2, so this package is disabled for these architectures.
Fixes http://autobuild.buildroot.net/results/bcc/bcce95eb0748505c0d62db21a6e420aae3c3181b/
--- package/systemd/Config.in | 2 ++ system/Config.in | 2 ++ 2 files changed, 4 insertions(+)
package/systemd/Config.in +2 -0
@@ -2,6 +2,8 @@ config BR2_PACKAGE_SYSTEMD bool "systemd" depends on BR2_INIT_SYSTEMD depends on !BR2_avr32 # no epoll_create1 + depends on !BR2_arc && !BR2_bfin && !BR2_xtensa + depends on !BR2_microblaze && !BR2_nios2 depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_INET_IPV6
system/Config.in +2 -0
@@ -88,6 +88,8 @@ config BR2_INIT_SYSV config BR2_INIT_SYSTEMD bool "systemd" depends on !BR2_avr32 # no epoll_create1 + depends on !BR2_arc && !BR2_bfin && !BR2_xtensa + depends on !BR2_microblaze && !BR2_nios2 depends on BR2_TOOLCHAIN_USES_GLIBC depends on BR2_LARGEFILE depends on BR2_USE_WCHAR
Signature · 1 line
1.7.9.5
PATCH 1/1 systemd: disable build for unsupported architectures.
Dear Eric Le Bihan,
Quoted 19 lines · Eric Le Bihan
Systemd only supports the architectures defined in
src/shared/architecture.h. This list does not contain ARC, Blackfin, Xtensa, Microblaze and Nios2, so this package is disabled for these architectures.Fixes
http://autobuild.buildroot.net/results/bcc/bcce95eb0748505c0d62db21a6e420aae3c3181b/Signed-off-by Eric Le Bihan <[email protected]>--- package/systemd/Config.in | 2 ++ system/Config.in | 2 ++ 2 files changed, 4 insertions(+)package/systemd/Config.in +0
-0
package/systemd/Config.in config BR2_PACKAGE_SYSTEMD · line 6
Quoted 5 lines
package/systemd/Config.in +2
-0@@ -2,6 +2,8 @@ config BR2_PACKAGE_SYSTEMD bool "systemd" depends on BR2_INIT_SYSTEMD depends on !BR2_avr32 # no epoll_create1 + depends on !BR2_arc && !BR2_bfin && !BR2_xtensa + depends on !BR2_microblaze && !BR2_nios2
Maybe it's better to use positive logic here, and only explicitly allow systemd on the architectures that it supports. This way if tomorrow we add support for a new architecture, we won't get weird failures.
In package/systemd/Config.in:
config BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTS
bool default y if BR2_arm || BR2_powerpc || BR2_...
and then use "depends on BR2_PACKAGE_SYSTEM_ARCH_SUPPORTS" where needed.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 systemd: disable build for unsupported architectures.
Hi!
Quoted 7 lines · Thomas Petazzoni
Dear Eric Le Bihan,
Quoted 4 lines · Eric Le Bihan
Systemd only supports the architectures defined in
src/shared/architecture.h. This list does not contain ARC, Blackfin, Xtensa, Microblaze and Nios2, so this package is disabled for these architectures.
[...]
Quoted 5 lines
Maybe it's better to use positive logic here, and only explicitly allow systemd on the architectures that it supports. This way if tomorrow we add support for a new architecture, we won't get weird failures.
Quoted 7 lines
In package/systemd/Config.in:
config
BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTSbool default y if BR2_arm || BR2_powerpc || BR2_...and then use "depends on
BR2_PACKAGE_SYSTEM_ARCH_SUPPORTS" where needed.
Thanks for the advice! I noticed BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT in package/qt/Config.in follows the same logic.
Best regards,
ELB