clk: reverse default clk provider initialization order in of_clk_init()

This restores the default clocks registration order as parsed from devicetree, i.e. as before commit 1771b10d605d26ccee771a7fb4b08718 "clk: respect the clock dependencies in of_clk_init", for when there is no explicit parent clock dependencies between clock providers specified in the device tree.

It prevents regressions (boot failure, division by 0 errors) on imx and exynos platforms.

Signed-off-by Sylwester Nawrocki <[email protected]>

---
 drivers/clk/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/clk/clk.c +1 -1

index 07cba07..c859adf 100644
@@ -2596,7 +2596,7 @@ void __init of_clk_init(const struct of_device_id *matches)
 
 		parent->clk_init_cb = match->data;
 		parent->np = np;
-		list_add(&parent->node, &clk_provider_list);
+		list_add_tail(&parent->node, &clk_provider_list);
 	}
 
 	while (!list_empty(&clk_provider_list)) {

This restores the default clocks registration order as parsed from devicetree, i.e. as before commit 1771b10d605d26ccee771a7fb4b08718 "clk: respect the clock dependencies in of_clk_init", for when there is no explicit parent clock dependencies between clock providers specified in the device tree.

It prevents regressions (boot failure, division by 0 errors) on imx and exynos platforms.

Signed-off-by Sylwester Nawrocki <[email protected]>

---
 drivers/clk/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/clk/clk.c +1 -1

index 07cba07..c859adf 100644
@@ -2596,7 +2596,7 @@ void __init of_clk_init(const struct of_device_id *matches)
 
                parent->clk_init_cb = match->data;
                parent->np = np;
-               list_add(&parent->node, &clk_provider_list);
+               list_add_tail(&parent->node, &clk_provider_list);
        }
 
        while (!list_empty(&clk_provider_list)) {

Signature · 1 line

1.7.9.5

Quoting Sylwester Nawrocki (2014-03-27 03:43:32)

Quoted 9 lines

This restores the default clocks registration order as parsed from devicetree, i.e. as before commit 1771b10d605d26ccee771a7fb4b08718 "clk: respect the clock dependencies in of_clk_init", for when there is no explicit parent clock dependencies between clock providers specified in the device tree.

It prevents regressions (boot failure, division by 0 errors) on imx and exynos platforms.

Quoted 1 line

Signed-off-by Sylwester Nawrocki <[email protected]>

I pulled this into clk-next but it didn't seem to get picked up by linux-next in time for today's build. Let's test the next linux-next to insure that the regressions are gone. If not then I'll likely need to drop "clk: respect the clock dependencies in of_clk_init" from clk-next for 3.15.

Quoted 12 lines · Mike Turquette

Quoting Sylwester Nawrocki (2014-03-27 03:43:32)

Quoted 10 lines

This restores the default clocks registration order as parsed from devicetree, i.e. as before commit 1771b10d605d26ccee771a7fb4b08718 "clk: respect the clock dependencies in of_clk_init", for when there is no explicit parent clock dependencies between clock providers specified in the device tree.

It prevents regressions (boot failure, division by 0 errors) on imx and exynos platforms.

Signed-off-by Sylwester Nawrocki <[email protected]>

Quoted 5 lines

I pulled this into clk-next but it didn't seem to get picked up by linux-next in time for today's build. Let's test the next linux-next to insure that the regressions are gone. If not then I'll likely need to drop "clk: respect the clock dependencies in of_clk_init" from clk-next for 3.15.

It looks like all the boot failures caused by this problem are gone as of next-20140331[1], so it looks good to me.

Kevin

[1] http://lists.linaro.org/pipermail/kernel-build-reports/2014-March/002988.html