ASoC: ak5386: Add regulators to documentation and fix sparse warning
Subsystems (3)
PATCH 1/2 ASoC: ak5386: Add regulators to documentation and fix sparse warning
Document the newly added regulators to the DT binding document.
Also, "static const char const *x" is not identical to "static const char * const x", which sparse now complains about. Fix it.
--- Documentation/devicetree/bindings/sound/ak5386.txt | 4 ++++ sound/soc/codecs/ak5386.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/ak5386.txt +4 -0
@@ -10,10 +10,14 @@ Optional properties: - reset-gpio : a GPIO spec for the reset/power down pin. If specified, it will be deasserted at probe time. + - va-supply : a regulator spec, providing 5.0V + - vd-supply : a regulator spec, providing 3.3V Example: spdif: ak5386@0 { compatible = "asahi-kasei,ak5386"; reset-gpio = <&gpio0 23>; + va-supply = <&vdd_5v0_reg>; + vd-supply = <&vdd_3v3_reg>; };
sound/soc/codecs/ak5386.c +1 -1
@@ -19,7 +19,7 @@#include <sound/pcm.h> #include <sound/initval.h> -static const char const *supply_names[] = { +static const char *const supply_names[] = {"va" ,"vd" };
Signature · 1 line
1.8.5.3
PATCH 2/2 ASoC: ak4104: Add regulator to documentation
Add the 3v3 supply to Documentation/devicetree/bindings/sound/ak4104.txt.
--- Documentation/devicetree/bindings/sound/ak4104.txt | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/sound/ak4104.txt +3 -0
@@ -8,6 +8,8 @@ Required properties: - reg : The chip select number on the SPI bus + - vdd-supply : A regulator node, providing 2.7V - 3.6V + Optional properties: - reset-gpio : a GPIO spec for the reset pin. If specified, it will be
@@ -19,4 +21,5 @@ spdif: ak4104@0 { compatible = "asahi-kasei,ak4104"; reg = <0>; spi-max-frequency = <5000000>; + vdd-supply = <&vdd_3v3_reg>; };
Signature · 1 line
1.8.5.3
Re: [PATCH 2/2] ASoC: ak4104: Add regulator to documentation
Quoted 1 line · Daniel Mack
Add the 3v3 supply to
Documentation/devicetree/bindings/sound/ak4104.txt.
Applied, thanks (changelog is slightly wrong...).
Quoted 4 lines · Daniel Mack
Document the newly added regulators to the DT binding document.
Also, "static const char const *x" is not identical to "static const char * const x", which sparse now complains about. Fix it.
Applied, though this should really have been two patches as there's no overlap.
Quoted 9 lines · Mark Brown
Quoted 4 lines · Daniel Mack
Document the newly added regulators to the DT binding document.
Also, "static const char const *x" is not identical to "static const char * const x", which sparse now complains about. Fix it.
Applied, though this should really have been two patches as there's no overlap.
Hmm, for some reason, this patch didn't make it to mainline yet. Same for another one that patches the same file which I sent the same day. Want me to resend?
Thanks,
Daniel
Mark Brown
maintainerQuoted 3 lines · Daniel Mack
Hmm, for some reason, this patch didn't make it to mainline yet. Same for another one that patches the same file which I sent the same day. Want me to resend?
It's probably poor network connectivity to kernel.org at the time I applied them but I can't tell any more. They should be there now.