Skip to contentSkip to conversation

valgrind: Add support for MIPS architecture

PATCH New Vicente Olivert Riera 3 participants 7 messages Mar 28, 2014 – Mar 31, 2014

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/1 valgrind: Add support for MIPS architecture

Reviewed-by Markos Chandras <[email protected]>
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/valgrind/Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
package/valgrind/Config.in +2 -1
index dacdd86..fd5649b 100644
@@ -1,7 +1,8 @@
 config BR2_PACKAGE_VALGRIND
 	bool "valgrind"
 	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
-		   BR2_cortex_a9 || BR2_powerpc
+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
 	help
 	  Tool for debugging and profiling Linux programs.
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 valgrind: Add support for MIPS architecture

Hi Vicente,

Vicente Olivert Riera <[email protected]> schreef:

Quoted 17 lines
Reviewed-by Markos Chandras <[email protected]>
Signed-off-by Vicente Olivert Riera <[email protected]>

---
package/valgrind/Config.in | 3 ++-

1 files changed, 2 insertions(+), 1 deletions(-)
package/valgrind/Config.in +0 -0
index dacdd86..fd5649b 100644
@@ -1,7 +1,8 @@

config BR2_PACKAGE_VALGRIND

	bool "valgrind"
	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
package/valgrind/Config.in +2 -1
-		   BR2_cortex_a9 || BR2_powerpc
+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
Quoted 3 lines

help
Tool for debugging and profiling Linux programs.

Did you test this on target?
Do you have any idea why it wasn't enabled for mips before?

Thanks,
Thomas

author
#2 lore raw

PATCH 1/1 valgrind: Add support for MIPS architecture

Quoted 9 lines · Thomas De Schampheleire

Hi Vicente,

Vicente Olivert Riera <[email protected]> schreef:

Quoted 6 lines
Reviewed-by Markos Chandras <[email protected]>
Signed-off-by Vicente Olivert Riera <[email protected]>

---
package/valgrind/Config.in | 3 ++-

1 files changed, 2 insertions(+), 1 deletions(-)
Quoted 16 lines
Quoted 11 lines
package/valgrind/Config.in +0 -0
index dacdd86..fd5649b 100644
@@ -1,7 +1,8 @@

config BR2_PACKAGE_VALGRIND

	bool "valgrind"
	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
package/valgrind/Config.in +2 -1
-		   BR2_cortex_a9 || BR2_powerpc
+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
Quoted 3 lines

help
Tool for debugging and profiling Linux programs.

Did you test this on target?

Not yet, but it should work.

Quoted 1 line

Do you have any idea why it wasn't enabled for mips before?

Valgrind added support for MIPS on it's last release, 3.9.0:

http://sourceforge.net/p/valgrind/mailman/valgrind-announce/thread/52738DEF.1070801 at acm.org/

But you already knew that. The following message is yours:

"One of the new features of Valgrind 3.9.0 is the addition of MIPS support. Maybe it would be good to enable Valgrind on these architectures. I'm adding Vincente and Markos in the Cc list, since they are our main MIPS contributors. They might probably be interested in doing this work, after testing on MIPS hardware."

Quoted 2 lines

Thanks,
Thomas

Signature · 1 line
Vincent
#3 lore raw

PATCH 1/1 valgrind: Add support for MIPS architecture

Vicente Olivert Riera <[email protected]> schreef:

Quoted 35 lines · Thomas De Schampheleire
Quoted 9 lines

Hi Vicente,

Vicente Olivert Riera <[email protected]> schreef:

Quoted 6 lines
Reviewed-by Markos Chandras <[email protected]>
Signed-off-by Vicente Olivert Riera <[email protected]>

---
package/valgrind/Config.in | 3 ++-

1 files changed, 2 insertions(+), 1 deletions(-)
Quoted 16 lines
Quoted 11 lines
package/valgrind/Config.in +0 -0
index dacdd86..fd5649b 100644
@@ -1,7 +1,8 @@

config BR2_PACKAGE_VALGRIND

	bool "valgrind"
	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
package/valgrind/Config.in +2 -1
-		   BR2_cortex_a9 || BR2_powerpc
+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
Quoted 3 lines

help
Tool for debugging and profiling Linux programs.

Did you test this on target?

Not yet, but it should work.

Quoted 1 line

Do you have any idea why it wasn't enabled for mips before?

Valgrind added support for MIPS on it's last release, 3.9.0:

http://sourceforge.net/p/valgrind/mailman/valgrind-announce/thread/52738DEF.1070801 at acm.org/

Quoted 7 lines

But you already knew that. The following message is yours:

"One of the new features of Valgrind 3.9.0 is the addition of MIPS support. Maybe it would be good to enable Valgrind on these architectures. I'm adding Vincente and Markos in the Cc list, since they are our main MIPS contributors. They might probably be interested in doing this work, after testing on MIPS hardware."

I think you are confusing the two Thomas'es, but that's ok :-).

Thanks for your explanation...

Best regards,
Thomas

Applied
#4 lore raw

PATCH 1/1 valgrind: Add support for MIPS architecture

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 5 lines · Vicente Olivert Riera
Reviewed-by Markos Chandras <[email protected]>
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/valgrind/Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/1 valgrind: Add support for MIPS architecture

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 11 lines · Vicente Olivert Riera
Reviewed-by Markos Chandras <[email protected]>
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/valgrind/Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
package/valgrind/Config.in +0 -0
index dacdd86..fd5649b 100644

package/valgrind/Config.in line 7

Quoted 8 lines
package/valgrind/Config.in +2 -1
@@ -1,7 +1,8 @@
 config BR2_PACKAGE_VALGRIND
 	bool "valgrind"
 	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
-		   BR2_cortex_a9 || BR2_powerpc
+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
 	help
 	  Tool for debugging and profiling Linux programs.

This breaks the build on MIPS64:

http://autobuild.buildroot.org/results/213/21352bcbe1b309fef0f996c275cdfcda08619d96/build-end.log

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#6 lore raw

PATCH 1/1 valgrind: Add support for MIPS architecture

Quoted 25 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 11 lines · Vicente Olivert Riera
Reviewed-by Markos Chandras <[email protected]>
Signed-off-by Vicente Olivert Riera <[email protected]>
---
  package/valgrind/Config.in |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
package/valgrind/Config.in +0 -0
index dacdd86..fd5649b 100644

package/valgrind/Config.in line 7

Quoted 8 lines
package/valgrind/Config.in +2 -1
@@ -1,7 +1,8 @@
  config BR2_PACKAGE_VALGRIND
  	bool "valgrind"
  	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
-		   BR2_cortex_a9 || BR2_powerpc
+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
  	help
  	  Tool for debugging and profiling Linux programs.

This breaks the build on MIPS64:

Quoted 4 lines
   http://autobuild.buildroot.org/results/213/21352bcbe1b309fef0f996c275cdfcda08619d96/build-end.log

Thomas

Yeah, I sent a patch to upstream few weeks ago, and it was applied. I will send it to BR today.

Thanks for reminding me this problem.

Signature · 1 line
Vincent