drm/i915: Match debugfs interface name to new RPS naming

PATCH Superseded [email protected] 3 participants 5 messages Mar 30, 2014 – Mar 31, 2014

Subsystems (2)

DRM drivers Intel i915

lore

Share & tools

lore

[email protected]

author

2014-03-30 08:21 UTC #0 lore raw

PATCH 1/1 drm/i915: Match debugfs interface name to new RPS naming

From: Deepak S <[email protected]>

Let's change the i915_cur_delayinfo to i915_cur_freqinfo to be in sync with new RPS naming convention.

Signed-off-by Deepak S <[email protected]>

---
 drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/i915/i915_debugfs.c +2 -2

index 049dcb5..3cfc35c 100644
@@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
 	return 0;
 }
 
-static int i915_cur_delayinfo(struct seq_file *m, void *unused)
+static int i915_cur_freqinfo(struct seq_file *m, void *unused)
 {
 	struct drm_info_node *node = (struct drm_info_node *) m->private;
 	struct drm_device *dev = node->minor->dev;

@@ -3772,7 +3772,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
 	{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
 	{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
 	{"i915_rstdby_delays", i915_rstdby_delays, 0},
-	{"i915_cur_delayinfo", i915_cur_delayinfo, 0},
+	{"i915_cur_freqinfo", i915_cur_freqinfo, 0},
 	{"i915_delayfreq_table", i915_delayfreq_table, 0},
 	{"i915_inttoext_table", i915_inttoext_table, 0},
 	{"i915_drpc_info", i915_drpc_info, 0},

Signature · 1 line

1.8.5.2

Ben Widawsky

2014-03-30 19:19 UTC #1 lore raw

Quoted 6 lines · On Sun, Mar 30, 2014 at 01:51:30PM +0530, [email protected] wrote:

From: Deepak S <[email protected]>
Let's change the i915_cur_delayinfo to i915_cur_freqinfo to be in sync with new RPS naming convention.
Signed-off-by Deepak S <[email protected]>

If we're doing a rename, we might as well do a rename. The function does plenty more than "cur"

my vote:
i915_frequency_info

Quoted 29 lines

---
 drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/i915/i915_debugfs.c +2 -2

index 049dcb5..3cfc35c 100644
@@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
 	return 0;
 }
 
-static int i915_cur_delayinfo(struct seq_file *m, void *unused)
+static int i915_cur_freqinfo(struct seq_file *m, void *unused)
 {
 	struct drm_info_node *node = (struct drm_info_node *) m->private;
 	struct drm_device *dev = node->minor->dev;

@@ -3772,7 +3772,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
 	{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
 	{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
 	{"i915_rstdby_delays", i915_rstdby_delays, 0},
-	{"i915_cur_delayinfo", i915_cur_delayinfo, 0},
+	{"i915_cur_freqinfo", i915_cur_freqinfo, 0},
 	{"i915_delayfreq_table", i915_delayfreq_table, 0},
 	{"i915_inttoext_table", i915_inttoext_table, 0},
 	{"i915_drpc_info", i915_drpc_info, 0},

Signature · 1 line

1.8.5.2

Signature · 1 line

Ben Widawsky, Intel Open Source Technology Center

[email protected]

author

2014-03-31 06:00 UTC #2 lore raw

PATCH v2 1/1 drm/i915: Match debugfs interface name to new RPS naming

In reply to [email protected]

From: Deepak S <[email protected]>

Let's change the i915_cur_delayinfo to i915_frequency_info to be in sync with new RPS naming convention.

v2: Add "i915_frequency_info" as debugfs interface name (Ben)

Signed-off-by Deepak S <[email protected]>

---
 drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/i915/i915_debugfs.c +2 -2

index 1a35215..e5d9a902 100644
@@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
 	return 0;
 }
 
-static int i915_cur_delayinfo(struct seq_file *m, void *unused)
+static int i915_frequency_info(struct seq_file *m, void *unused)
 {
 	struct drm_info_node *node = (struct drm_info_node *) m->private;
 	struct drm_device *dev = node->minor->dev;

@@ -3786,7 +3786,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
 	{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
 	{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
 	{"i915_rstdby_delays", i915_rstdby_delays, 0},
-	{"i915_cur_delayinfo", i915_cur_delayinfo, 0},
+	{"i915_frequency_info", i915_frequency_info, 0},
 	{"i915_delayfreq_table", i915_delayfreq_table, 0},
 	{"i915_inttoext_table", i915_inttoext_table, 0},
 	{"i915_drpc_info", i915_drpc_info, 0},

Signature · 1 line

1.9.1

Daniel Vetter

2014-03-31 08:43 UTC #3 lore raw

Quoted 8 lines · On Mon, Mar 31, 2014 at 11:30:02AM +0530, [email protected] wrote:

From: Deepak S <[email protected]>
Let's change the i915_cur_delayinfo to i915_frequency_info to be in sync with new RPS naming convention.
v2: Add "i915_frequency_info" as debugfs interface name (Ben)
Signed-off-by Deepak S <[email protected]>

Yeah, I always need to do a grep .* CAGF to find this file ;-) Queued for -next, thanks for the patch.
-Daniel

Quoted 33 lines

---
 drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/i915/i915_debugfs.c +2 -2

index 1a35215..e5d9a902 100644
@@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
 	return 0;
 }
 
-static int i915_cur_delayinfo(struct seq_file *m, void *unused)
+static int i915_frequency_info(struct seq_file *m, void *unused)
 {
 	struct drm_info_node *node = (struct drm_info_node *) m->private;
 	struct drm_device *dev = node->minor->dev;

@@ -3786,7 +3786,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
 	{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
 	{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
 	{"i915_rstdby_delays", i915_rstdby_delays, 0},
-	{"i915_cur_delayinfo", i915_cur_delayinfo, 0},
+	{"i915_frequency_info", i915_frequency_info, 0},
 	{"i915_delayfreq_table", i915_delayfreq_table, 0},
 	{"i915_inttoext_table", i915_inttoext_table, 0},
 	{"i915_drpc_info", i915_drpc_info, 0},

Signature · 6 lines

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

Ben Widawsky

Reviewed-by on v2 1/1

2014-03-31 18:09 UTC #4 lore raw

In reply to [email protected]

Quoted 8 lines · On Mon, Mar 31, 2014 at 11:30:02AM +0530, [email protected] wrote:

From: Deepak S <[email protected]>
Let's change the i915_cur_delayinfo to i915_frequency_info to be in sync with new RPS naming convention.
v2: Add "i915_frequency_info" as debugfs interface name (Ben)
Signed-off-by Deepak S <[email protected]>

Provided that nobody cares about debugfs as an ABI -

Reviewed-by Ben Widawsky <[email protected]>

Quoted 29 lines

---
 drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/gpu/drm/i915/i915_debugfs.c +2 -2

index 1a35215..e5d9a902 100644
@@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
 	return 0;
 }
 
-static int i915_cur_delayinfo(struct seq_file *m, void *unused)
+static int i915_frequency_info(struct seq_file *m, void *unused)
 {
 	struct drm_info_node *node = (struct drm_info_node *) m->private;
 	struct drm_device *dev = node->minor->dev;

@@ -3786,7 +3786,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
 	{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
 	{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
 	{"i915_rstdby_delays", i915_rstdby_delays, 0},
-	{"i915_cur_delayinfo", i915_cur_delayinfo, 0},
+	{"i915_frequency_info", i915_frequency_info, 0},
 	{"i915_delayfreq_table", i915_delayfreq_table, 0},
 	{"i915_inttoext_table", i915_inttoext_table, 0},
 	{"i915_drpc_info", i915_drpc_info, 0},

Signature · 1 line

1.9.1

Signature · 1 line

Ben Widawsky, Intel Open Source Technology Center