Skip to contentSkip to conversation

infozip: Add a host variant

PATCH New Maxime Hadjinlian 4 participants 8 messages Apr 1, 2014 – Apr 3, 2014

lore
Share & tools
lore

Maxime Hadjinlian

author
#0 lore raw

PATCH 1/2 infozip: Add a host variant

Adding a host variant to the package infozip.
It will be used by XBMC.

Signed-off-by Maxime Hadjinlian <[email protected]>
---
 package/infozip/infozip.mk | 13 +++++++++++++
 1 file changed, 13 insertions(+)
package/infozip/infozip.mk +13 -0
index 8e51224..9648b4f 100644
@@ -26,4 +26,17 @@ define INFOZIP_INSTALL_TARGET_CMDS
 		prefix=$(TARGET_DIR)/usr
 endef
 
+define HOST_INFOZIP_BUILD_CMDS
+	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) \
+		CFLAGS="$(HOST_CFLAGS) -I. -DUNIX" \
+		AS="$(HOST_CC) -c" \
+		-f unix/Makefile generic
+endef
+
+define HOST_INFOZIP_INSTALL_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install \
+		prefix=$(HOST_DIR)/usr
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 xbmc: Add missing host-infozip dependency

XBMC needs the zip command for the host to build.

Signed-off-by Maxime Hadjinlian <[email protected]>
---
 package/xbmc/xbmc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/xbmc/xbmc.mk +1 -1
index 9e346bd..59255a4 100644
@@ -12,7 +12,7 @@ XBMC_LICENSE_FILES = LICENSE.GPL
 # called TexturePacker. It is responsible to take all the images used in the
 # GUI and pack them in a blob.
 # http://wiki.xbmc.org/index.php?title=TexturePacker
-XBMC_DEPENDENCIES = host-gperf host-lzo host-sdl_image host-swig
+XBMC_DEPENDENCIES = host-gperf host-infozip host-lzo host-sdl_image host-swig
 XBMC_DEPENDENCIES += boost bzip2 expat flac fontconfig freetype jasper jpeg \
 	libass libcdio libcurl libegl libfribidi libgcrypt libgles libmad libmodplug libmpeg2 \
 	libogg libplist libpng libsamplerate libungif libvorbis libxml2 lzo ncurses \
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 xbmc: Add missing host-infozip dependency

On 2014-04-02 00:24 +0200, Maxime Hadjinlian spake thusly:

Quoted 3 lines

XBMC needs the zip command for the host to build.

Signed-off-by Maxime Hadjinlian <[email protected]>
Reported-by "Yann E. MORIN" <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

Ditto for a test-build: tomorrow.

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/xbmc/xbmc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/xbmc/xbmc.mk +1 -1
index 9e346bd..59255a4 100644
@@ -12,7 +12,7 @@ XBMC_LICENSE_FILES = LICENSE.GPL
 # called TexturePacker. It is responsible to take all the images used in the
 # GUI and pack them in a blob.
 # http://wiki.xbmc.org/index.php?title=TexturePacker
-XBMC_DEPENDENCIES = host-gperf host-lzo host-sdl_image host-swig
+XBMC_DEPENDENCIES = host-gperf host-infozip host-lzo host-sdl_image host-swig
 XBMC_DEPENDENCIES += boost bzip2 expat flac fontconfig freetype jasper jpeg \
 	libass libcdio libcurl libegl libfribidi libgcrypt libgles libmad libmodplug libmpeg2 \
 	libogg libplist libpng libsamplerate libungif libvorbis libxml2 lzo ncurses \
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#4 lore raw

PATCH 2/2 xbmc: Add missing host-infozip dependency

In reply to Maxime Hadjinlian

Dear Maxime Hadjinlian,

Quoted 6 lines · Maxime Hadjinlian

XBMC needs the zip command for the host to build.

Signed-off-by Maxime Hadjinlian <[email protected]>
---
 package/xbmc/xbmc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/2 infozip: Add a host variant

In reply to Maxime Hadjinlian

Maxime, All,

On 2014-04-02 00:24 +0200, Maxime Hadjinlian spake thusly:

Quoted 4 lines

Adding a host variant to the package infozip.
It will be used by XBMC.

Signed-off-by Maxime Hadjinlian <[email protected]>
Reviewed-by "Yann E. MORIN" <[email protected]>

It's a bit too late for me here to run a test, but I'll try to do a build tomorrow.

Regards,
Yann E. MORIN.

Quoted 33 lines
---
 package/infozip/infozip.mk | 13 +++++++++++++
 1 file changed, 13 insertions(+)
package/infozip/infozip.mk +13 -0
index 8e51224..9648b4f 100644
@@ -26,4 +26,17 @@ define INFOZIP_INSTALL_TARGET_CMDS
 		prefix=$(TARGET_DIR)/usr
 endef
 
+define HOST_INFOZIP_BUILD_CMDS
+	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) \
+		CFLAGS="$(HOST_CFLAGS) -I. -DUNIX" \
+		AS="$(HOST_CC) -c" \
+		-f unix/Makefile generic
+endef
+
+define HOST_INFOZIP_INSTALL_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install \
+		prefix=$(HOST_DIR)/usr
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 1/2 infozip: Add a host variant

In reply to Maxime Hadjinlian

Dear Maxime Hadjinlian,

package/infozip/infozip.mk define INFOZIP_INSTALL_TARGET_CMDS · line 37

Quoted 2 lines · Maxime Hadjinlian
package/infozip/infozip.mk +2 -0
+define HOST_INFOZIP_INSTALL_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) -f unix/Makefile install \

You should have used HOST_CONFIGURE_OPTS here.

Committed with this fixed.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com