ARM: dts: imx27-phytec-phycore-rdk: Add display control signal definitions
Subsystems (3)
PATCH 1/1 ARM: dts: imx27-phytec-phycore-rdk: Add display control signal definitions
This patch adds display control signal definitions. These fields are not used in the driver yet, but will be used for reference to indicate the polarity of the signals.
--- arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx27-phytec-phycore-rdk.dts +4 -0
@@ -30,6 +30,10 @@ vback-porch = <7>; vsync-len = <1>; vfront-porch = <9>; + pixelclk-active = <1>; + hsync-active = <1>; + vsync-active = <1>; + de-active = <0>; }; }; };
Signature · 1 line
1.8.3.2
PATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
This patch adds support for Digi ConnectCore? i.MX51/Wi-i.MX51 SOM and basic support for the ConnectCore for i.MX51 JumpStart Kit.
--- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx51-digi-connectcore-jsk.dts | 108 ++++++ arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi | 389 ++++++++++++++++++++++ 3 files changed, 498 insertions(+) create mode 100644 arch/arm/boot/dts/imx51-digi-connectcore-jsk.dts create mode 100644 arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
arch/arm/boot/dts/Makefile +1 -0
@@ -164,6 +164,7 @@ dtb-$(CONFIG_ARCH_MXC) += \ imx51-apf51.dtb \ imx51-apf51dev.dtb \ imx51-babbage.dtb \ + imx51-digi-connectcore-jsk.dtb \ imx51-eukrea-mbimxsd51-baseboard.dtb \ imx53-ard.dtb \ imx53-m53evk.dtb \
arch/arm/boot/dts/imx51-digi-connectcore-jsk.dts new file +108 -0
108 lines not on this page · raw message
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +389 -0
389 lines not on this page · raw message
Signature · 1 line
1.8.3.2
PATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
Quoted 5 lines · Alexander Shiyan
This patch adds support for Digi ConnectCore? i.MX51/Wi-i.MX51 SOM and basic support for the ConnectCore for i.MX51 JumpStart Kit.
Signed-off-by Alexander Shiyan <[email protected]>---
...
arch/arm/boot/dts/imx51-digi-connectcore-jsk.dts line 17
Quoted 6 lines
arch/arm/boot/dts/imx51-digi-connectcore-jsk.dts new file +6
-0+#include "imx51-digi-connectcore-som.dtsi" + +/ { + model = "Digi ConnectCore CC(W)-MX51 JSK"; + compatible = "digi,connectcore-ccxmx51-jsk", + "digi,connectcore-ccxmx51-som", "fsl,imx51";
You may want to send another patch to DT maintainers to add 'digi' into Documentation/devicetree/bindings/vendor-prefixes.txt.
Quoted 5 lines
arch/arm/boot/dts/imx51-digi-connectcore-jsk.dts new file +5
-0+ + chosen { + linux,stdout-path = &uart1; + }; +};
...
Quoted 9 lines
+&nfc {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +8
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_nfc>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; + #address-cells = <1>; + #size-cells = <1>; + status = "okay";
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 210
Quoted 10 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +10
-0+ + partition at 0 { + label = "boot"; + reg = <0x00000 0x80000>; + }; + + partition at 1 { + label = "env"; + reg = <0x80000 0x40000>; + };
@Sascha, does the argument that we shouldn't have partition table in the mainline dtb still stands?
Quoted 4 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +4
-0+}; + +&usbotg { + phy_type = "utmi_wide";
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 224
Quoted 10 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +10
-0+ disable-over-current; + /* Device role is not known, keep status disabled */ +}; + +&weim { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_weim>; + status = "okay"; + + lan9221: lan9221 at ce000000 {
How does 'ce000000' in the node name comes?
Shawn
Quoted 19 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +19
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_lan9221>; + compatible = "smsc,lan9221", "smsc,lan9115"; + reg = <5 0x00000000 0x1000>; + fsl,weim-cs-timing = < + 0x00420081 0x00000000 + 0x32260000 0x00000000 + 0x72080f00 0x00000000 + >; + clocks = <&clks IMX5_CLK_DUMMY>; + interrupt-parent = <&gpio1>; + interrupts = <9 IRQ_TYPE_LEVEL_LOW>; + phy-mode = "mii"; + reg-io-width = <2>; + smsc,irq-push-pull; + vdd33a-supply = <&gpo2_reg>; + vddvario-supply = <&gpo2_reg>; + }; +};
Re: [PATCH] ARM i.MX51: Add Digi ConnectCore devicetree
Wed, 2 Apr 2014 19:39:35 +0800 ?? Shawn Guo <[email protected]>:
Quoted 5 lines · Alexander Shiyan
Quoted 4 lines
This patch adds support for Digi ConnectCore? i.MX51/Wi-i.MX51 SOM and basic support for the ConnectCore for i.MX51 JumpStart Kit.
Signed-off-by Alexander Shiyan <[email protected]>
...
Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 224
Quoted 6 lines
+&weim {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_weim>; + status = "okay"; + + lan9221: lan9221 at ce000000 {How does '
ce000000' in the node name comes?
This is a WEIM CS5 start address.
---
PATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
Quoted 16 lines · Alexander Shiyan
Wed, 2 Apr 2014 19:39:35 +0800 ?? Shawn Guo <[email protected]>:
Quoted 5 lines · Alexander Shiyan
Quoted 4 lines
This patch adds support for Digi ConnectCore? i.MX51/Wi-i.MX51 SOM and basic support for the ConnectCore for i.MX51 JumpStart Kit.
Signed-off-by Alexander Shiyan <[email protected]>...
Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 224
Quoted 6 lines
+&weim {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_weim>; + status = "okay"; + + lan9221: lan9221 at ce000000 {How does '
ce000000' in the node name comes?
Quoted 1 line
This is a WEIM CS5 start address.
Hmm, shouldn't the unit-address come from the 'reg' property of the node somehow?
Shawn
Re: [PATCH] ARM i.MX51: Add Digi ConnectCore devicetree
Wed, 2 Apr 2014 19:56:14 +0800 ?? Shawn Guo <[email protected]>:
Quoted 17 lines · Alexander Shiyan
Quoted 16 lines
Wed, 2 Apr 2014 19:39:35 +0800 ?? Shawn Guo <[email protected]>:
Quoted 5 lines · Alexander Shiyan
Quoted 4 lines
This patch adds support for Digi ConnectCore? i.MX51/Wi-i.MX51 SOM and basic support for the ConnectCore for i.MX51 JumpStart Kit.
Signed-off-by Alexander Shiyan <[email protected]>...
Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 224
Quoted 6 lines
+&weim {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_weim>; + status = "okay"; + + lan9221: lan9221 at ce000000 {How does '
ce000000' in the node name comes?
Quoted 4 lines
Quoted 1 line
This is a WEIM CS5 start address.
Hmm, shouldn't the unit-address come from the 'reg' property of the node somehow?
I'm not sure. Here is the real physical address of the device, in the case of using an address from the "reg", we get zero address.
Just imagine, that we have a second LAN chip on the start of CS4. Two identical devices?
---
PATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
Quoted 11 lines · Alexander Shiyan
Quoted 11 lines
Quoted 10 lines
Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 224
Quoted 6 lines
+&weim {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_weim>; + status = "okay"; + + lan9221: lan9221 at ce000000 {How does '
ce000000' in the node name comes?This is a WEIM CS5 start address.
Quoted 8 lines
Quoted 2 lines
Hmm, shouldn't the unit-address come from the 'reg' property of the node somehow?
I'm not sure. Here is the real physical address of the device, in the case of using an address from the "reg", we get zero address.
Just imagine, that we have a second LAN chip on the start of CS4. Two identical devices?
The node name should be 'lan9221 at 5,0' and 'lan9221 at 4,0' respectively.
Shawn
Re: [PATCH] ARM i.MX51: Add Digi ConnectCore devicetree
Wed, 2 Apr 2014 20:47:11 +0800 ?? Shawn Guo <[email protected]>:
Quoted 15 lines · Alexander Shiyan
Quoted 14 lines
Quoted 13 lines
Quoted 10 lines
Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 224
Quoted 6 lines
+&weim {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_weim>; + status = "okay"; + + lan9221: lan9221 at ce000000 {How does '
ce000000' in the node name comes?This is a WEIM CS5 start address.
Hmm, shouldn't the unit-address come from the 'reg' property of the node somehow?
Quoted 7 lines
Quoted 5 lines
I'm not sure. Here is the real physical address of the device, in the case of using an address from the "reg", we get zero address.
Just imagine, that we have a second LAN chip on the start of CS4. Two identical devices?
The node name should be 'lan9221 at 5,0' and 'lan9221 at 4,0' respectively.
Well, we can do so. You want me to update existing DTS for WEIM nodes?
---
PATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
Quoted 19 lines · Alexander Shiyan
Wed, 2 Apr 2014 20:47:11 +0800 ?? Shawn Guo <[email protected]>:
Quoted 18 lines · Alexander Shiyan
Quoted 17 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 6 lines
+&weim {
(quoted diff) +5
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_weim>; + status = "okay"; + + lan9221: lan9221 at ce000000 {How does '
ce000000' in the node name comes?Quoted 4 lines
Quoted 1 line
This is a WEIM CS5 start address.
Hmm, shouldn't the unit-address come from the 'reg' property of the node somehow?
I'm not sure. Here is the real physical address of the device, in the case of using an address from the "reg", we get zero address.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Just imagine, that we have a second LAN chip on the start of CS4. Two identical devices?
The node name should be 'lan9221 at 5,0' and 'lan9221 at 4,0' respectively.
Well, we can do so. You want me to update existing DTS for WEIM nodes?
Yes, please.
Shawn
Sascha Hauer
maintainerPATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
In reply to Shawn GuoQuoted 15 lines · Shawn Guo
Quoted 14 lines · Alexander Shiyan
+&nfc {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +13
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_nfc>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; + #address-cells = <1>; + #size-cells = <1>; + status = "okay"; + + partition at 0 { + label = "boot"; + reg = <0x00000 0x80000>; + };
Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 210
Quoted 5 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ + partition at 1 { + label = "env"; + reg = <0x80000 0x40000>; + };@Sascha, does the argument that we shouldn't have partition table in the mainline dtb still stands?
Yes, I still think the partitions shouldn't be in the Linux dts files.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
[adding Nicolas to Cc]
Quoted 25 lines · Sascha Hauer
Quoted 15 lines · Shawn Guo
Quoted 14 lines · Alexander Shiyan
+&nfc {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +13
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_nfc>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; + #address-cells = <1>; + #size-cells = <1>; + status = "okay"; + + partition at 0 { + label = "boot"; + reg = <0x00000 0x80000>; + };Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 210
Quoted 5 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ + partition at 1 { + label = "env"; + reg = <0x80000 0x40000>; + };@Sascha, does the argument that we shouldn't have partition table in the mainline dtb still stands?
Quoted 1 line
Yes, I still think the partitions shouldn't be in the Linux dts files.
The dtb files for the Atmel Xplained board also has a partition definition, so the same comment applies there, too.
Besides being no hardware description, this implies a certain way of using the system; for example, with the "kernel" plus "rootfs" partitions, it suggests that you can't have the kernel in the standard root filesystem (which is possible with barebox and the freedesktop.org bootloader specification).
rsc
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
Am 02.04.2014 19:44, schrieb Robert Schwebel:
Quoted 30 lines
[adding Nicolas to Cc]
Quoted 25 lines · Sascha Hauer
Quoted 15 lines · Shawn Guo
Quoted 14 lines · Alexander Shiyan
+&nfc {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +13
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_nfc>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; + #address-cells = <1>; + #size-cells = <1>; + status = "okay"; + + partition at 0 { + label = "boot"; + reg = <0x00000 0x80000>; + };Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 210
Quoted 5 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ + partition at 1 { + label = "env"; + reg = <0x80000 0x40000>; + };@Sascha, does the argument that we shouldn't have partition table in the mainline dtb still stands?
Quoted 1 line
Yes, I still think the partitions shouldn't be in the Linux dts files.
Quoted 8 lines
The dtb files for the Atmel Xplained board also has a partition definition, so the same comment applies there, too.
Besides being no hardware description, this implies a certain way of using the system; for example, with the "kernel" plus "rootfs" partitions, it suggests that you can't have the kernel in the standard root filesystem (which is possible with barebox and the freedesktop.org bootloader specification).
Just out of curiosity, because I never got a good answer to this question (but maybe I asked the wrong way):
If not in the dts, where should the partition table be put instead, then?
Best regards
Dirk
Re: [PATCH] ARM i.MX51: Add Digi ConnectCore devicetree
Wed, 02 Apr 2014 19:59:17 +0200 ?? Dirk Behme <[email protected]>:
Quoted 40 lines
Am 02.04.2014 19:44, schrieb Robert Schwebel:
Quoted 30 lines
[adding Nicolas to Cc]
Quoted 25 lines · Sascha Hauer
Quoted 15 lines · Shawn Guo
Quoted 14 lines · Alexander Shiyan
+&nfc {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +13
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_nfc>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; + #address-cells = <1>; + #size-cells = <1>; + status = "okay"; + + partition at 0 { + label = "boot"; + reg = <0x00000 0x80000>; + };Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 210
Quoted 5 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ + partition at 1 { + label = "env"; + reg = <0x80000 0x40000>; + };@Sascha, does the argument that we shouldn't have partition table in the mainline dtb still stands?
Quoted 1 line
Yes, I still think the partitions shouldn't be in the Linux dts files.
Quoted 8 lines
The dtb files for the Atmel Xplained board also has a partition definition, so the same comment applies there, too.
Besides being no hardware description, this implies a certain way of using the system; for example, with the "kernel" plus "rootfs" partitions, it suggests that you can't have the kernel in the standard root filesystem (which is possible with barebox and the freedesktop.org bootloader specification).
Quoted 4 lines
Just out of curiosity, because I never got a good answer to this question (but maybe I asked the wrong way):
If not in the dts, where should the partition table be put instead, then?
It can be passed by kernel command line.
---
Sascha Hauer
maintainerPATCH 1/1 ARM i.MX51: Add Digi ConnectCore devicetree
In reply to Dirk BehmeQuoted 40 lines · Dirk Behme
Am 02.04.2014 19:44, schrieb Robert Schwebel:
Quoted 30 lines
[adding Nicolas to Cc]
Quoted 25 lines · Sascha Hauer
Quoted 15 lines · Shawn Guo
Quoted 14 lines · Alexander Shiyan
+&nfc {
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +13
-0+ pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_nfc>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-on-flash-bbt; + #address-cells = <1>; + #size-cells = <1>; + status = "okay"; + + partition at 0 { + label = "boot"; + reg = <0x00000 0x80000>; + };Quoted 8 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi line 210
Quoted 5 lines
arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi new file +5
-0+ + partition at 1 { + label = "env"; + reg = <0x80000 0x40000>; + };@Sascha, does the argument that we shouldn't have partition table in the mainline dtb still stands?
Quoted 1 line
Yes, I still think the partitions shouldn't be in the Linux dts files.
Quoted 8 lines
The dtb files for the Atmel Xplained board also has a partition definition, so the same comment applies there, too.
Besides being no hardware description, this implies a certain way of using the system; for example, with the "kernel" plus "rootfs" partitions, it suggests that you can't have the kernel in the standard root filesystem (which is possible with barebox and the freedesktop.org bootloader specification).
Quoted 4 lines
Just out of curiosity, because I never got a good answer to this question (but maybe I asked the wrong way):
If not in the dts, where should the partition table be put instead, then?
I think the bootloader should provide it. The bootloader has the chance to fill in the correct data from its own configuration (which can be a devicetree aswell). We should at least make sure that the bootloader and the kernel use a consistent partition table.
(Which reminds me that barebox also doesn't do this correctly atm)
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Shawn Guo
AppliedPATCH 1/1 ARM: dts: imx27-phytec-phycore-rdk: Add display control signal definitions
In reply to Alexander ShiyanQuoted 5 lines · Alexander Shiyan
This patch adds display control signal definitions. These fields are not used in the driver yet, but will be used for reference to indicate the polarity of the signals.
Signed-off-by Alexander Shiyan <[email protected]>
Applied, thanks.