ext4: Note the error in ext4_end_bio()
PATCH 1/1 ext4: Note the error in ext4_end_bio()
ext4_end_bio() currently throws away the error that it receives. Chances are this is part of a spate of errors, one of which will end up getting the error returned to userspace somehow, but we shouldn't take that risk. Also print out the errno to aid in debug.
--- fs/ext4/page-io.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
fs/ext4/page-io.c +3 -2
@@ -308,13 +308,14 @@ static void ext4_end_bio(struct bio *bio, int error)if (error) {struct inode *inode = io_end->inode; -ext4_warning (inode->i_sb,"I/O error writing to inode %lu " +ext4_warning (inode->i_sb,"I/O error %d writing to inode %lu " "(offset %llu size %ld starting block %llu)" , - inode->i_ino, + error, inode->i_ino, (unsigned long long ) io_end->offset, (long ) io_end->size, (unsigned long long ) bi_sector >> (inode->i_blkbits -9 )); +mapping_set_error (inode->i_mapping, error); }if (io_end->flag &EXT4_IO_END_UNWRITTEN ) {
Signature · 1 line
1.9.0
Theodore Ts'o
maintainerQuoted 7 lines · Matthew Wilcox
ext4_end_bio()currently throws away the error that it receives. Chances are this is part of a spate of errors, one of which will end up getting the error returned to userspace somehow, but we shouldn't take that risk. Also print out the errno to aid in debug.Signed-off-by Matthew Wilcox <[email protected]>
Thanks, looks good. I'm currently doing test runs for the merge window, so I'll pull this in a few days. This is a legitimate stable-worthy bug-fix, so I'll try to push it to Linus in the second round pull request for bug fix and regression fixes, sometime in rc3 or rc4.
Cheers,
- Ted
Quoted 5 lines · Matthew Wilcox
ext4_end_bio()currently throws away the error that it receives. Chances are this is part of a spate of errors, one of which will end up getting the error returned to userspace somehow, but we shouldn't take that risk. Also print out the errno to aid in debug.
The patch looks good. You can add:
Honza
Quoted 34 lines
Signed-off-by Matthew Wilcox <[email protected]>--- fs/ext4/page-io.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)fs/ext4/page-io.c +3
-2@@ -308,13 +308,14 @@ static void ext4_end_bio(struct bio *bio, int error)if (error) {struct inode *inode = io_end->inode; -ext4_warning (inode->i_sb,"I/O error writing to inode %lu " +ext4_warning (inode->i_sb,"I/O error %d writing to inode %lu " "(offset %llu size %ld starting block %llu)" , - inode->i_ino, + error, inode->i_ino, (unsigned long long ) io_end->offset, (long ) io_end->size, (unsigned long long ) bi_sector >> (inode->i_blkbits -9 )); +mapping_set_error (inode->i_mapping, error); }if (io_end->flag &EXT4_IO_END_UNWRITTEN ) {Signature · 6 lines
1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 7 lines · Matthew Wilcox
ext4_end_bio()currently throws away the error that it receives. Chances are this is part of a spate of errors, one of which will end up getting the error returned to userspace somehow, but we shouldn't take that risk. Also print out the errno to aid in debug.Signed-off-by Matthew Wilcox <[email protected]>
Thanks, applied.
- Ted