Skip to contentSkip to conversation

arm64/cqufreq Kconfig error with v3.14-3893-gc12e69c6aaf7

PATCH In review Josh Boyer 2 participants 4 messages Apr 2, 2014 – Apr 3, 2014 arm64

lore
Share & tools
lore

Josh Boyer

author
#0 lore raw

Hi All,

When running make listnewconfig/oldconfig on the config below with Linus' latest tree, I keep seeing this error message spit out:

drivers/cpufreq/Kconfig:57:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:65:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:74:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:83:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:95:warning: choice value used outside its choice group

At the moment I'm only seeing this on arm64 but I have no idea why. Does anyone else?

josh

#1 lore raw
Quoted 5 lines · Josh Boyer

Hi All,

When running make listnewconfig/oldconfig on the config below with Linus' latest tree, I keep seeing this error message spit out:

Quoted 8 lines

drivers/cpufreq/Kconfig:57:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:65:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:74:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:83:warning: choice value used outside its choice group drivers/cpufreq/Kconfig:95:warning: choice value used outside its choice group

At the moment I'm only seeing this on arm64 but I have no idea why. Does anyone else?

Hmm, there are two entries for this present in: arch/arm64/Kconfig

+source "drivers/cpufreq/Kconfig"

You can see that here in Linus's merge: 4dedde

Probably both Rafael and Catalin were carrying this change..

--
viresh

author
#2 lore raw

PATCH 1/1 arm64: Fix duplicated Kconfig entries again

Commit 74397174989e5f70 attempted to clean up the power management options for arm64, but when things were merged it didn't fully take effect. Fix it again.

---
 arch/arm64/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm64/Kconfig +0 -6
index 07aa3556952c..8033b9b8a2df 100644
@@ -321,12 +321,6 @@ menu "CPU Power Management"
 
 source "drivers/cpuidle/Kconfig"
 
-source "drivers/cpufreq/Kconfig"
-
-endmenu
-
-menu "Power management options"
-
 source "kernel/power/Kconfig"
 
 source "drivers/cpufreq/Kconfig"
Signature · 1 line
1.8.5.3
Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH] arm64: Fix duplicated Kconfig entries again

Quoted 16 lines · Josh Boyer

Commit 74397174989e5f70 attempted to clean up the power management options for arm64, but when things were merged it didn't fully take effect. Fix it again.

---
 arch/arm64/Kconfig | 6 ------
 1 file changed, 6 deletions(-)
arch/arm64/Kconfig +0 -0
index 07aa3556952c..8033b9b8a2df 100644
@@ -321,12 +321,6 @@ menu "CPU Power Management"
 
 source "drivers/cpuidle/Kconfig"

arch/arm64/Kconfig menu "CPU Power Management" · line 326

Quoted 10 lines
arch/arm64/Kconfig +0 -6
 
-source "drivers/cpufreq/Kconfig"
-
-endmenu
-
-menu "Power management options"
-
 source "kernel/power/Kconfig"
 
 source "drivers/cpufreq/Kconfig"