Skip to contentSkip to conversation

net: qlcnic: include irq.h for irq definitions

PATCH Applied Josh Boyer 2 participants 2 messages Apr 2, 2014 – Apr 3, 2014

Subsystems (3)
lore
Share & tools
lore

Josh Boyer

author
#0 lore raw

PATCH 1/1 net: qlcnic: include irq.h for irq definitions

The qlcnic driver fails to build on ARM with errors like:

In file included from drivers/net/ethernet/qlogic/qlcnic/qlcnic.h:36:0,
from drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c:8:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h:585:1: error: unknown type name 'irqreturn_t'
irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *);
^

Nothing in the driver is explicitly including the irq definitions, so we add an include of linux/irq.h to pick them up.

---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/qlogic/qlcnic/qlcnic.h +1 -0
index f19f81cde134..cbc897e6bb8f 100644
@@ -23,6 +23,7 @@
 #include <linux/ethtool.h>
 #include <linux/mii.h>
 #include <linux/timer.h>
+#include <linux/irq.h>
 
 #include <linux/vmalloc.h>
 
Signature · 1 line
1.8.5.3
maintainer Applied
#1 lore raw

From: Josh Boyer <[email protected]>
Date: Wed, 2 Apr 2014 11:25:47 -0400

Quoted 8 lines

The qlcnic driver fails to build on ARM with errors like:

In file included from drivers/net/ethernet/qlogic/qlcnic/qlcnic.h:36:0,
from drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c:8:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.h:585:1: error: unknown type name 'irqreturn_t'
irqreturn_t qlcnic_83xx_clear_legacy_intr(struct qlcnic_adapter *);
^

Quoted 4 lines

Nothing in the driver is explicitly including the irq definitions, so we add an include of linux/irq.h to pick them up.

Applied, thanks Josh.