Lasat: a couple off by one bugs in picvue_proc.c
Subsystems (2)
PATCH 1/1 Lasat: a couple off by one bugs in picvue_proc.c
These should be ">=" instead of ">" or we go past the end of the pvc_lines[] array.
Signed-off-by Dan Carpenter <[email protected]>
arch/mips/lasat/picvue_proc.c +2 -2
@@ -44,7 +44,7 @@ static int pvc_line_proc_show(struct seq_file *m, void *v) {int lineno = *(int *)m->private; -if (lineno <0 || lineno >PVC_NLINES ) { +if (lineno <0 || lineno >=PVC_NLINES ) {printk (KERN_WARNING "proc_read_line: invalid lineno %d\n" , lineno);return 0 ; }
@@ -68,7 +68,7 @@ static ssize_t pvc_line_proc_write(struct file *file, const char __user *buf,char kbuf[PVC_LINELEN ];size_t len; -BUG_ON (lineno <0 || lineno >PVC_NLINES ); +BUG_ON (lineno <0 || lineno >=PVC_NLINES ); len =min (count,sizeof (kbuf) -1 );if (copy_from_user (kbuf, buf, len))
These off by one bugs are still there in linux-next.
regards,
dan carpenter
Quoted 27 lines · Dan Carpenter
These should be ">=" instead of ">" or we go past the end of the pvc_lines[] array.
Signed-off-by Dan Carpenter <[email protected]>arch/mips/lasat/picvue_proc.c +2
-2@@ -44,7 +44,7 @@ static int pvc_line_proc_show(struct seq_file *m, void *v) {int lineno = *(int *)m->private; -if (lineno <0 || lineno >PVC_NLINES ) { +if (lineno <0 || lineno >=PVC_NLINES ) {printk (KERN_WARNING "proc_read_line: invalid lineno %d\n" , lineno);return 0 ; }@@ -68,7 +68,7 @@ static ssize_t pvc_line_proc_write(struct file *file, const char __user *buf,char kbuf[PVC_LINELEN ];size_t len; -BUG_ON (lineno <0 || lineno >PVC_NLINES ); +BUG_ON (lineno <0 || lineno >=PVC_NLINES ); len =min (count,sizeof (kbuf) -1 );if (copy_from_user (kbuf, buf, len))