Skip to contentSkip to conversation

sh: missing break statement

PATCH New Dan Carpenter 1 participant 1 message Apr 2, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh: missing break statement

SH_BREAKPOINT_READ doesn't work because of the missing break in this switch statement.

Fixes 09a072947791 ('sh: hw-breakpoints: Add preliminary support for SH-4A UBC.')
arch/sh/kernel/hw_breakpoint.c +1 -0
index f9173766..42d30ac 100644
@@ -160,6 +160,7 @@ int arch_bp_generic_fields(int sh_len, int sh_type,
 	switch (sh_type) {
 	case SH_BREAKPOINT_READ:
 		*gen_type = HW_BREAKPOINT_R;
+		break;
 	case SH_BREAKPOINT_WRITE:
 		*gen_type = HW_BREAKPOINT_W;
 		break;