Skip to contentSkip to conversation

pinctrl: capri: make Kconfig dependency more strict

PATCH New Uwe Kleine-König 3 participants 4 messages Apr 1, 2014 – Apr 10, 2014 Pin control

lore
Share & tools
lore

Uwe Kleine-König

author
#0 lore raw

PATCH 1/1 pinctrl: capri: make Kconfig dependency more strict

This driver is only useful on BCM281xx, so let the driver depend on ARCH_BCM_MOBILE but allow compile coverage testing.
The main benefit is that the driver isn't available to be selected for machines that don't have the matching hardware.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 drivers/pinctrl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/Kconfig +1 -1
index e49324032611..072749816cb4 100644
@@ -106,7 +106,7 @@ config PINCTRL_BCM2835
 
 config PINCTRL_CAPRI
 	bool "Broadcom Capri pinctrl driver"
-	depends on OF
+	depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
 	select PINMUX
 	select PINCONF
 	select GENERIC_PINCONF
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 pinctrl: capri: make Kconfig dependency more strict

Quoted 16 lines · Uwe Kleine-K?nig

This driver is only useful on BCM281xx, so let the driver depend on ARCH_BCM_MOBILE but allow compile coverage testing.
The main benefit is that the driver isn't available to be selected for machines that don't have the matching hardware.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
  drivers/pinctrl/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/Kconfig +0 -0
index e49324032611..072749816cb4 100644

drivers/pinctrl/Kconfig config PINCTRL_BCM2835 · line 112

Quoted 8 lines
drivers/pinctrl/Kconfig +1 -1
@@ -106,7 +106,7 @@ config PINCTRL_BCM2835
 
  config PINCTRL_CAPRI
  	bool "Broadcom Capri pinctrl driver"
-	depends on OF
+	depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
  	select PINMUX
  	select PINCONF
  	select GENERIC_PINCONF

Looks good. Just wondering how you've come across this driver (and PINCTRL_MSM8X74)?

Reviewed-by Sherman Yin <[email protected]>

Thanks,
Sherman

author
#2 lore raw

PATCH 1/1 pinctrl: capri: make Kconfig dependency more strict

Hello,

Quoted 17 lines · Sherman Yin
Quoted 16 lines · Uwe Kleine-K?nig

This driver is only useful on BCM281xx, so let the driver depend on ARCH_BCM_MOBILE but allow compile coverage testing.
The main benefit is that the driver isn't available to be selected for machines that don't have the matching hardware.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 drivers/pinctrl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/Kconfig +0 -0
index e49324032611..072749816cb4 100644
@@ -106,7 +106,7 @@ config PINCTRL_BCM2835
Quoted 11 lines

drivers/pinctrl/Kconfig config PINCTRL_BCM2835 · line 112

Quoted 8 lines
drivers/pinctrl/Kconfig +1 -1
 config PINCTRL_CAPRI
 	bool "Broadcom Capri pinctrl driver"
-	depends on OF
+	depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
 	select PINMUX
 	select PINCONF
 	select GENERIC_PINCONF

Looks good. Just wondering how you've come across this driver (and PINCTRL_MSM8X74)?

Well, I was annoyed by being asked if I want to enable them for my efm32 machine during make oldconfig after updating the kernel. :-)

Quoted 1 line
Reviewed-by Sherman Yin <[email protected]>

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#3 lore raw

PATCH 1/1 pinctrl: capri: make Kconfig dependency more strict

In reply to Uwe Kleine-König
Quoted 6 lines · Uwe Kleine-K?nig

This driver is only useful on BCM281xx, so let the driver depend on ARCH_BCM_MOBILE but allow compile coverage testing.
The main benefit is that the driver isn't available to be selected for machines that don't have the matching hardware.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

Sherman is renaming this driver so this patch does not apply.

Please resubmit after the rename is upstream or something.

Yours,
Linus Walleij