Start the deprecation process for generic board
PATCH 1/1 Start the deprecation process for generic board
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
---
common/main.c | 6 ++ doc/README.generic-board | 189 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 195 insertions(+) create mode 100644 doc/README.generic-board
common/main.c +6 -0
@@ -427,6 +427,12 @@ void main_loop(void)bootstage_mark_name (BOOTSTAGE_ID_MAIN_LOOP ,"main_loop" ); +#ifndef CONFIG_SYS_GENERIC_BOARD +puts ("Warning: Your board does not use generic board. Please read\n" ); +puts ("doc/README.generic-board and take action. Boards not\n" ); +puts ("upgraded by the late 2014 may break or be removed.\n" ); +#endif +#ifdef CONFIG_MODEM_SUPPORT debug ("DEBUG: main_loop: do_mdm_init=%d\n" , do_mdm_init);if (do_mdm_init) {
doc/README.generic-board new file +189 -0
189 lines not on this page · raw message
Signature · 1 line
1.9.1.423.g4596e3a
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140328/5badf13f/attachment.pgp>
Quoted 8 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even worse, all boards now generate this warning and I'm worried that this will cause the more attentive maintainers to take action and produce fast fixes which won't receive sufficient testing until release is out.
I seriously disagree with applying the patch for current release.
Best regards,
Marek Vasut
Hi Marek,
Quoted 18 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even
worse, all boards now generate this warning and I'm worried that this will cause
the more attentive maintainers to take action and produce fast fixes which won't
receive sufficient testing until release is out.
Quoted 2 lines
I seriously disagree with applying the patch for current release.
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
Regards,
Simon
Quoted 23 lines · Simon Glass
Hi Marek,
Quoted 18 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even
worse, all boards now generate this warning and I'm worried that this will cause
the more attentive maintainers to take action and produce fast fixes which won't
receive sufficient testing until release is out.Quoted 1 line
I seriously disagree with applying the patch for current release.
Quoted 7 lines
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
I did fix my boards (m28evk, m53evk) and there were no issues. PXA will need to wait a bit after I'm done with higher-prio stuff.
What I find really unfortunate is that this went in during rc3 and made all boards spew warning.
Best regards,
Marek Vasut
Quoted 25 lines · Simon Glass
Hi Marek,
Quoted 18 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even
worse, all boards now generate this warning and I'm worried that this will cause
the more attentive maintainers to take action and produce fast fixes which won't
receive sufficient testing until release is out.Quoted 2 lines
I seriously disagree with applying the patch for current release.
Quoted 7 lines
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
So, Marek and I were discussing this on IRC as well. Given about a year and nothing converted (except for new things) I opted for the noisier approach. It really is a simple switch and for the record, if distro people would be so kind as to switch it on and report back that nothing happens, that'd be really helpful too.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140403/38c55ffa/attachment.pgp>
Quoted 29 lines · Tom Rini
Quoted 28 lines · Simon Glass
Hi Marek,
Quoted 18 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even
worse, all boards now generate this warning and I'm worried that this will cause
the more attentive maintainers to take action and produce fast fixes which won't
receive sufficient testing until release is out.Quoted 1 line
I seriously disagree with applying the patch for current release.
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Quoted 8 lines
Quoted 2 lines
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
So, Marek and I were discussing this on IRC as well. Given about a year and nothing converted (except for new things) I opted for the noisier approach. It really is a simple switch and for the record, if distro people would be so kind as to switch it on and report back that nothing happens, that'd be really helpful too.
Like I said already, it is fine for me to do this after the release, but not in -rc3 .
Best regards,
Marek Vasut
Hi Marek,
Quoted 31 lines · Tom Rini
Quoted 30 lines · Simon Glass
Quoted 29 lines
Hi Marek,
Quoted 18 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even
worse, all boards now generate this warning and I'm worried that this will cause
the more attentive maintainers to take action and produce fast fixes which won't
receive sufficient testing until release is out.Quoted 2 lines
I seriously disagree with applying the patch for current release.
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
So, Marek and I were discussing this on IRC as well. Given about a year and nothing converted (except for new things) I opted for the noisier approach. It really is a simple switch
Unfortunately, it isn't a simple switch in my case.
The
+#define CONFIG_SYS_GENERIC_BOARD on the trats2 (and probably also trats) board causes problem with power management initialization. I will not be able to fix this and validate before v2014.04.
This issue will be fixed after the release.
Quoted 6 lines
Quoted 3 lines
and for the record,
if distro people would be so kind as to switch it on and report back that nothing happens, that'd be really helpful too.Like I said already, it is fine for me to do this after the release, but not in -rc3 .
+1
Quoted 3 lines
Best regards,
Marek Vasut
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Hi Lukasz,
Quoted 41 lines · Lukasz Majewski
Hi Marek,
Quoted 31 lines · Tom Rini
Quoted 30 lines · Simon Glass
Quoted 29 lines
Hi Marek,
Quoted 18 lines · Marek Vasut
Quoted 8 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even
worse, all boards now generate this warning and I'm worried that this will cause
the more attentive maintainers to take action and produce fast fixes which won't
receive sufficient testing until release is out.Quoted 2 lines
I seriously disagree with applying the patch for current release.
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
So, Marek and I were discussing this on IRC as well. Given about a year and nothing converted (except for new things) I opted for the noisier approach. It really is a simple switch
Quoted 9 lines
Unfortunately, it isn't a simple switch in my case.
The
+#defineCONFIG_SYS_GENERIC_BOARDon the trats2 (and probably also trats) board causes problem with power management initialization. I will not be able to fix this and validate before v2014.04.This issue will be fixed after the release.
FWIW this works OK on exynos5 which has used generic board for a while. I'm not sure what the problem is - I don't see a change in the ordering of the call to power_init().
Regards,
Simon
Hi Simon,
Quoted 53 lines
Hi Lukasz,
Quoted 49 lines · Lukasz Majewski
Hi Marek,
Quoted 32 lines · Tom Rini
Quoted 31 lines · Simon Glass
Quoted 30 lines
Hi Marek,
Quoted 19 lines · Marek Vasut
Quoted 9 lines · Tom Rini
Quoted 5 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>Applied to u-boot/master, thanks!
It's now -rc3 , MW is long closed and my board start generating a warning. Even
worse, all boards now generate this warning and I'm worried that this will cause
the more attentive maintainers to take action and produce fast fixes which won't
receive sufficient testing until release is out.Quoted 2 lines
I seriously disagree with applying the patch for current release.
Despite the fact that it has been ~1 year and not a lot of people have taken action, I didn't actually expect it to go in right away, and I'm fine with a revert for this release if that's what Tom decides. But let's get it moving ASAP.
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Also let me know if there are any questions about how to test. I wrote up a README in the patch, but am happy to expand it as things come up.
So, Marek and I were discussing this on IRC as well. Given about a year and nothing converted (except for new things) I opted for the noisier approach. It really is a simple switch
Unfortunately, it isn't a simple switch in my case.
The
+#defineCONFIG_SYS_GENERIC_BOARDon the trats2 (and probably also trats) board causes problem with power management initialization. I will not be able to fix this and validate before v2014.04.
Quoted 6 lines
Quoted 2 lines
This issue will be fixed after the release.
FWIW this works OK on exynos5 which has used generic board for a while. I'm not sure what the problem is - I don't see a change in the ordering of the call to
power_init().
I've observed strange behaviour when battery was removed. I need time to investigate it.
Frankly, I plan to look closer on the power system after the release of v2014.04.
Quoted 4 lines
Regards,
Simon
Signature · 5 lines
Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
PATCH 1/1 Start the deprecation process for generic board
In reply to Simon GlassQuoted 7 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>---
Simon,
How much test has been done on powerpc boards? I randomly pick one MPC8536DS and it doesn't work. I have spent hours to track the difference and I am still struggling. I understand the first one could be more work, but if you have done any, especially 85xx family, please let me know.
York
PATCH 1/1 Start the deprecation process for generic board
Hi York,
Quoted 8 lines · York Sun
Quoted 7 lines · Simon Glass
We should move forward to remove the old board init code. Add a prominent message to encourage maintainers to get started on this work.
Signed-off-by Simon Glass <[email protected]>---
Quoted 6 lines
Simon,
How much test has been done on powerpc boards? I randomly pick one MPC8536DS and it doesn't work. I have spent hours to track the difference and I am still struggling. I understand the first one could be more work, but if you have done any, especially 85xx family, please let me know.
I don't have any of those boards. I believe Wolfgang tested three of them some time ago.
See my other message - board_init_f() doesn't zero the global_data structure. It needs to be zeroed so make sure it is done elsewhere. Originally the code uses the cache which may have been zeroed, but now global_data is on the stack (still cache but maybe a different part?). Sorry I don't understand PowerPC very well, so I'm not sure of the pre-conditions.
Also, can you please be more specific about the failure?
Regards,
Simon